Bad error message with TrustPKI = false #842

New Issue

2026-10-05T04:48:13+02:00

adam commented

2026-10-05 04:48:13 +02:00

As just seen in #znc:

× 2018-05-30 ~ 11:06:23 × *status × Connecting to [irc.freenode.net]...
× 2018-05-30 ~ 11:07:11 × *status × Disconnected from IRC (Invalid SSL certificate: ). Reconnecting...

This seems to be due to TrustPKI = false in which case the code might generate an empty error message. Something should be added to m_ssCertVerificationErrors when GetTrustPKI() is false, but everything else is fine.

As just seen in #znc: ``` × 2018-05-30 ~ 11:06:23 × *status × Connecting to [irc.freenode.net]... × 2018-05-30 ~ 11:07:11 × *status × Disconnected from IRC (Invalid SSL certificate: ). Reconnecting... ``` This seems to be due to `TrustPKI = false` in which case [the code](https://github.com/znc/znc/blob/2052d619525a99713b17b3a36851836c07dbef42/src/Socket.cpp#L134) might generate an empty error message. Something should be added to `m_ssCertVerificationErrors` when `GetTrustPKI()` is `false`, but everything else is fine.

adam commented

2026-10-05 04:48:14 +02:00

Somehow upgrading from old ZNC has left TrustPKI = false on all my networks for the last 2 years, and I was always very confused about why I had to manually trust every certificate. It's fixed now, but would have been nice if the error message pointed me to the issue.

Somehow upgrading from old ZNC has left `TrustPKI = false` on all my networks for the last 2 years, and I was always very confused about why I had to manually trust every certificate. It's fixed now, but would have been nice if the error message pointed me to the issue.

adam commented

2026-10-05 04:48:15 +02:00

You upgraded from which version to which?

сб, 14 мар. 2020 г. в 18:23, Stephanie Hobbs notifications@github.com:

Somehow upgrading from old ZNC has left TrustPKI = false on all my
networks for the last 2 years, and I was always very confused about why I
had to manually trust every certificate. It's fixed now, but would have
been nice if the error message pointed me to the issue.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/znc/znc/issues/1542#issuecomment-599043175, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACPLZDVGM4L774MI6OFY5TRHNSLRANCNFSM4FCL4MGQ
.

You upgraded from which version to which? сб, 14 мар. 2020 г. в 18:23, Stephanie Hobbs <notifications@github.com>: > Somehow upgrading from old ZNC has left TrustPKI = false on all my > networks for the last 2 years, and I was always very confused about why I > had to manually trust every certificate. It's fixed now, but would have > been nice if the error message pointed me to the issue. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/znc/znc/issues/1542#issuecomment-599043175>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AACPLZDVGM4L774MI6OFY5TRHNSLRANCNFSM4FCL4MGQ> > . >

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/znc#842