Network renaming is case-insensitive #793

New Issue

2026-10-05T04:44:41+02:00

adam commented

2026-10-05 04:44:41 +02:00

Discovered by changing the capitalisation for a network name within the web interface and resulted in Network [network] already exists message.

Discovered by changing the capitalisation for a network name within the web interface and resulted in `Network [network] already exists` message.

adam commented

2026-10-05 04:44:42 +02:00

The error message is located in AddNetwork() where a case-insensitive search returns a "conflicting" network name with the original casing.

Looks like the call to AddNetwork() begins with a binary comparison in NetworkPage().

What if we make the binary comparison in NetworkPage() case-insensitive and set the network name to pick up capitalization modifications? It doesn't need to add a new network there since only the capitalization changed, it's still the same network name from a case-insensitive point-of-view.

if (!pNetwork || !pNetwork->GetName().Equals(sName)) {
    ...
} else {
    pNetwork->SetName(sName);
}

The error message is located in [`AddNetwork()`](https://github.com/znc/znc/blob/6cd80535c064e91155468e79f50fc1c3f3c0f3e5/src/User.cpp#L511) where a case-insensitive search returns a "conflicting" network name with the original casing. Looks like the call to `AddNetwork()` begins with [a binary comparison in `NetworkPage()`](https://github.com/znc/znc/blob/6cd80535c064e91155468e79f50fc1c3f3c0f3e5/modules/webadmin.cpp#L1080). What if we make the binary comparison in `NetworkPage()` case-insensitive and set the network name to pick up capitalization modifications? It doesn't need to add a new network there since only the capitalization changed, it's still the same network name from a case-insensitive point-of-view. ```c++ if (!pNetwork || !pNetwork->GetName().Equals(sName)) { ... } else { pNetwork->SetName(sName); } ```

adam commented

2026-10-05 04:44:43 +02:00

That probably works. Webadmin is not the only way to edit networks though. Also you'll need a test.

That probably works. Webadmin is not the only way to edit networks though. Also you'll need a test.

adam commented

2026-10-05 04:44:43 +02:00

Okay, I got webadmin and /znc movenetwork. Are there other methods for renaming a network?

Okay, I got webadmin and `/znc movenetwork`. Are there other methods for renaming a network?

adam commented

2026-10-05 04:44:44 +02:00

That's it

That's it

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/znc#793