adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

SASL: "verbose no" does not disable verbose mode #714

New Issue
Closed
opened 2026-10-05 04:40:15 +02:00 by adam · 3 comments
adam commented 2026-10-05 04:40:15 +02:00
Owner
Copy link
Copy source

On ZNC 1.6.3 the new verbose yes|no command for the SASL module does not allow me to disable verbose mode:

Verbose no
<*sasl> Verbose: true

This is on Debian 7.11.

Ref: #770 & 66daadfee8

On ZNC 1.6.3 the new verbose yes|no command for the SASL module does not allow me to disable verbose mode: > <Me> Verbose no > <*sasl> Verbose: true This is on Debian 7.11. Ref: #770 & 66daadfee8f7500311be73ea0480b9eb7aad6b82 <!-- github-sync-id:164459018 -->
adam closed this issue 2026-10-05 04:40:15 +02:00
adam commented 2026-10-05 04:40:16 +02:00
Author
Owner
Copy link
Copy source

https://github.com/znc/znc/blob/ae803769c2e51831777aa8dc327d8b36a13e1f4c/modules/sasl.cpp#L79

Replace m_bVerbose = sLine.ToBool(); with m_bVerbose = sLine.Token(1, true).ToBool();. No, I'm too lazy to submit a pull request.
(The code tries to turn "verbose no" into a boolean, but it should only try to turn "no" into a boolean)

https://github.com/znc/znc/blob/ae803769c2e51831777aa8dc327d8b36a13e1f4c/modules/sasl.cpp#L79 Replace `m_bVerbose = sLine.ToBool();` with `m_bVerbose = sLine.Token(1, true).ToBool();`. No, I'm too lazy to submit a pull request. (The code tries to turn "verbose no" into a boolean, but it should only try to turn "no" into a boolean) <!-- github-comment-id:231290521 -->
adam commented 2026-10-05 04:40:16 +02:00
Author
Owner
Copy link
Copy source

As a workaround for 1.6.3, /znc reloadmod sasl would disable the verbose mode.

As a workaround for 1.6.3, `/znc reloadmod sasl` would disable the verbose mode. <!-- github-comment-id:231319558 -->
adam commented 2026-10-05 04:40:17 +02:00
Author
Owner
Copy link
Copy source

Awesome! Thanks for the extremely fast movement on this.

Awesome! Thanks for the extremely fast movement on this. <!-- github-comment-id:231400789 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#714