adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-11-03 10:52:22 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

Build broken with LibreSSL #649

New Issue
Closed
opened 2026-10-05 04:36:11 +02:00 by adam · 6 comments
adam commented 2026-10-05 04:36:11 +02:00
Owner
Copy link
Copy source

With the current ZNC 1.6.2 release the build is still broken with LibreSSL. The copy of Csocket was updated to include the fixes for the lack of SSLv3 support but somehow this commit https://github.com/jimloco/Csocket/commit/5494c125599fbe02e6d7839d1a8ebeffe3e77907 is missing from the copy included with ZNC even though the commit in question comes with Csocket proper from upstream.

With the current ZNC 1.6.2 release the build is still broken with LibreSSL. The copy of Csocket was updated to include the fixes for the lack of SSLv3 support but somehow this commit https://github.com/jimloco/Csocket/commit/5494c125599fbe02e6d7839d1a8ebeffe3e77907 is missing from the copy included with ZNC even though the commit in question comes with Csocket proper from upstream. <!-- github-sync-id:119325871 -->
adam closed this issue 2026-10-05 04:36:11 +02:00
adam commented 2026-10-05 04:36:12 +02:00
Author
Owner
Copy link
Copy source

Ah, that fix was in wrong branch...

Ah, that fix was in wrong branch... <!-- github-comment-id:160353191 -->
adam commented 2026-10-05 04:36:13 +02:00
Author
Owner
Copy link
Copy source

Nice, does this mean 1.6.3 (while 1.6.2 was released just to fix LibreSSL & OpenSSL that doesn't have SSLv3 compiled)?

Nice, does this mean 1.6.3 (while 1.6.2 was released just to fix LibreSSL & OpenSSL that doesn't have SSLv3 compiled)? <!-- github-comment-id:160393427 -->
adam commented 2026-10-05 04:36:14 +02:00
Author
Owner
Copy link
Copy source

1.6.2 was released just to fix LibreSSL & OpenSSL

I advise you to check the ChangeLog again.

> 1.6.2 was released just to fix LibreSSL & OpenSSL I advise you to check the ChangeLog again. <!-- github-comment-id:160404014 -->
adam commented 2026-10-05 04:36:14 +02:00
Author
Owner
Copy link
Copy source

I advise you to check the ChangeLog again.

From what I understood the other fixes weren't that important and 1.6.2 would have waited a lot longer time without this issue existing (like was the case with 1.4). If I am wrong, I advice everyone to try communicating more clearly.

> I advise you to check the ChangeLog again. From what I understood the other fixes weren't that important and 1.6.2 would have waited a lot longer time without this issue existing (like was the case with 1.4). If I am wrong, I advice everyone to try communicating more clearly. <!-- github-comment-id:160411757 -->
adam commented 2026-10-05 04:36:15 +02:00
Author
Owner
Copy link
Copy source

I wonder how you got such impression...

Some other changes are less important (e.g. help output of *perform), but some other changes are more important (e.g. crash-fix)

http://wiki.znc.in/ChangeLog/1.6.2 doesn't even mention LibreSSL, only OpenSSL

I wonder how you got such impression... Some other changes are less important (e.g. help output of `*perform`), but some other changes are more important (e.g. crash-fix) http://wiki.znc.in/ChangeLog/1.6.2 doesn't even mention LibreSSL, only OpenSSL <!-- github-comment-id:160413002 -->
adam commented 2026-10-05 04:36:16 +02:00
Author
Owner
Copy link
Copy source

I cherry-picked it to the 1.6 branch (https://github.com/jimloco/Csocket/commit/8b6636f04272e10dd52acb9081564dfc13b56b4b), so closing as duplicate of #594

I cherry-picked it to the 1.6 branch (https://github.com/jimloco/Csocket/commit/8b6636f04272e10dd52acb9081564dfc13b56b4b), so closing as duplicate of #594 <!-- github-comment-id:181558061 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#649