autoop: simplify/cleanup the "listusers" output. #647

Open
opened 2026-10-05 04:36:09 +02:00 by adam · 0 comments
Owner

The autoop module got a nice new feature that allows users to have multiple masks per user. https://github.com/znc/znc/commits/master/modules/autoop.cpp?author=orchid-hybrid

Those commits created something like this:

<KindOne> listusers
<*autoop> +============+========================================+===========+=================+
<*autoop> | User       | Hostmasks                              | Key       | Channels        |
<*autoop> +============+========================================+===========+=================+
<*autoop> | foobar     | *!*@foobar.com                         | __NOKEY__ | #znc            |
<*autoop> +------------+----------------------------------------+-----------+-----------------+
<*autoop> | KindOne    | *!*@colchester-lug/silly-fool/donut    | __NOKEY__ | #znc            |
<*autoop> +------------+----------------------------------------+-----------+-----------------+
<*autoop> | |-         | *!*KindOne@gateway/shell/trekweb.org/* |           |                 |
<*autoop> +------------+----------------------------------------+-----------+-----------------+
<*autoop> | `-         | *!uid3688@gateway/web/irccloud.com/*   |           |                 |
<*autoop> +------------+----------------------------------------+-----------+-----------------+
<*autoop> | znc        | *!*@1.2.3.4                            | __NOKEY__ | #znc            |
<*autoop> +------------+----------------------------------------+-----------+-----------------+
<*autoop> | |-         | *!*@znc.rules.com                      |           |                 |
<*autoop> +------------+----------------------------------------+-----------+-----------------+
<*autoop> | `-         | *!*@znc/user/znc                       |           |                 |
<*autoop> +============+========================================+===========+=================+

Then somewhere in 1.7.x the output got altered and now it just looks horrible with all the User: |-, User: -, and -----` clutter.

<KindOne> listusers
<*autoop> ------
<*autoop> User: foobar
<*autoop> Hostmasks: *!*@foobar.com
<*autoop> Key: __NOKEY__
<*autoop> Channels: #znc
<*autoop> ------
<*autoop> User: KindOne
<*autoop> Hostmasks: *!*@colchester-lug/silly-fool/donut
<*autoop> Key: __NOKEY__
<*autoop> Channels: #znc
<*autoop> ------
<*autoop> User: |-
<*autoop> Hostmasks: *!*KindOne@gateway/shell/trekweb.org/*
<*autoop> ------
<*autoop> User: `-
<*autoop> Hostmasks: *!uid3688@gateway/web/irccloud.com/*
<*autoop> ------
<*autoop> User: znc
<*autoop> Hostmasks: *!*@1.2.3.4
<*autoop> Key: __NOKEY__
<*autoop> Channels: #znc
<*autoop> ------
<*autoop> User: |-
<*autoop> Hostmasks: *!*@znc.rules.com
<*autoop> ------
<*autoop> User: `-
<*autoop> Hostmasks: *!*@znc/user/znc
<*autoop> ------

I'm suggesting the output can be improved by removing all the User: |- and User: -`.
Suggested output:

<KindOne> listusers
<*autoop> ------
<*autoop> User: foobar
<*autoop> Hostmasks: *!*@foobar.com
<*autoop> Key: __NOKEY__
<*autoop> Channels: #znc
<*autoop> ------
<*autoop> User: KindOne
<*autoop> Hostmasks: *!*@colchester-lug/silly-fool/donut
<*autoop> Hostmasks: *!*KindOne@gateway/shell/trekweb.org/*
<*autoop> Hostmasks: *!uid3688@gateway/web/irccloud.com/*
<*autoop> Key: __NOKEY__
<*autoop> Channels: #znc
<*autoop> ------
<*autoop> User: znc
<*autoop> Hostmasks: *!*@1.2.3.4
<*autoop> Hostmasks: *!*@znc.rules.com
<*autoop> Hostmasks: *!*@znc/user/znc
<*autoop> Key: __NOKEY__
<*autoop> Channels: #znc
<*autoop> ------

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The autoop module got a nice new feature that allows users to have multiple masks per user. https://github.com/znc/znc/commits/master/modules/autoop.cpp?author=orchid-hybrid Those commits created something like this: ``` <KindOne> listusers <*autoop> +============+========================================+===========+=================+ <*autoop> | User | Hostmasks | Key | Channels | <*autoop> +============+========================================+===========+=================+ <*autoop> | foobar | *!*@foobar.com | __NOKEY__ | #znc | <*autoop> +------------+----------------------------------------+-----------+-----------------+ <*autoop> | KindOne | *!*@colchester-lug/silly-fool/donut | __NOKEY__ | #znc | <*autoop> +------------+----------------------------------------+-----------+-----------------+ <*autoop> | |- | *!*KindOne@gateway/shell/trekweb.org/* | | | <*autoop> +------------+----------------------------------------+-----------+-----------------+ <*autoop> | `- | *!uid3688@gateway/web/irccloud.com/* | | | <*autoop> +------------+----------------------------------------+-----------+-----------------+ <*autoop> | znc | *!*@1.2.3.4 | __NOKEY__ | #znc | <*autoop> +------------+----------------------------------------+-----------+-----------------+ <*autoop> | |- | *!*@znc.rules.com | | | <*autoop> +------------+----------------------------------------+-----------+-----------------+ <*autoop> | `- | *!*@znc/user/znc | | | <*autoop> +============+========================================+===========+=================+ ``` Then somewhere in 1.7.x the output got altered and now it just looks horrible with all the `User: |-`, `User: `-`, and `-----` clutter. ``` <KindOne> listusers <*autoop> ------ <*autoop> User: foobar <*autoop> Hostmasks: *!*@foobar.com <*autoop> Key: __NOKEY__ <*autoop> Channels: #znc <*autoop> ------ <*autoop> User: KindOne <*autoop> Hostmasks: *!*@colchester-lug/silly-fool/donut <*autoop> Key: __NOKEY__ <*autoop> Channels: #znc <*autoop> ------ <*autoop> User: |- <*autoop> Hostmasks: *!*KindOne@gateway/shell/trekweb.org/* <*autoop> ------ <*autoop> User: `- <*autoop> Hostmasks: *!uid3688@gateway/web/irccloud.com/* <*autoop> ------ <*autoop> User: znc <*autoop> Hostmasks: *!*@1.2.3.4 <*autoop> Key: __NOKEY__ <*autoop> Channels: #znc <*autoop> ------ <*autoop> User: |- <*autoop> Hostmasks: *!*@znc.rules.com <*autoop> ------ <*autoop> User: `- <*autoop> Hostmasks: *!*@znc/user/znc <*autoop> ------ ``` I'm suggesting the output can be improved by removing all the `User: |-` and `User: `-`. Suggested output: ``` <KindOne> listusers <*autoop> ------ <*autoop> User: foobar <*autoop> Hostmasks: *!*@foobar.com <*autoop> Key: __NOKEY__ <*autoop> Channels: #znc <*autoop> ------ <*autoop> User: KindOne <*autoop> Hostmasks: *!*@colchester-lug/silly-fool/donut <*autoop> Hostmasks: *!*KindOne@gateway/shell/trekweb.org/* <*autoop> Hostmasks: *!uid3688@gateway/web/irccloud.com/* <*autoop> Key: __NOKEY__ <*autoop> Channels: #znc <*autoop> ------ <*autoop> User: znc <*autoop> Hostmasks: *!*@1.2.3.4 <*autoop> Hostmasks: *!*@znc.rules.com <*autoop> Hostmasks: *!*@znc/user/znc <*autoop> Key: __NOKEY__ <*autoop> Channels: #znc <*autoop> ------ ``` ## <bountysource-plugin> Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/28638726-autoop-simplify-cleanup-the-listusers-output?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github). </bountysource-plugin> <!-- github-sync-id:119086798 -->
adam changed title from autoop: simplify/cleanup the "listusers" output. to autoop: simplify/cleanup the "listusers" output. 2026-10-27 15:09:50 +01:00
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#647