adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

Can't login when password contains spaces #641

New Issue
Closed
opened 2026-10-05 04:35:40 +02:00 by adam · 2 comments
adam commented 2026-10-05 04:35:40 +02:00
Owner
Copy link
Copy source

As of 933aa6db I can no longer log in with a password through IRC with cyrusauth, and reverting it makes it work again.

As of 933aa6db I can no longer log in with a password through IRC with cyrusauth, and reverting it makes it work again. <!-- github-sync-id:118466124 -->
adam closed this issue 2026-10-05 04:35:40 +02:00
adam commented 2026-10-05 04:35:42 +02:00
Author
Owner
Copy link
Copy source

Seems this is a client issue actually, sorry for the noise.

Seems this is a client issue actually, sorry for the noise. <!-- github-comment-id:159057847 -->
adam commented 2026-10-05 04:35:42 +02:00
Author
Owner
Copy link
Copy source

For more context:

[23 ноя, 20:30:14] <demize> oh, fun.
[23 ноя, 20:30:24] <demize> Reverting 933aa6db0ce46353b8c18a464baad06c147c9842 makes cyrusauth work again.
[23 ноя, 20:31:43] <DarthGandalf> demize: mhm.
[23 ноя, 20:32:32] <demize> Opened a GH issue about it
[23 ноя, 20:32:41] <DarthGandalf> demize: your client sends password in what format?
[23 ноя, 20:32:55] <demize> Server password? Plain text?
[23 ноя, 20:33:12] <demize> I mean, there's not much of a choice in the matter ;p
[23 ноя, 20:33:14] <DarthGandalf> That change fixed the case of having : before password
[23 ноя, 20:33:32] <demize> It's sending just the password in the password field.
[23 ноя, 20:33:49] <DarthGandalf> Without username? Does the password have any : ?
[23 ноя, 20:34:26] <demize> username and network name are sent in the username field, and the password doesn't have any colons, no.
[23 ноя, 20:34:46] <DarthGandalf> does it have any spaces?
[23 ноя, 20:34:55] <DarthGandalf> if you check znc -D, is the password prefixed with : ?
[23 ноя, 20:35:12] <demize> Spaces, yes.
[23 ноя, 20:35:23] <demize> And I don't need to check the debug output, I know how it's sent.
[23 ноя, 20:35:35] <demize> (And shutting down znc is disruptive as I have multiple users active at the moment.)
[23 ноя, 20:35:47] <DarthGandalf> client sometimes has raw window too
[23 ноя, 20:36:07] <demize> This isn't a client issue.
[23 ноя, 20:36:17] <DarthGandalf> If it doesn't prefix password with :, it is a client issue
[23 ноя, 20:36:26] <DarthGandalf> the last parameter must have : if it has spaces
[23 ноя, 20:36:34] <DarthGandalf> otherwise, it's several parameters, according to IRC
[23 ноя, 20:36:51] <DarthGandalf> s/$/ spec/
[23 ноя, 20:36:51] <ZNC-Linker> DarthGandalf meant: “otherwise, it's several parameters, according to IRC spec”
[23 ноя, 20:38:00] <demize> Oh right, hmm.
[23 ноя, 20:38:10] <demize> It seems that multiple clients are broken then, hmm..
[23 ноя, 20:38:58] <DarthGandalf> Not many people have spaces in their password, so it's not very heavily tested...
For more context: ``` [23 ноя, 20:30:14] <demize> oh, fun. [23 ноя, 20:30:24] <demize> Reverting 933aa6db0ce46353b8c18a464baad06c147c9842 makes cyrusauth work again. [23 ноя, 20:31:43] <DarthGandalf> demize: mhm. [23 ноя, 20:32:32] <demize> Opened a GH issue about it [23 ноя, 20:32:41] <DarthGandalf> demize: your client sends password in what format? [23 ноя, 20:32:55] <demize> Server password? Plain text? [23 ноя, 20:33:12] <demize> I mean, there's not much of a choice in the matter ;p [23 ноя, 20:33:14] <DarthGandalf> That change fixed the case of having : before password [23 ноя, 20:33:32] <demize> It's sending just the password in the password field. [23 ноя, 20:33:49] <DarthGandalf> Without username? Does the password have any : ? [23 ноя, 20:34:26] <demize> username and network name are sent in the username field, and the password doesn't have any colons, no. [23 ноя, 20:34:46] <DarthGandalf> does it have any spaces? [23 ноя, 20:34:55] <DarthGandalf> if you check znc -D, is the password prefixed with : ? [23 ноя, 20:35:12] <demize> Spaces, yes. [23 ноя, 20:35:23] <demize> And I don't need to check the debug output, I know how it's sent. [23 ноя, 20:35:35] <demize> (And shutting down znc is disruptive as I have multiple users active at the moment.) [23 ноя, 20:35:47] <DarthGandalf> client sometimes has raw window too [23 ноя, 20:36:07] <demize> This isn't a client issue. [23 ноя, 20:36:17] <DarthGandalf> If it doesn't prefix password with :, it is a client issue [23 ноя, 20:36:26] <DarthGandalf> the last parameter must have : if it has spaces [23 ноя, 20:36:34] <DarthGandalf> otherwise, it's several parameters, according to IRC [23 ноя, 20:36:51] <DarthGandalf> s/$/ spec/ [23 ноя, 20:36:51] <ZNC-Linker> DarthGandalf meant: “otherwise, it's several parameters, according to IRC spec” [23 ноя, 20:38:00] <demize> Oh right, hmm. [23 ноя, 20:38:10] <demize> It seems that multiple clients are broken then, hmm.. [23 ноя, 20:38:58] <DarthGandalf> Not many people have spaces in their password, so it's not very heavily tested... ``` <!-- github-comment-id:159058491 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#641