adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

Missing Csocket source in 1.6.1 published tarball #632

New Issue
Closed
opened 2026-10-05 04:35:07 +02:00 by adam · 2 comments
adam commented 2026-10-05 04:35:07 +02:00
Owner
Copy link
Copy source

I might be misunderstanding the ZNC build process, but it seems that the third_party\Csocket directory is a git submodule, and that content is not making it into the published tarball at http://znc.in/releases/znc-1.6.1.tar.gz.

This manifests at build time, I think, as something like:

...
Building core object Csocket...
src/Csocket.cpp: In member function ‘virtual bool Csock::SSLClientSetup()’:
src/Csocket.cpp:1467:48: error: ‘SSLv3_client_method’ was not declared in this scope
   m_ssl_ctx = SSL_CTX_new( SSLv3_client_method() );
                                                ^
src/Csocket.cpp: In member function ‘SSL_CTX* Csock::SetupServerCTX()’:
src/Csocket.cpp:1589:43: error: ‘SSLv3_server_method’ was not declared in this scope
   pCTX = SSL_CTX_new( SSLv3_server_method() );

Maybe I misunderstood what's happening at build time, and there's something subtle about that third_party directory in the distributed tarball?

In any case, I've built an Ubuntu 14.04 virtual machine, and followed the instructions at http://wiki.znc.in/Installation#Build_From_Source and received the above error at make time.

I believe this same process worked fine about a month ago, if that's of any help.

I might be misunderstanding the ZNC build process, but it seems that the `third_party\Csocket` directory is a git submodule, and that content is not making it into the published tarball at http://znc.in/releases/znc-1.6.1.tar.gz. This manifests at build time, I think, as something like: ``` ... Building core object Csocket... src/Csocket.cpp: In member function ‘virtual bool Csock::SSLClientSetup()’: src/Csocket.cpp:1467:48: error: ‘SSLv3_client_method’ was not declared in this scope m_ssl_ctx = SSL_CTX_new( SSLv3_client_method() ); ^ src/Csocket.cpp: In member function ‘SSL_CTX* Csock::SetupServerCTX()’: src/Csocket.cpp:1589:43: error: ‘SSLv3_server_method’ was not declared in this scope pCTX = SSL_CTX_new( SSLv3_server_method() ); ``` Maybe I misunderstood what's happening at build time, and there's something subtle about that `third_party` directory in the distributed tarball? In any case, I've built an Ubuntu 14.04 virtual machine, and followed the instructions at http://wiki.znc.in/Installation#Build_From_Source and received the above error at make time. I believe this same process worked fine about a month ago, if that's of any help. <!-- github-sync-id:114499658 -->
adam closed this issue 2026-10-05 04:35:08 +02:00
adam commented 2026-10-05 04:35:09 +02:00
Author
Owner
Copy link
Copy source

When packing tarball, Csocket.cc from the submodule is copied to src/Csocket.cpp with some modifications (see make-tarball.sh). Yes, it's subtle.

The SSL error is fixed at #1146 so you can use 1.7 from either git or nightly tarball

When packing tarball, `Csocket.cc` from the submodule is copied to `src/Csocket.cpp` with some modifications (see `make-tarball.sh`). Yes, it's subtle. The SSL error is fixed at #1146 so you can use 1.7 from either git or nightly tarball <!-- github-comment-id:152874915 -->
adam commented 2026-10-05 04:35:09 +02:00
Author
Owner
Copy link
Copy source

A-ha, so I was barking up the wrong tree. Thanks for the quick feedback, I'll try the nightlies.

A-ha, so I was barking up the wrong tree. Thanks for the quick feedback, I'll try the nightlies. <!-- github-comment-id:152874954 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#632