"Invalid user settings" message should be more clear #625
Assignees
adam (Adam Wojcieszonek)
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: adam/znc#625
Reference in new issue
Block a user
When trying to edit my user settings in ZNC 1.6.1, I randomly got an "Invalid user settings" error when trying to save them in the web interface. It turns out that Firefox was filling in my stored password despite the autocomplete=off markup, and as a consequence it didn't match the password confirmation input field.
ZNC should give more user-friendly feedback by actually indicating which settings were invalid (in this case: "Passwords do not match" or something similar).
Do you happen to be using patched ZNC (the SSL patch or some third party webadmin theme (firre is especially problematic with these issues))? If not, you are probably trying to set some setting as invalid such as emptying realname.
ICU support doesn't affect anything else than charset and if you want it, install
libicu-dev(you didn't read the bug reporting guidelines as your OS is missing so I am doing Debian assumption) and recompile ZNC.Nevermind, I might have found the issue - I do have the main login for ZNC stored in the browser's password manager, but despite the autocomplete=off markup, Firefox seems to keep filling in the password when visting the page for the first time. As such it doesn't match the empty confirm password field, naturally.
Nevertheless, it would have been useful if ZNC actually told me e.g. that passwords don't match, rather than making me guess which of the dozens of options on this page is not configured correctly.
Please open separate issue for that or make it clear in the title what this issue is about.
I've edited the title and initial description to be more clear.
I would change the title to
Say "Passwords don't match" instead of "Invalid user settings", but maybe the current one is more clear as there are more things that can be invalid too.Yes, that's my point with the title: ZNC knows exactly which settings are invalid (otherwise it could not emit this error message), so it should tell the user exactly what is wrong - not only for the password fields.
👍 for this. Noticed this today as well, would be nice to have!
👍 Thank you! I have been having this problem for a while, but thanks to this issue, I finally understand why.
Ran into this issue today as well (in Firefox). Might be worth trying some of the tricks mentioned here: https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion - especially the
autocomplete="nope"to trick the browser to not autocomplete.My guess is that it would also be possible to work around this by using a different name for the input field:
Password: <input name="something_random" autocomplete="nope" />.Same issue happened to me. 👍 for a clearer message.
@xintron
autocomplete="nope"still causes Firefox to autocomplete :-(@DarthGandalf: The title of the issue was chosen because it was not just about the password field (even though most people seemed to only be concerned about that). Your commit only fixed that part of the problem, so I think the issue should remain open under the old title. There are still other situations where the "invalid user settings" message is not descriptive enough.
@sagamusix ok. I fixed both issues though, in 2 commits.
this is annoying. until i actually stumbled across this and found out that i have to blank the password field i was deleting and resetting up accounts just to get back to changing settings and is still an issue with the latest version of znc. an error messages "SHOULD" always return the setting that caused the error not just that an error occurred and leave it at that. this is a bug still present in the latest version.