adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

Feature request: add server details in *status messages #616

New Issue
Open
opened 2026-10-05 04:33:36 +02:00 by adam · 4 comments
adam commented 2026-10-05 04:33:36 +02:00
Owner
Copy link
Copy source

Currently, my *status query looks like this:

*status Connection Refused.  Reconnecting...
*status IRC connection timed out.  Reconnecting...
     me jump
*status Jumping to the next server in the list...

It would be nice if (at least) server address would be included in these messages.

Also, there are two spaces after the period.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Currently, my `*status` query looks like this: ``` *status Connection Refused. Reconnecting... *status IRC connection timed out. Reconnecting... me jump *status Jumping to the next server in the list... ``` It would be nice if (at least) server address would be included in these messages. Also, there are [two spaces after the period](http://www.slate.com/articles/technology/technology/2011/01/space_invaders.html). ## <bountysource-plugin> --- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27354296-feature-request-add-server-details-in-status-messages?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github). </bountysource-plugin> <!-- github-sync-id:111028482 -->
adam commented 2026-10-05 04:33:37 +02:00
Author
Owner
Copy link
Copy source

I am not sure which PR to comment, so I will just comment this issue (cc: @jreese)

My suggestion would be not only showing the server name from server list, but also the IP and potential reverse DNS. Reverse DNS wouldn't be shown if empty and IP probably isn't needed when connecting to ip.

  • chat.freenode.net (x.x.x.x (sendak.freenode.net))
  • irc.freenode.net (x:x:x:x (rajaniemi.freenode.net))
_I am not sure which PR to comment, so I will just comment this issue (cc: @jreese)_ My suggestion would be not only showing the server name from server list, but also the IP and potential reverse DNS. Reverse DNS wouldn't be shown if empty and IP probably isn't needed when connecting to ip. - `chat.freenode.net (x.x.x.x (sendak.freenode.net))` - `irc.freenode.net (x:x:x:x (rajaniemi.freenode.net))` <!-- github-comment-id:147614590 -->
adam commented 2026-10-05 04:33:37 +02:00
Author
Owner
Copy link
Copy source

The second PR is the correct one. For now, this is just reusing the existing connection messages, so showing more info will necessitate modifying the message for all connections. If that seems reasonable, then I'm happy to make that adjustment.

The second PR is the correct one. For now, this is just reusing the existing connection messages, so showing more info will necessitate modifying the message for all connections. If that seems reasonable, then I'm happy to make that adjustment. <!-- github-comment-id:147616403 -->
adam commented 2026-10-05 04:33:38 +02:00
Author
Owner
Copy link
Copy source

That PR doesn't fully fix it though

That PR doesn't fully fix it though <!-- github-comment-id:148305349 -->
adam commented 2026-10-05 04:33:39 +02:00
Author
Owner
Copy link
Copy source

As far as the spaces go, if you change it at one place, you should change it everywhere.

filtered grep for measurement (just to give a rough idea, might not contain all):

src/ClientCommand.cpp:      PutStatus("There were [" + CString(sChans.size()) + "] channels  matching [" + sPatterns + "]");
src/Client.cpp: // Don't forward this msg.  We don't want the client getting us disconnected.
src/IRCSock.cpp:        m_pNetwork->PutStatus("IRC connection timed out.  Reconnecting...");
src/IRCSock.cpp:        m_pNetwork->PutStatus("Connection Refused.  Reconnecting...");
src/Template.cpp:           DEBUG("\t\tSkipping path (not from INC)  [" + sFilePath + "]");
src/WebModules.cpp:     sSessionID += ":" + GetLocalIP()  + ":" + CString(GetLocalPort());
src/znc.cpp:    CUtils::PrintMessage("using the port that you supplied.  You have to supply your login info", true);
src/znc.cpp:            DEBUG("Failed to reload [" <<  sModule << "] globally [" << sErr << "]");
src/znc.cpp:            DEBUG("Failed to reload [" <<  sModule << "] for ["
src/znc.cpp:            DEBUG("Failed to reload [" <<  sModule << "] for ["
modules/autoop.cpp:         PutModule("[" + Nick.GetHostMask() + "] sent an unchallenged response.  This could be due to lag.");
modules/autoop.cpp:                 PutModule("WARNING! [" + Nick.GetHostMask() + "] sent a bad response.  Please verify that you have their correct password.");
modules/awaystore.cpp:          CString sTmp = "    " + CString(a) + ") [";
modules/log.cpp:                sMessage = "Invalid args [" + sArgs + "]. Only one log path allowed.  Check that there are no spaces in the path.";
modules/notes.cpp:          PutModule("That note already exists.  Use MOD <key> <note> to overwrite.");
modules/notes.cpp:              PutModNotice("That note already exists.  Use /#+<key> <note> to overwrite.");
modules/watch.cpp:          sMessage = "Watch: Not enough arguments.  Try Help";
As far as the spaces go, if you change it at one place, you should change it everywhere. filtered grep for measurement (just to give a rough idea, might not contain all): ``` src/ClientCommand.cpp: PutStatus("There were [" + CString(sChans.size()) + "] channels matching [" + sPatterns + "]"); src/Client.cpp: // Don't forward this msg. We don't want the client getting us disconnected. src/IRCSock.cpp: m_pNetwork->PutStatus("IRC connection timed out. Reconnecting..."); src/IRCSock.cpp: m_pNetwork->PutStatus("Connection Refused. Reconnecting..."); src/Template.cpp: DEBUG("\t\tSkipping path (not from INC) [" + sFilePath + "]"); src/WebModules.cpp: sSessionID += ":" + GetLocalIP() + ":" + CString(GetLocalPort()); src/znc.cpp: CUtils::PrintMessage("using the port that you supplied. You have to supply your login info", true); src/znc.cpp: DEBUG("Failed to reload [" << sModule << "] globally [" << sErr << "]"); src/znc.cpp: DEBUG("Failed to reload [" << sModule << "] for [" src/znc.cpp: DEBUG("Failed to reload [" << sModule << "] for [" modules/autoop.cpp: PutModule("[" + Nick.GetHostMask() + "] sent an unchallenged response. This could be due to lag."); modules/autoop.cpp: PutModule("WARNING! [" + Nick.GetHostMask() + "] sent a bad response. Please verify that you have their correct password."); modules/awaystore.cpp: CString sTmp = " " + CString(a) + ") ["; modules/log.cpp: sMessage = "Invalid args [" + sArgs + "]. Only one log path allowed. Check that there are no spaces in the path."; modules/notes.cpp: PutModule("That note already exists. Use MOD <key> <note> to overwrite."); modules/notes.cpp: PutModNotice("That note already exists. Use /#+<key> <note> to overwrite."); modules/watch.cpp: sMessage = "Watch: Not enough arguments. Try Help"; ``` <!-- github-comment-id:148367226 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#616