After a module returns false in OnLoad, znc fails to update the module. #51

New Issue

Closed

opened 2026-10-05 03:56:16 +02:00 by adam · 8 comments

adam commented 2026-10-05 03:56:16 +02:00

Owner

Copy link

Copy source

1. Give a module argument in znc.conf so that the module returns false in OnLoad.

2. Execute /znc rehash to make znc re-read the configuration.

3. rehash fails since a module returned false in OnLoad.

4. Give a new argument for the module in znc.conf so that the module returns true in OnLoad.
   Try either 5) or 6) in any order.

5. execute /znc updatemod "module", and updatemod succeeds, but the module is not really updated.

6. execute /znc rehash, and rehash succeeds, but the module is not really updated.

Here is an example.

When Module "A" receives 1 or 2 as argument, it returns true in OnLoad.
When Module "B" receives 3 as argument, it returns false in OnLoad.

You initially had LoadModule = A 1
You changed it to LoadModule = A 3, and rehashed.
Rehash fails.
After you change it to LoadModule = A 2, either "/znc rehash A" or "/znc updatemod A" fails to make A accept "2".

1) Give a module argument in znc.conf so that the module returns false in OnLoad. 2) Execute /znc rehash to make znc re-read the configuration. 3) rehash fails since a module returned false in OnLoad. 4) Give a new argument for the module in znc.conf so that the module returns true in OnLoad. Try either 5) or 6) in any order. 5) execute /znc updatemod "module", and updatemod succeeds, but the module is not really updated. 6) execute /znc rehash, and rehash succeeds, but the module is not really updated. Here is an example. When Module "A" receives 1 or 2 as argument, it returns true in OnLoad. When Module "B" receives 3 as argument, it returns false in OnLoad. You initially had LoadModule = A 1 You changed it to LoadModule = A 3, and rehashed. Rehash fails. After you change it to LoadModule = A 2, either "/znc rehash A" or "/znc updatemod A" fails to make A accept "2". <!-- github-sync-id:2920340 -->

adam closed this issue 2026-10-05 03:56:16 +02:00

adam commented 2026-10-05 03:56:17 +02:00

Author

Owner

Copy link

Copy source

This bug doesn't exist but only for my module.
I'm going to close it.

This bug doesn't exist but only for my module. I'm going to close it. <!-- github-comment-id:3595106 -->

adam commented 2026-10-05 03:56:17 +02:00

Author

Owner

Copy link

Copy source

It happens with another sample module on the latest git version I compiled yesterday.
So I'm reopening it.

It happens with another sample module on the latest git version I compiled yesterday. So I'm reopening it. <!-- github-comment-id:3595271 -->

adam commented 2026-10-05 03:56:18 +02:00

Author

Owner

Copy link

Copy source

ZNC is already running. I add "LoadModule = dcc" to an user that is NOT admin and do pkill -HUP znc:

[ !! ] Loading Module [dcc]... [ Module [dcc] aborted: You must be admin to use the DCC module ]
[ ** ] Module [dcc] aborted: You must be admin to use the DCC module

I make the user an admin again, pkill -HUP znc and:

 [ ok ] Loading Module [dcc]... [./modules/extra/dcc.so]

Rehash says module was loaded, but:

11:02:56 < *status> User modules:
11:02:56 < *status> +------------+-----------+
11:02:56 < *status> | Name | Arguments |
11:02:56 < *status> +------------+-----------+
11:02:56 < *status> | bouncedcc | |
11:02:56 < *status> | notes | |
11:02:56 < *status> | admin | |
11:02:56 < *status> | autoattach | |
11:02:56 < *status> | perform | |
11:02:56 < *status> | autocycle | |
11:02:56 < *status> +------------+-----------+
11:02:56 < *status> Network modules:
11:02:56 < *status> +---------------+-----------+
11:02:56 < *status> | Name | Arguments |
11:02:56 < *status> +---------------+-----------+
11:02:56 < *status> | route_replies | |
11:02:56 < *status> | nickserv | |
11:02:56 < *status> +---------------+-----------+

Also. this user isn't an admin, because:

11:01:48 < *status> Unknown command [updatemod] try 'Help'

So sounds like rehashing is broken in general?

ZNC is already running. I add "LoadModule = dcc" to an user that is NOT admin and do pkill -HUP znc: ``` [ !! ] Loading Module [dcc]... [ Module [dcc] aborted: You must be admin to use the DCC module ] [ ** ] Module [dcc] aborted: You must be admin to use the DCC module ``` I make the user an admin again, pkill -HUP znc and: ``` [ ok ] Loading Module [dcc]... [./modules/extra/dcc.so] ``` Rehash says module was loaded, but: 11:02:56 < *status> User modules: 11:02:56 < *status> +------------+-----------+ 11:02:56 < *status> | Name | Arguments | 11:02:56 < *status> +------------+-----------+ 11:02:56 < *status> | bouncedcc | | 11:02:56 < *status> | notes | | 11:02:56 < *status> | admin | | 11:02:56 < *status> | autoattach | | 11:02:56 < *status> | perform | | 11:02:56 < *status> | autocycle | | 11:02:56 < *status> +------------+-----------+ 11:02:56 < *status> Network modules: 11:02:56 < *status> +---------------+-----------+ 11:02:56 < *status> | Name | Arguments | 11:02:56 < *status> +---------------+-----------+ 11:02:56 < *status> | route_replies | | 11:02:56 < *status> | nickserv | | 11:02:56 < *status> +---------------+-----------+ Also. this user isn't an admin, because: 11:01:48 < *status> Unknown command [updatemod] try 'Help' So sounds like rehashing is broken in general? <!-- github-comment-id:3595443 -->

adam commented 2026-10-05 03:56:19 +02:00

Author

Owner

Copy link

Copy source

The issue is not just with modules, but somehow the user's seem to get leaked. Existing clients will use the some old CUser object, but new clients will get a different CUser object.

From a breakpoint in "get RealName tesa" after the user lookup we can see the current user != the tesa user.

(gdb) p pUser
$2 = (CUser *) 0x7fffffffc3b0
(gdb) p m_pUser
$3 = (CUser *) 0xb93800

A new user seems to created from the config in some cases when we rehash, instead the old user should be updated.

The issue is not just with modules, but somehow the user's seem to get leaked. Existing clients will use the some old CUser object, but new clients will get a different CUser object.  From a breakpoint in "get RealName tesa" after the user lookup we can see the current user != the tesa user. ``` (gdb) p pUser $2 = (CUser *) 0x7fffffffc3b0 (gdb) p m_pUser $3 = (CUser *) 0xb93800 ``` A new user seems to created from the config in some cases when we rehash, instead the old user should be updated. <!-- github-comment-id:3697628 -->

adam commented 2026-10-05 03:56:19 +02:00

Author

Owner

Copy link

Copy source

If any network has IRCConnectEnabled set to true in znc.conf, when you rehash,
the following segmentation fault is caused.

(crocket/freenode) CLI -> ZNC [znc rehash]
[ ok ] Opening Config [/etc/znc/configs/znc.conf]...
[ ** ] Module [partyline] already loaded.
[ ** ] Module [webadmin] already loaded.
[ ok ] Binding to port [+1491]...
[ ** ] Loading user [crocket]
[ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so]
[ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so]
[ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so]
[ ok ] Adding Server [efnet.xs4all.nl +6697]...
[ ok ] Adding Server [irc.he.net +6697]...
[ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so]
[ ok ] Loading Module [nickserv]... [/usr/lib64/znc/nickserv.so]
[ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so]
[ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so]
[ ok ] Adding Server [irc.freenode.net +6697]...
[ ok ] Loading Module [perform]... [/usr/lib64/znc/perform.so]
[ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so]
[ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so]
[ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so]
[ ok ] Adding Server [apink.hanirc.org 8080]...
[ ok ] Loading Module [nickserv]... [/usr/lib64/znc/nickserv.so]
[ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so]
[ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so]
[ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so]
[ ok ] Adding Server [irc.oftc.net +6697]...
[ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so]
[ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so]
[ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so]
[ ok ] Adding Server [ssl.ozinger.org +16667]...
[ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so]
[ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so]
[ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so]
[ ok ] Adding Server [irc.ph2network.org +6697]...
[ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so]
[ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so]
[ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so]
[ ok ] Adding Server [irc.rizon.net +6697]...
[ ok ] Loading Module [admin]... [/usr/lib64/znc/admin.so]
[ ok ] Loading Module [bouncedcc]... /usr/lib64/znc/bouncedcc.so ZNC -> CLI [:*status!znc@znc.in PRIVMSG crocket :Rehashing succeeded!]
Connecting user/network [..sogaH�Sn��Lt����/etc/znc/users/crocket/networks/rizon/moddata/simple_away/.registryy5;2c%23;5%0a;mode%20;%25;nick%25;%20;%2b;x%0a;�{���Sn���Sn��{��Sn�����Perform PRIVMSG%20;%5e;%5e;%20;%3a;%ec;%9d;%b8;%ec;%a6;%9d;%20;crocket%20;Sok3%25;2c%23;5%0a;mode%20;%25;nick%25;%20;%2b;x%0a;h�y``�{4����Send replies (e.g. to /who) to the right client only_away/.regi�Pv{��Sn��{x�y@{@{p{p{�t�s�Lt�{8�z��y�{X��n�(�y��r�{�{@{@{�{�{X��n��{<����/etc/znc/users/crocket/networks/hanirc/moddata/route_repliesa`{;����/etc/rc.d/rc.znc: line 24: 12316 Segmentation fault sudo -u $ZNC_USER -i /usr/bin/znc --datadir /etc/znc -D -f

If any network has IRCConnectEnabled set to true in znc.conf, when you rehash, the following segmentation fault is caused. (crocket/freenode) CLI -> ZNC [znc rehash] [ ok ] Opening Config [/etc/znc/configs/znc.conf]... [ *\* ] Module [partyline] already loaded. [ *\* ] Module [webadmin] already loaded. [ ok ] Binding to port [+1491]... [ *\* ] Loading user [crocket] [ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so] [ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so] [ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so] [ ok ] Adding Server [efnet.xs4all.nl +6697]... [ ok ] Adding Server [irc.he.net +6697]... [ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so] [ ok ] Loading Module [nickserv]... [/usr/lib64/znc/nickserv.so] [ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so] [ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so] [ ok ] Adding Server [irc.freenode.net +6697]... [ ok ] Loading Module [perform]... [/usr/lib64/znc/perform.so] [ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so] [ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so] [ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so] [ ok ] Adding Server [apink.hanirc.org 8080]... [ ok ] Loading Module [nickserv]... [/usr/lib64/znc/nickserv.so] [ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so] [ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so] [ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so] [ ok ] Adding Server [irc.oftc.net +6697]... [ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so] [ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so] [ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so] [ ok ] Adding Server [ssl.ozinger.org +16667]... [ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so] [ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so] [ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so] [ ok ] Adding Server [irc.ph2network.org +6697]... [ ok ] Loading Module [simple_away]... [/usr/lib64/znc/simple_away.so] [ ok ] Loading Module [route_replies]... [/usr/lib64/znc/route_replies.so] [ ok ] Loading Module [replaybuffer]... [/usr/lib64/znc/replaybuffer.so] [ ok ] Adding Server [irc.rizon.net +6697]... [ ok ] Loading Module [admin]... [/usr/lib64/znc/admin.so] [ ok ] Loading Module [bouncedcc]... [/usr/lib64/znc/bouncedcc.so](crocket/freenode) ZNC -> CLI [:*status!znc@znc.in PRIVMSG crocket :Rehashing succeeded!] Connecting user/network [..sogaH�Sn��Lt����/etc/znc/users/crocket/networks/rizon/moddata/simple_away/.registryy5;2c%23;5%0a;mode%20;%25;nick%25;%20;%2b;x%0a;�{���Sn���Sn��{��Sn�����Perform PRIVMSG%20;%5e;%5e;%20;%3a;%ec;%9d;%b8;%ec;%a6;%9d;%20;crocket%20;Sok3%25;2c%23;5%0a;mode%20;%25;nick%25;%20;%2b;x%0a;h�y``�{4����Send replies (e.g. to /who) to the right client only_away/.regi�Pv{��Sn��{x�y@{@{p{p{�`t�s�Lt�{8�z��y�{X��n�(�y��r�{�{@{@{�{�{X��n��`{<����/etc/znc/users/crocket/networks/hanirc/moddata/route_repliesa`{;����/etc/rc.d/rc.znc: line 24: 12316 Segmentation fault sudo -u $ZNC_USER -i /usr/bin/znc --datadir /etc/znc -D -f <!-- github-comment-id:3698323 -->

adam commented 2026-10-05 03:56:20 +02:00

Author

Owner

Copy link

Copy source

@crocket could you please try to reproduce the issues you are having with the latest master branch. This should hopefully fix these issues.

@crocket could you please try to reproduce the issues you are having with the latest master branch. This should hopefully fix these issues. <!-- github-comment-id:3812444 -->

adam commented 2026-10-05 03:56:21 +02:00

Author

Owner

Copy link

Copy source

@kylef // I built the latest master branch.

rehashing doesn't lead to segmentation fault as it did when one or more of networks had IRCConnectEnabled set to yes.

But the original issue still remains.

After rehash fails, even webadmin fails to load or unload modules.

@kylef // I built the latest master branch. rehashing doesn't lead to segmentation fault as it did when one or more of networks had IRCConnectEnabled set to yes. But the original issue still remains. After rehash fails, even webadmin fails to load or unload modules. <!-- github-comment-id:3842688 -->

adam commented 2026-10-05 03:56:21 +02:00

Author

Owner

Copy link

Copy source

Maybe I should close this issue. Using webadmin is probably the solution.

Maybe I should close this issue. Using webadmin is probably the solution. <!-- github-comment-id:12190561 -->

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

1.10.x

1.9.x

1.8.x

1.7.x

1.6.x

znc-1.10.3

znc-1.10.2

znc-1.10.2-rc1

znc-1.10.1

znc-1.10.1-rc1

znc-1.10.0

znc-1.10.0-rc1

znc-1.9.1

znc-1.9.0

znc-1.9.0-rc1

znc-1.8.2

znc-1.8.2-rc1

znc-1.8.1

znc-1.8.1-rc1

znc-1.8.0

znc-1.7.5

znc-1.7.5-rc1

znc-1.7.4

znc-1.7.4-rc1

znc-1.7.3

znc-1.7.3-rc1

znc-1.7.2

znc-1.7.2-rc1

znc-1.7.1

znc-1.7.1-rc1

znc-1.7.0

znc-1.6.6

znc-1.6.6-rc1

znc-1.6.5

znc-1.6.5-rc1

znc-1.6.4

znc-1.6.4-rc3

znc-1.6.4-rc2

znc-1.6.4-rc1

znc-1.6.3

znc-1.6.3-rc2

znc-1.6.3-rc1

znc-1.6.2

znc-1.6.2-rc1

znc-1.6.1

znc-1.6.1-rc1

znc-1.6.0

znc-1.4

znc-1.2

znc-1.0

znc-0.206

znc-0.204

znc-0.202

znc-0.200

znc-0.098

znc-0.096

znc-0.094

znc-0.092

znc-0.090

znc-0.080

znc-0.078

znc-0.076

znc-0.074

znc-0.072

znc-0.070

znc-0.068

znc-0.066

znc-0.064

znc-0.062

znc-0.060

znc-0.058

znc-0.056

znc-0.054

znc-0.054-rc3

znc-0.054-rc2

znc-0.054-rc1

znc-0.023

znc-0.025

znc-0.027

znc-0.028

znc-0.029

znc-0.030

znc-0.033

znc-0.034

znc-0.035

znc-0.036

znc-0.037

znc-0.038

znc-0.039

znc-0.040

znc-0.041

znc-0.043

znc-0.044

znc-0.045

znc-0.047

znc-0.050

znc-0.052

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Wojcieszonek)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/znc#51