adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

savebuff: query buffers are not saved and loaded #443

New Issue
Closed
opened 2026-10-05 04:21:10 +02:00 by adam · 6 comments
adam commented 2026-10-05 04:21:10 +02:00
Owner
Copy link
Copy source

See @xor-freenet's comments in https://github.com/znc/znc/commit/287a020d21ec5f4798d3df845826e8c103a1225d. Despite the blind changes applied in the commit, query buffers are not actually saved and loaded at all.

  • OnIRCConnected() incorrectly assumes that queries would already exist
  • SaveBuffersToDisk() is missing handling of queries altogether
See @xor-freenet's comments in https://github.com/znc/znc/commit/287a020d21ec5f4798d3df845826e8c103a1225d. Despite the blind changes applied in the commit, query buffers are not actually saved and loaded at all. - OnIRCConnected() incorrectly assumes that queries would already exist - SaveBuffersToDisk() is missing handling of queries altogether <!-- github-sync-id:53331794 -->
adam closed this issue 2026-10-05 04:21:10 +02:00
adam commented 2026-10-05 04:21:11 +02:00
Author
Owner
Copy link
Copy source

Two ideas come to my mind. Either save the list of queries separately or change the storage format so that query names can be easily restored out of the encrypted files. With the latter, backwards compatibility must be kept in mind.

Two ideas come to my mind. Either save the list of queries separately or change the storage format so that query names can be easily restored out of the encrypted files. With the latter, backwards compatibility must be kept in mind. <!-- github-comment-id:68628760 -->
adam commented 2026-10-05 04:21:11 +02:00
Author
Owner
Copy link
Copy source

Furthermore, storing the buffer name is not enough because at the time OnIRCConnected() gets called (RPL_WELCOME=1) we don't know yet which names are channels (RPL_ISUPPORT=5) and which are queries.

Furthermore, storing the buffer name is not enough because at the time OnIRCConnected() gets called (RPL_WELCOME=1) we don't know yet which names are channels (RPL_ISUPPORT=5) and which are queries. <!-- github-comment-id:68630344 -->
adam commented 2026-10-05 04:21:12 +02:00
Author
Owner
Copy link
Copy source

@xor-freenet, fix available for testing: https://github.com/znc/znc/pull/803

@xor-freenet, fix available for testing: https://github.com/znc/znc/pull/803 <!-- github-comment-id:68633608 -->
adam commented 2026-10-05 04:21:13 +02:00
Author
Owner
Copy link
Copy source

@jpnurmi I'm very busy with my own projects, so I would like to ask if this will get merged even if I don't provide testing? If you insist I can test it, but I'd rather not like to.

@jpnurmi I'm very busy with my own projects, so I would like to ask if this will get merged even if I don't provide testing? If you insist I can test it, but I'd rather not like to. <!-- github-comment-id:69560160 -->
adam commented 2026-10-05 04:21:13 +02:00
Author
Owner
Copy link
Copy source

And thanks! :)

And thanks! :) <!-- github-comment-id:69560176 -->
adam commented 2026-10-05 04:21:14 +02:00
Author
Owner
Copy link
Copy source

Hi, as a contributor I can't give any promise on behalf of the ZNC team. The best you can do to help is to verify that it works. It's a complex change - being verified by a third party is naturally more convincing than me saying "works for me". :)

Hi, as a contributor I can't give any promise on behalf of the ZNC team. The best you can do to help is to verify that it works. It's a complex change - being verified by a third party is naturally more convincing than me saying "works for me". :) <!-- github-comment-id:69569902 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#443