adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

There is no CONTRIBUTING file #401

New Issue
Closed
opened 2026-10-05 04:18:26 +02:00 by adam · 4 comments
adam commented 2026-10-05 04:18:26 +02:00
Owner
Copy link
Copy source

Link there appears always when you are opening an issue or pull request.

It could say something about Debugging and mentioning ZNC & OS versions etc. and probably something related to coding too.

Link there appears always when you are opening an issue or pull request. - https://github.com/blog/1184-contributing-guidelines It could say something about [Debugging](http://wiki.znc.in/Debugging) and mentioning ZNC & OS versions etc. and probably something related to coding too. <!-- github-sync-id:45736073 -->
adam closed this issue 2026-10-05 04:18:26 +02:00
adam commented 2026-10-05 04:18:27 +02:00
Author
Owner
Copy link
Copy source

Would be nice to know what kind of coding style I should use, line endings, and in general if small pull requests are worth sending in instead of just making a new issue.

Would be nice to know what kind of coding style I should use, line endings, and in general if small pull requests are worth sending in instead of just making a new issue. <!-- github-comment-id:71310562 -->
adam commented 2026-10-05 04:18:28 +02:00
Author
Owner
Copy link
Copy source

The ones that I have noticed are

  • Unix line-endings
  • Tabs, no spaces as tabs
The ones that I have noticed are - Unix line-endings - Tabs, no spaces as tabs <!-- github-comment-id:71310896 -->
adam commented 2026-10-05 04:18:29 +02:00
Author
Owner
Copy link
Copy source

aye, but it'd be easier for pull requests to be more compliant if there is an official venue stating all these things, rather than having to dig all this info by yourself.

aye, but it'd be easier for pull requests to be more compliant if there is an official venue stating all these things, rather than having to dig all this info by yourself. <!-- github-comment-id:71312845 -->
adam commented 2026-10-05 04:18:29 +02:00
Author
Owner
Copy link
Copy source

The rule of thumb is to follow the exact same conventions and style of the
file you change. Applies to any project. :)

On Sat, Jan 24, 2015, 12:41 Jos Ahrens notifications@github.com wrote:

aye, but it'd be easier for pull requests to be more compliant if there is
an official venue stating all these things, rather than having to dig all
this info by yourself.

—
Reply to this email directly or view it on GitHub
https://github.com/znc/znc/issues/708#issuecomment-71312845.

The rule of thumb is to follow the exact same conventions and style of the file you change. Applies to any project. :) On Sat, Jan 24, 2015, 12:41 Jos Ahrens notifications@github.com wrote: > aye, but it'd be easier for pull requests to be more compliant if there is > an official venue stating all these things, rather than having to dig all > this info by yourself. > > — > Reply to this email directly or view it on GitHub > https://github.com/znc/znc/issues/708#issuecomment-71312845. <!-- github-comment-id:71313027 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#401