adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

Fix GetMessageTags and SetMessageTags #395

New Issue
Closed
opened 2026-10-05 04:18:09 +02:00 by adam · 1 comment
adam commented 2026-10-05 04:18:09 +02:00
Owner
Copy link
Copy source

Present implementation assumes a key=value type tag, but a key only type tag is also valid.

The accompanying tests should also be updated.

[Present implementation](https://github.com/znc/znc/blob/396bdb1ebafaf88ec1c72d89b174d3d1c2f23352/src/Utils.cpp#L480-509) assumes a `key=value` type tag, but a `key` only type tag is [also valid](http://ircv3.atheme.org/specification/message-tags-3.2). The [accompanying tests](https://github.com/znc/znc/blob/5237e89bc318355bdae02a3672ee89e31dc0ff9e/test/UtilsTest.cpp) should also be updated. <!-- github-sync-id:44217330 -->
adam closed this issue 2026-10-05 04:18:09 +02:00
adam commented 2026-10-05 04:18:10 +02:00
Author
Owner
Copy link
Copy source

Also the last spec now defines escaping of values

Also the last spec now defines escaping of values <!-- github-comment-id:57092910 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#395