Adding an already existing channel to a user/network via web admin causes a crash if the channel name isn't prefixed with '#' (i.e you already have a channel '#potato' but you try to add 'potato' without the '#' prefix).
This only appears to happen if the channel is already in the list and not if you are adding a new channel that isn't already in the list.
Adding the following lines below "CString sChanName = WebSock.GetParam("name").Trim_n();" in modules/webadmin.cpp fixes this problem (although its probably not the best way of fixing it)
Adding an already existing channel to a user/network via web admin causes a crash if the channel name isn't prefixed with '#' (i.e you already have a channel '#potato' but you try to add 'potato' without the '#' prefix).
This only appears to happen if the channel is already in the list and not if you are adding a new channel that isn't already in the list.
Adding the following lines below "CString sChanName = WebSock.GetParam("name").Trim_n();" in modules/webadmin.cpp fixes this problem (although its probably not the best way of fixing it)
```
if(sChanName.substr(0, 1) != "#")
{
sChanName = "#" + sChanName;
}
```
<!-- github-sync-id:31415773 -->
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Adding an already existing channel to a user/network via web admin causes a crash if the channel name isn't prefixed with '#' (i.e you already have a channel '#potato' but you try to add 'potato' without the '#' prefix).
This only appears to happen if the channel is already in the list and not if you are adding a new channel that isn't already in the list.
Adding the following lines below "CString sChanName = WebSock.GetParam("name").Trim_n();" in modules/webadmin.cpp fixes this problem (although its probably not the best way of fixing it)
A security release could be done?
@seblu yeah
soon?
I will backport the patch in Archlinux as there is still no security release.
Done
This has been assigned CVE-2014-9403.
1.6 will probably be released in near future.
@Mikaela why 1.6 matters? 1.4 is fixed already
@DarthGandalf I thought this was something that is coming with 1.6 because of the new comment.