adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

Module links in webadmin should use _blank #304

New Issue
Closed
opened 2026-10-05 04:11:49 +02:00 by adam · 9 comments
adam commented 2026-10-05 04:11:49 +02:00
Owner
Copy link
Copy source

When clicking on the help link for each module in webadmin, it should open a new window rather than using the current one.

When clicking on the help link for each module in webadmin, it should open a new window rather than using the current one. <!-- github-sync-id:28858491 -->
adam closed this issue 2026-10-05 04:11:49 +02:00
adam commented 2026-10-05 04:11:50 +02:00
Author
Owner
Copy link
Copy source

This would be easy enough to submit a pull request for. The templates are easy to edit.

This would be easy enough to submit a pull request for. The templates are easy to edit. <!-- github-comment-id:36836920 -->
adam commented 2026-10-05 04:11:51 +02:00
Author
Owner
Copy link
Copy source

Sure, just add some arrow to link, to make it obvious that it's opened
in new window (or what icon is used for that...)

06.03.2014 09:09, jdarmst пишет:

This would be easy enough to submit a pull request for. The templates
are easy to edit.

—
Reply to this email directly or view it on GitHub
https://github.com/znc/znc/issues/505#issuecomment-36836920.

Sure, just add some arrow to link, to make it obvious that it's opened in new window (or what icon is used for that...) 06.03.2014 09:09, jdarmst пишет: > This would be easy enough to submit a pull request for. The templates > are easy to edit. > > — > Reply to this email directly or view it on GitHub > https://github.com/znc/znc/issues/505#issuecomment-36836920. <!-- github-comment-id:36975543 -->
adam commented 2026-10-05 04:11:51 +02:00
Author
Owner
Copy link
Copy source

I'm wondering if we can use Wikipdeia icon, does somebody know about theirs license?
I've done small prototyping with Wiki and another free icon and IMO Wikipedia one looks much better.
Wikipedia icon
wiki_ico
Interactivemania icon
another_ico

I'm wondering if we can use Wikipdeia icon, does somebody know about theirs license? I've done small prototyping with Wiki and [another free icon](http://findicons.com/icon/437377/open_in_new_window) and IMO Wikipedia one looks much better. **Wikipedia icon** ![wiki_ico](https://cloud.githubusercontent.com/assets/923963/3179056/8abba922-ec21-11e3-98a6-28905bab8cf2.png) **Interactivemania icon** ![another_ico](https://cloud.githubusercontent.com/assets/923963/3179055/8ab9e15a-ec21-11e3-8304-07016290b072.png) <!-- github-comment-id:45142689 -->
adam commented 2026-10-05 04:11:52 +02:00
Author
Owner
Copy link
Copy source

The MediaWiki external link icon is available under the terms of the GPLv2 or later, per the PNG and vector versions. Someone more familiar with license compatibility will need to make the call on whether ZNC can use it, though.

The MediaWiki external link icon is available under the terms of the GPLv2 or later, per the [PNG](https://commons.wikimedia.org/wiki/File:Icon_External_Link.png) and [vector](https://commons.wikimedia.org/wiki/File:Icon_External_Link.svg) versions. Someone more familiar with license compatibility will need to make the call on whether ZNC can use it, though. <!-- github-comment-id:45143665 -->
adam commented 2026-10-05 04:11:53 +02:00
Author
Owner
Copy link
Copy source

https://commons.wikimedia.org/wiki/File:External.svg is under Public Domain
But it probably should depend on the selected skin

https://commons.wikimedia.org/wiki/File:External.svg is under Public Domain But it probably should depend on the selected skin <!-- github-comment-id:45186170 -->
adam commented 2026-10-05 04:11:53 +02:00
Author
Owner
Copy link
Copy source

@devfom by the way, that picture means “link to outside of this wiki”, not “open in new window”

@devfom by the way, that picture means “link to outside of this wiki”, not “open in new window” <!-- github-comment-id:45422578 -->
adam commented 2026-10-05 04:11:54 +02:00
Author
Owner
Copy link
Copy source

@DarthGandalf but I guess we could use it too, because actually when user clickes that link it goes outside of this admin interface..?

@DarthGandalf but I guess we could use it too, because actually when user clickes that link it goes outside of this admin interface..? <!-- github-comment-id:45528332 -->
adam commented 2026-10-05 04:11:55 +02:00
Author
Owner
Copy link
Copy source

Sure, just please make it possible for skin to define different icon, or even not to have any icon at all. Via CSS which adds text in the end of <a> element maybe.

Sure, just please make it possible for skin to define different icon, or even not to have any icon at all. Via CSS which adds text in the end of `<a>` element maybe. <!-- github-comment-id:45530137 -->
adam commented 2026-10-05 04:11:55 +02:00
Author
Owner
Copy link
Copy source

Fixed in #568

Fixed in #568 <!-- github-comment-id:49665132 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#304