watch module does not correctly "ignore" QUIT events from other channels which match the given patterns #280

Open
opened 2026-10-05 04:09:46 +02:00 by adam · 0 comments
Owner

As the topic of this issue states, the watch module does not correctly ignore QUIT events which are outside the parameters of where it's supposed to be watching.

As an example, here are items which are in my watch list.

[2013/12/20 17:27:16] <*watch> | Id | HostMask      | Target            | Pattern | Sources   | Off |
[2013/12/20 17:27:16] <*watch> +----+---------------+-------------------+---------+-----------+-----+
[2013/12/20 17:27:16] <*watch> | 11 | *!*@*stamit*  | *stamit           | *       | #bitcoin* |     |
[2013/12/20 17:27:16] <*watch> | 17 | *!*stamit*@*  | *stamit           | *       | #bitcoin* |     |
[2013/12/20 17:27:16] <*watch> | 20 | *stamit*!*@*  | *stamit           | *       | #bitcoin* |     |

This is on freenode, so this should only trigger events when the individual is in the #bitcoin* channels.

This is output *watch gives me, sourced from #freenode which is outside the watch area:

[2013/12/20 17:26:39] <*stamit> * Quits: stamit (~stamit@pdpc/supporter/active/stamit) (Quit: Leaving.)

[2013/12/20 17:54:50] <*stamit> * Quits: stamit (~stamit@pdpc/supporter/active/stamit) (Ping timeout: 246 seconds)

This activity was in #freenode and not #bitcoin*.

This suggests that the watch module does not handle QUIT messages correctly when it sees them.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1362483-watch-module-does-not-correctly-ignore-quit-events-from-other-channels-which-match-the-given-patterns?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github).
As the topic of this issue states, the watch module does not correctly ignore QUIT events which are outside the parameters of where it's supposed to be watching. As an example, here are items which are in my watch list. ``` [2013/12/20 17:27:16] <*watch> | Id | HostMask | Target | Pattern | Sources | Off | [2013/12/20 17:27:16] <*watch> +----+---------------+-------------------+---------+-----------+-----+ [2013/12/20 17:27:16] <*watch> | 11 | *!*@*stamit* | *stamit | * | #bitcoin* | | [2013/12/20 17:27:16] <*watch> | 17 | *!*stamit*@* | *stamit | * | #bitcoin* | | [2013/12/20 17:27:16] <*watch> | 20 | *stamit*!*@* | *stamit | * | #bitcoin* | | ``` This is on freenode, so this should only trigger events when the individual is in the #bitcoin\* channels. This is output *watch gives me, sourced from #freenode which is outside the watch area: ``` [2013/12/20 17:26:39] <*stamit> * Quits: stamit (~stamit@pdpc/supporter/active/stamit) (Quit: Leaving.) [2013/12/20 17:54:50] <*stamit> * Quits: stamit (~stamit@pdpc/supporter/active/stamit) (Ping timeout: 246 seconds) ``` This activity was in #freenode and not #bitcoin*. This suggests that the watch module does not handle QUIT messages correctly when it sees them. ## <bountysource-plugin> --- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1362483-watch-module-does-not-correctly-ignore-quit-events-from-other-channels-which-match-the-given-patterns?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github). </bountysource-plugin> <!-- github-sync-id:24656070 -->
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#280