adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-11-01 10:05:48 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

m_RawBuffer on IRCNetwork can overflow #249

New Issue
Closed
opened 2026-10-05 04:07:38 +02:00 by adam · 1 comment
adam commented 2026-10-05 04:07:38 +02:00
Owner
Copy link
Copy source

I ran into an issue today where one of my coworker's clients managed to overflow the m_RawBuffer on IRCNetwork

His Textual client was configured to send an OPER command on connect, and so it did this every time he detached and reattached to the ZNC instance. This in turn sent back a RPL_YOUREOPER message each time, all of which were added to m_RawBuffer until it overflowed.

In this particular case, the RPL_WELCOME message overflowed, and Textual doesn't consider you to be connected until it gets it, so it would eventually time out the connection.

It seems like the best fix would be to only store one RPL_YOUREOPER message, but I'm not entirely sure what the right mechanism is to make that happen. (I'm happy to try and throw code together given some high-level direction)

I ran into an issue today where one of my coworker's clients managed to overflow the `m_RawBuffer` on `IRCNetwork` His Textual client was configured to send an `OPER` command on connect, and so it did this every time he detached and reattached to the ZNC instance. This in turn sent back a `RPL_YOUREOPER` message each time, all of which were added to `m_RawBuffer` until it overflowed. In this particular case, the `RPL_WELCOME` message overflowed, and Textual doesn't consider you to be connected until it gets it, so it would eventually time out the connection. It seems like the best fix would be to only store one `RPL_YOUREOPER` message, but I'm not entirely sure what the right mechanism is to make that happen. (I'm happy to try and throw code together given some high-level direction) <!-- github-sync-id:16502681 -->
adam closed this issue 2026-10-05 04:07:38 +02:00
adam commented 2026-10-05 04:07:39 +02:00
Author
Owner
Copy link
Copy source

999cc085d2 already removed this from the buffer. It's unreliable and clients should use the o mode. See full commit message for details.

999cc085d2906879bbe634ef3af472cde2d5a0d0 already removed this from the buffer. It's unreliable and clients should use the `o` mode. See full commit message for details. <!-- github-comment-id:20663256 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#249