Slow down repeated reconnects [$20] #24
Assignees
adam (Adam Wojcieszonek)
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: adam/znc#24
Reference in new issue
Block a user
Let's imagine the unimaginable. My ZNC gets banned from the IRC (e.g. via a kline). It will now repeatedly reconnect and cause opers to be annoyed by server notices.
Alternatively: Some stupid client is being stupid and ZNC floods off 15 seconds after connecting to the IRC server. Again and again.
It would be nice if we slowed down reconnecting in this case and perhaps preferred other users for now.
--- There is a **[$20 open bounty](https://www.bountysource.com/issues/700-slow-down-repeated-reconnects?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github).How about disabling automatically reconnect in case of a network ban? Nicer would obviously for the user to configure the behavior in such cases. But then again we should consider what kind of behaviors do we want in case of such events? Also maybe it would be smart to make a module for something like this? So the user can already configure the behavior, kinda.
Based on what @schoentoon says, perhaps we can set IRCEnableConnect to false if we see "G-Lined" in the ERROR message. Such as follows:
I think it'd be smart to do that on *-Lined: then, so pretty much on any kind of network ban.
That would make everybody who uses "G-Lined: Foo" as his quit message quite sad (yes, this was seen in the wild, someone wante to feel cool, I guess). In this case e.g. /znc jump wouldnt actually reconnect.
I know what you mean. How about only checking for it when you get disconnected by an "ERROR Closing link"? Or just entirely disabling this when something with G-Lined is set as their quit message.
I'm pretty sure most ircds disconnect you with an ERROR Closing link when you /quit
also, unrealircd has "User banned from blah" and "User permanently banned from blah" as error lines when you're g-lined...
This would be very helpful, for example now that ChatSpike somehow turned SSL off for all ports and ZNC tried connecting to it a lot and then also getting Z-lined.
also 👎 for detecting network bans and aborting connections entirely. There are many accidentally too wide network bans at freenode that are often lifted soon and just slowing down repeated reconnects would help with Z-lines about connecting too fast.
https://github.com/znc/znc/issues/764 is another issue which this would fix, if the server suddenly changes SSL certificates, ZNC just floods the server and disconnects forever while it could slow down the attempts until user came and verified the certificates.
I recently ran out of disk space on a server. While investigating I found an 88 GB ZNC log file, 80 GB of which were filled with IRC reconnection attempts from one 24-hour period.UPDATE: I'm not a smart person and cannot tell an IRC bouncer from an IRC bot. Please ignore.
@mgedmin the log which you shown on IRC, is from Supybot, not ZNC...
During night one network changed it's certificate and when I woke up I had 326 700 lines of flood from ZNC asking me if I trust the certificate or not.
I believe *this musn't happen.' Can we get this as blocker for 1.7.0 before ZNCs start getting banned widely due to this issue and getting whtaever-lined?
Edit: I said 50 000 lines, WeeChat Android said 326 700 lines.
How is this still not fixed 9 years later? When an IRC server is down ZNC tries to reconnect every 90 seconds and spams my Pushover notifications.
How you still didn't send the patch to fix it during these 9 years?
ср, 25 нояб. 2020 г. в 11:40, Richard notifications@github.com: