adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

OnEmbeddedWebRequest(...) Not executing #194

New Issue
Closed
opened 2026-10-05 04:03:37 +02:00 by adam · 5 comments
adam commented 2026-10-05 04:03:37 +02:00
Owner
Copy link
Copy source

Modules like Stickychan doesn't show up in the channel settings.
I did some tests and figured that OnEmbeddedWebRequest doesn't run when opening channel settings page.

Modules like Stickychan doesn't show up in the channel settings. I did some tests and figured that OnEmbeddedWebRequest doesn't run when opening channel settings page. <!-- github-sync-id:10184917 -->
adam closed this issue 2026-10-05 04:03:37 +02:00
adam commented 2026-10-05 04:03:38 +02:00
Author
Owner
Copy link
Copy source

Just ran another test. OnEmbeddedWebRequest works fine in other modules.
The problem is in Stickychan modules.

Just ran another test. OnEmbeddedWebRequest works fine in other modules. The problem is in Stickychan modules. <!-- github-comment-id:12536716 -->
adam commented 2026-10-05 04:03:39 +02:00
Author
Owner
Copy link
Copy source

Uhm, right... It's called only for user and global modules, but not for network modules...
That part of webadmin was forgotten to update with introduction of networks.

Uhm, right... It's called only for user and global modules, but not for network modules... That part of webadmin was forgotten to update with introduction of networks. <!-- github-comment-id:12536817 -->
adam commented 2026-10-05 04:03:40 +02:00
Author
Owner
Copy link
Copy source

The following if command should turn true when opening the channel settings page, but its not!
if ((*i)->OnEmbeddedWebRequest(WebSock, "webadmin/channel", mod))

The following if command should turn true when opening the channel settings page, but its not! if ((*i)->OnEmbeddedWebRequest(WebSock, "webadmin/channel", mod)) <!-- github-comment-id:12557937 -->
adam commented 2026-10-05 04:03:40 +02:00
Author
Owner
Copy link
Copy source

Fixed in 46b28559fc

Fixed in 46b28559fc91a79d0c82600fb87c423b2e945f84 <!-- github-comment-id:18118659 -->
adam commented 2026-10-05 04:03:41 +02:00
Author
Owner
Copy link
Copy source

Awesome work @DarthGandalf

Awesome work @DarthGandalf <!-- github-comment-id:18194779 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#194