clientnotify.cpp: shouldnt notify for same ip & identifier but different network #1016

New Issue

2026-10-05T04:58:40+02:00

adam commented

2026-10-05 04:58:40 +02:00

I just installed ZNC and configured two networks, each time I connected to their fake hosts as chris@identifier/servername as per documentation.

Now each time I am opening my IRC client I seem to get a notification that another client authenticated:

00:15 *status ╡ Another client authenticated as your user. Use the 'ListClients' command to see all 2 clients.
00:25    name ╡ ListClients
00:25 *status ╡ +-------------+-----------+------------+
00:25       ⤷ ╡ | Host        | Network   | Identifier |
00:25       ⤷ ╡ +-------------+-----------+------------+
00:25       ⤷ ╡ | 141.70.80.5 | libera    | pioneer    |
00:25       ⤷ ╡ | 141.70.80.5 | robustirc | pioneer    |
00:25       ⤷ ╡ +-------------+-----------+------------+

This seems a bit overly noisy to me, and I would propose to filter if two clients use the same Identifier there should not be another notification about them rejoining.

This issue is somewhat related to https://github.com/znc/znc/issues/755 but not a duplicate as I am also using the same Identifier for both clients.

The code in question is the following I guess, I am happy to code together a fix for this if I get positive feedback about the idea:

https://github.com/znc/znc/blob/e0ffdddd473e97cb843f2bc8ad4fa16cf47c65b4/modules/clientnotify.cpp#L77-L91

ZNC Version:
Docker image: https://hub.docker.com/_/znc/
Tag: latest

00:32       ⤷ ╡ ZNC 1.8.2 - https://znc.in
00:32       ⤷ ╡ IPv6: yes, SSL: yes, DNS: threads, charset: yes, i18n: yes, build: cmake

I just installed ZNC and configured two networks, each time I connected to their fake hosts as [`chris@identifier/servername`](https://github.com/christian-heusel/dotfiles/blob/d14d72138b4c2cb1bf5004456eba796fbe4a6d02/roles/irc-configuration/templates/irc.conf#L197) as per documentation. Now each time I am opening my IRC client I seem to get a notification that another client authenticated: ``` 00:15 *status ╡ Another client authenticated as your user. Use the 'ListClients' command to see all 2 clients. 00:25 name ╡ ListClients 00:25 *status ╡ +-------------+-----------+------------+ 00:25 ⤷ ╡ | Host | Network | Identifier | 00:25 ⤷ ╡ +-------------+-----------+------------+ 00:25 ⤷ ╡ | 141.70.80.5 | libera | pioneer | 00:25 ⤷ ╡ | 141.70.80.5 | robustirc | pioneer | 00:25 ⤷ ╡ +-------------+-----------+------------+ ``` This seems a bit overly noisy to me, and I would propose to filter if two clients use the same Identifier there should not be another notification about them rejoining. This issue is somewhat related to https://github.com/znc/znc/issues/755 but not a duplicate as I am also using the same Identifier for both clients. The code in question is the following I guess, I am happy to code together a fix for this if I get positive feedback about the idea: https://github.com/znc/znc/blob/e0ffdddd473e97cb843f2bc8ad4fa16cf47c65b4/modules/clientnotify.cpp#L77-L91 **ZNC Version:** Docker image: https://hub.docker.com/_/znc/ Tag: latest ``` 00:32 ⤷ ╡ ZNC 1.8.2 - https://znc.in 00:32 ⤷ ╡ IPv6: yes, SSL: yes, DNS: threads, charset: yes, i18n: yes, build: cmake ```

adam closed this issue

2026-10-05 04:58:40 +02:00

adam commented

2026-10-05 04:58:41 +02:00

Clientnotify options:

NewOnly <on|off>: Turns notifications for unseen IP addresses on or off

This is a half-fix for the problem as Identifiers are not covered, but with this #755 can be closed!

Clientnotify options: ``` NewOnly <on|off>: Turns notifications for unseen IP addresses on or off ``` This is a half-fix for the problem as Identifiers are not covered, but with this #755 can be closed!

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/znc#1016

clientnotify.cpp: shouldnt notify for same ip & identifier but different network #1016

`clientnotify.cpp`: shouldnt notify for same ip & identifier but different network #1016