Certauth doesn't work with Imapauth #1012

Open
opened 2026-10-05 04:58:27 +02:00 by adam · 8 comments
Owner

The problem

When you are a user on a Imapauth configured server, you can't use Certauth, even if the module is loaded, it appears like Imapauth doesn't support Certauth, but I don't know.
CCing @deepend-tildeclub as he's the owner of the server :D

# The problem When you are a user on a Imapauth configured server, you can't use Certauth, even if the module is loaded, it appears like Imapauth doesn't support Certauth, but I don't know. CCing @deepend-tildeclub as he's the owner of the server :D <!-- github-sync-id:1264827103 -->
Author
Owner

The cause

These authentication modules all hook into a module call OnLoginAttempt(). certauth either directly accepts the login or says "let someone else handle this". imapauth cannot do that since it first has to talk to the IMAP server, so it always does "I will handle this (later) - don't ask anyone else."

I think this should work if certauth is loaded before imapauth, but not the other way around. However, AFAIK messing with the module order in znc does not really work well and might get lost across a restart. Also, telling people "you first have to load module X and only afterwards load Y" is not really a solution. I just wanted to mention what is going on.

# The cause These authentication modules all hook into a module call `OnLoginAttempt()`. `certauth` either directly accepts the login or says "let someone else handle this". `imapauth` cannot do that since it first has to talk to the IMAP server, so it always does "I will handle this (later) - don't ask anyone else." I think this should work if certauth is loaded before imapauth, but not the other way around. However, AFAIK messing with the module order in znc does not really work well and might get lost across a restart. Also, telling people "you first have to load module X and only afterwards load Y" is not really a solution. I just wanted to mention what is going on. <!-- github-comment-id:1150083240 -->
Author
Owner

I think this should work if certauth is loaded before imapauth, but not the other way around. However, AFAIK messing with the module order in znc does not really work well and might get lost across a restart. Also, telling people "you first have to load module X and only afterwards load Y" is not really a solution. I just wanted to mention what is going on.

Then we wait, wrong?

> I think this should work if certauth is loaded before imapauth, but not the other way around. However, AFAIK messing with the module order in znc does not really work well and might get lost across a restart. Also, telling people "you first have to load module X and only afterwards load Y" is not really a solution. I just wanted to mention what is going on. Then we wait, wrong? <!-- github-comment-id:1150119245 -->
Author
Owner

Restart should not affect module order...
I don't think the order is ever changed unless you specifically do
something with loading/unloading modules. No guarantees though. And the
order is not exposed very well in the UI, if at all

Messing with the order is not a good solution, but a fine workaround until
we figure something better

ср, 8 июн. 2022 г., 17:39 Uli Schlachter @.***>:

The cause

These authentication modules all hook into a module call OnLoginAttempt().
certauth either directly accepts the login or says "let someone else
handle this". imapauth cannot do that since it first has to talk to the
IMAP server, so it always does "I will handle this (later) - don't ask
anyone else."

I think this should work if certauth is loaded before imapauth, but not
the other way around. However, AFAIK messing with the module order in znc
does not really work well and might get lost across a restart. Also,
telling people "you first have to load module X and only afterwards load Y"
is not really a solution. I just wanted to mention what is going on.

—
Reply to this email directly, view it on GitHub
https://github.com/znc/znc/issues/1831#issuecomment-1150083240, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACPLZCAQ4S4TPETF5FAWC3VOC5D5ANCNFSM5YGWQKOQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Restart should not affect module order... I don't think the order is ever changed unless you specifically do something with loading/unloading modules. No guarantees though. And the order is not exposed very well in the UI, if at all Messing with the order is not a good solution, but a fine workaround until we figure something better ср, 8 июн. 2022 г., 17:39 Uli Schlachter ***@***.***>: > The cause > > These authentication modules all hook into a module call OnLoginAttempt(). > certauth either directly accepts the login or says "let someone else > handle this". imapauth cannot do that since it first has to talk to the > IMAP server, so it always does "I will handle this (later) - don't ask > anyone else." > > I think this should work if certauth is loaded before imapauth, but not > the other way around. However, AFAIK messing with the module order in znc > does not really work well and might get lost across a restart. Also, > telling people "you first have to load module X and only afterwards load Y" > is not really a solution. I just wanted to mention what is going on. > > — > Reply to this email directly, view it on GitHub > <https://github.com/znc/znc/issues/1831#issuecomment-1150083240>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AACPLZCAQ4S4TPETF5FAWC3VOC5D5ANCNFSM5YGWQKOQ> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > <!-- github-comment-id:1150120618 -->
Author
Owner

Sorry, what is this sentence supposed to mean?

ср, 8 июн. 2022 г., 18:12 Julian Marcos @.***>:

I think this should work if certauth is loaded before imapauth, but not
the other way around. However, AFAIK messing with the module order in znc
does not really work well and might get lost across a restart. Also,
telling people "you first have to load module X and only afterwards load Y"
is not really a solution. I just wanted to mention what is going on.

Then we wait, wrong?

—
Reply to this email directly, view it on GitHub
https://github.com/znc/znc/issues/1831#issuecomment-1150119245, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACPLZGMAVK6T4ORFBPGHI3VODA5JANCNFSM5YGWQKOQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Sorry, what is this sentence supposed to mean? ср, 8 июн. 2022 г., 18:12 Julian Marcos ***@***.***>: > I think this should work if certauth is loaded before imapauth, but not > the other way around. However, AFAIK messing with the module order in znc > does not really work well and might get lost across a restart. Also, > telling people "you first have to load module X and only afterwards load Y" > is not really a solution. I just wanted to mention what is going on. > > Then we wait, wrong? > > — > Reply to this email directly, view it on GitHub > <https://github.com/znc/znc/issues/1831#issuecomment-1150119245>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AACPLZGMAVK6T4ORFBPGHI3VODA5JANCNFSM5YGWQKOQ> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > <!-- github-comment-id:1150123347 -->
Author
Owner

Sorry, what is this sentence supposed to mean? ср, 8 июн. 2022 г., 18:12 Julian Marcos @.***>:

I think this should work if certauth is loaded before imapauth, but not the other way around. However, AFAIK messing with the module order in znc does not really work well and might get lost across a restart. Also, telling people "you first have to load module X and only afterwards load Y" is not really a solution. I just wanted to mention what is going on.

Then we wait, wrong?

That we should wait, and that you should tell me if I were/am wrong.

> Sorry, what is this sentence supposed to mean? ср, 8 июн. 2022 г., 18:12 Julian Marcos ***@***.***>: > > > I think this should work if certauth is loaded before imapauth, but not the other way around. However, AFAIK messing with the module order in znc does not really work well and might get lost across a restart. Also, telling people "you first have to load module X and only afterwards load Y" is not really a solution. I just wanted to mention what is going on. > > Then we wait, wrong? That we should wait, and that you should tell me if I were/am wrong. <!-- github-comment-id:1150125281 -->
Author
Owner

You can try the workaround psychon mentioned.
But feel free to wait, if that is your wish...

ср, 8 июн. 2022 г., 18:17 Julian Marcos @.***>:

Sorry, what is this sentence supposed to mean? ср, 8 июн. 2022 г., 18:12
Julian Marcos @.***>:

I think this should work if certauth is loaded before imapauth, but not
the other way around. However, AFAIK messing with the module order in znc
does not really work well and might get lost across a restart. Also,
telling people "you first have to load module X and only afterwards load Y"
is not really a solution. I just wanted to mention what is going on.
Then we wait, wrong?

That we should wait, and that you should tell me if I were/am wrong.

—
Reply to this email directly, view it on GitHub
https://github.com/znc/znc/issues/1831#issuecomment-1150125281, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACPLZBKDN5EWBTR7GPKC3DVODBSJANCNFSM5YGWQKOQ
.
You are receiving this because you commented.Message ID:
@.***>

You can try the workaround psychon mentioned. But feel free to wait, if that is your wish... ср, 8 июн. 2022 г., 18:17 Julian Marcos ***@***.***>: > Sorry, what is this sentence supposed to mean? ср, 8 июн. 2022 г., 18:12 > Julian Marcos *@*.***>: > > I think this should work if certauth is loaded before imapauth, but not > the other way around. However, AFAIK messing with the module order in znc > does not really work well and might get lost across a restart. Also, > telling people "you first have to load module X and only afterwards load Y" > is not really a solution. I just wanted to mention what is going on. > Then we wait, wrong? > > That we should wait, and that you should tell me if I were/am wrong. > > — > Reply to this email directly, view it on GitHub > <https://github.com/znc/znc/issues/1831#issuecomment-1150125281>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AACPLZBKDN5EWBTR7GPKC3DVODBSJANCNFSM5YGWQKOQ> > . > You are receiving this because you commented.Message ID: > ***@***.***> > <!-- github-comment-id:1150127513 -->
Author
Owner

You can try the workaround psychon mentioned. But feel free to wait, if that is your wish... ср, 8 июн. 2022 г., 18:17 Julian Marcos @.>:
…
Sorry, what is this sentence supposed to mean? ср, 8 июн. 2022 г., 18:12 Julian Marcos @.
>: I think this should work if certauth is loaded before imapauth, but not the other way around. However, AFAIK messing with the module order in znc does not really work well and might get lost across a restart. Also, telling people "you first have to load module X and only afterwards load Y" is not really a solution. I just wanted to mention what is going on. Then we wait, wrong? That we should wait, and that you should tell me if I were/am wrong. — Reply to this email directly, view it on GitHub <#1831 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPLZBKDN5EWBTR7GPKC3DVODBSJANCNFSM5YGWQKOQ . You are receiving this because you commented.Message ID: @.***>

Ok, I'll tell the admin about it 👍

> You can try the workaround psychon mentioned. But feel free to wait, if that is your wish... ср, 8 июн. 2022 г., 18:17 Julian Marcos ***@***.***>: > […](#) > Sorry, what is this sentence supposed to mean? ср, 8 июн. 2022 г., 18:12 Julian Marcos *@*.***>: I think this should work if certauth is loaded before imapauth, but not the other way around. However, AFAIK messing with the module order in znc does not really work well and might get lost across a restart. Also, telling people "you first have to load module X and only afterwards load Y" is not really a solution. I just wanted to mention what is going on. Then we wait, wrong? That we should wait, and that you should tell me if I were/am wrong. — Reply to this email directly, view it on GitHub <[#1831 (comment)](https://github.com/znc/znc/issues/1831#issuecomment-1150125281)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACPLZBKDN5EWBTR7GPKC3DVODBSJANCNFSM5YGWQKOQ> . You are receiving this because you commented.Message ID: ***@***.***> Ok, I'll tell the admin about it 👍 <!-- github-comment-id:1150128138 -->
Author
Owner

The admin said me that he loaded CertAuth first, and it worked!!!!

The admin said me that he loaded CertAuth first, and it worked!!!! <!-- github-comment-id:1152854340 -->
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#1012