From eb229659e53764a7d288c4561523f3907b9cf8d8 Mon Sep 17 00:00:00 2001 From: Uli Schlachter Date: Fri, 13 May 2011 15:48:47 +0200 Subject: [PATCH] Warn if a *module message is ignored Some modules (e.g. webadmin) don't handle messages to *module in any way. Make it clear to the user why they didn't get any reply back in this case. Signed-off-by: Uli Schlachter --- Modules.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Modules.cpp b/Modules.cpp index 2b29cea1..bf8a482b 100644 --- a/Modules.cpp +++ b/Modules.cpp @@ -493,7 +493,12 @@ void CModule::OnModCommand(const CString& sCommand) { HandleCommand(sCommand); } void CModule::OnUnknownModCommand(const CString& sLine) { - if (!m_mCommands.empty()) + if (m_mCommands.empty()) + // This function is only called if OnModCommand wasn't + // overriden, so no false warnings for modules which don't use + // CModCommand for command handling. + PutModule("This module doesn't implement any commands."); + else PutModule("Unknown command!"); }