adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

bouncedcc: connect to the bounce port via localhost in the test

Browse Source 
The bounce listener binds to the IRC socket's local address. With the
inttest unix sockets that is "localhost" on Linux, which Csocket
resolves to ::1, so connecting to 127.0.0.1 never reached it.
This commit is contained in:
Alhuda Khan committed 2026-10-24 11:57:02 +05:30
1 parent d5375e58f8
commit a9ec2fb9a4
1 file changed
+5 -3
Download Patch File Download Diff File Expand all files Collapse all files
test/integration/tests/modules.cpp
+5 -3
View File
@@ -768,12 +768,14 @@ TEST_F(ZNCTest, BounceDCCModule) {
// Only the user's own clients may connect to that bounce port. The test
// client is on a unix socket, so a TCP connection from anywhere is refused.
// The listener binds to the IRC socket's local address, which for a unix
// socket is "localhost" on Linux and may resolve to ::1 only.
QByteArray bouncePort = line2.mid(line2.lastIndexOf(' ') + 1);
bouncePort.chop(1); // trailing \001
QTcpSocket outsider;
outsider.connectToHost("127.0.0.1", bouncePort.toUShort());
outsider.waitForConnected();
client.ReadUntil("Refused connection from 127.0.0.1");
outsider.connectToHost("localhost", bouncePort.toUShort());
ASSERT_TRUE(outsider.waitForConnected());
client.ReadUntil("Refused connection from");
// Peer must not be able to make ZNC connect to its own loopback
ircd.Write(":friend!user@host PRIVMSG nick :\001DCC CHAT chat 2130706433 6379\001");