adam/znc
1
0
Fork 0
mirror of https://github.com/znc/znc.git synced 2026-08-10 19:02:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2014 from MarkLee131/fix/parseservertime-clamp-range

Browse Source 
Utils: reject out-of-range years in ParseServerTime
This commit is contained in:
Alexey Sokolov
2026-04-27 01:43:24 +01:00
committed by GitHub
parent 7456cbaf02 7c47afa888
commit 866303eef0
2 changed files with 38 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/UtilsTest.cpp
+25
View File
@@ -161,6 +161,31 @@ TEST(UtilsTest, ParseServerTime) {
tzset();
}
TEST(UtilsTest, ParseServerTimeOutOfRange) {
// Years past 5 digits trigger int64 overflow inside cctz' microseconds
// conversion (`seconds * 1_000_000`). Reject up front (#2008).
timeval tv = CUtils::ParseServerTime("999999-01-01T00:00:00.000Z");
EXPECT_EQ(tv.tv_sec, 0);
EXPECT_EQ(tv.tv_usec, 0);
tv = CUtils::ParseServerTime("12345678-01-01T00:00:00.000Z");
EXPECT_EQ(tv.tv_sec, 0);
EXPECT_EQ(tv.tv_usec, 0);
// Junk and empty input still return a zeroed timeval.
tv = CUtils::ParseServerTime("");
EXPECT_EQ(tv.tv_sec, 0);
EXPECT_EQ(tv.tv_usec, 0);
tv = CUtils::ParseServerTime("not-a-date-at-all");
EXPECT_EQ(tv.tv_sec, 0);
EXPECT_EQ(tv.tv_usec, 0);
// Canonical input still parses (regression).
tv = CUtils::ParseServerTime("2011-10-19T16:40:51.620Z");
EXPECT_EQ(CUtils::FormatServerTime(tv), "2011-10-19T16:40:51.620Z");
}
class TimeTest : public testing::TestWithParam<
std::tuple<timeval, CString, CString, CString>> {};