From 860ccb7dec795a47727ae628f99914ce2885a960 Mon Sep 17 00:00:00 2001
From: psychon <psychon@726aef4b-f618-498e-8847-2d620e286838>
Date: Fri, 20 Mar 2009 10:00:31 +0000
Subject: [PATCH] Remove/fix some dead code

All of this was found via warnings ("remarks") from icc.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1435 726aef4b-f618-498e-8847-2d620e286838
---
 FileUtils.cpp | 2 +-
 IRCSock.cpp   | 6 ++----
 Utils.cpp     | 4 ----
 3 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/FileUtils.cpp b/FileUtils.cpp
index d497a20b..4da8392b 100644
--- a/FileUtils.cpp
+++ b/FileUtils.cpp
@@ -100,7 +100,7 @@ bool CFile::FType(const CString sFileName, EFileTypes eType, bool bUseLstat) {
 		case FT_SOCK:
 			return S_ISSOCK(st.st_mode);
 		default:
-			return false;
+			break;
 	}
 	return false;
 }
diff --git a/IRCSock.cpp b/IRCSock.cpp
index b2f0583c..064c79a6 100644
--- a/IRCSock.cpp
+++ b/IRCSock.cpp
@@ -182,7 +182,6 @@ void CIRCSock::ReadLine(const CString& sData) {
 				case 432: // :irc.server.com 432 * nick :Erroneous Nickname: Illegal characters
 				case 433: {
 					CString sBadNick = sRest.Token(0);
-					CString sConfNick = m_pUser->GetNick().Left(GetMaxNickLen());
 
 					if (!m_bAuthed) {
 						SendAltNick(sBadNick);
@@ -681,11 +680,10 @@ bool CIRCSock::OnPrivCTCP(CNick& Nick, CString& sMessage) {
 		}
 
 		return true;
-	} else {
-		return OnGeneralCTCP(Nick, sMessage);
 	}
 
-	return false;
+	// This handles everything which wasn't handled yet
+	return OnGeneralCTCP(Nick, sMessage);
 }
 
 bool CIRCSock::OnGeneralCTCP(CNick& Nick, CString& sMessage) {
diff --git a/Utils.cpp b/Utils.cpp
index 994b0096..f75a8a6d 100644
--- a/Utils.cpp
+++ b/Utils.cpp
@@ -155,8 +155,6 @@ CString CUtils::GetHashPass() {
 			return pass1.MD5();
 		}
 	}
-
-	return "";
 }
 
 CString CUtils::GetSaltedHashPass(CString& sSalt) {
@@ -175,8 +173,6 @@ CString CUtils::GetSaltedHashPass(CString& sSalt) {
 			return SaltedHash(pass1, sSalt);
 		}
 	}
-
-	return "";
 }
 
 CString CUtils::GetSalt() {