adam/znc
1
0
Fork 0
mirror of https://github.com/znc/znc.git synced 2026-08-07 01:13:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup previous PR, add integration test for multiple joins

Browse Source
This commit is contained in:
Alexey Sokolov
2026-07-22 09:24:52 +01:00
parent 583c52866c
commit 7d4879ab26
2 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/integration/tests/core.cpp
+18 -6
View File
@@ -1316,6 +1316,22 @@ TEST_F(ZNCTest, JoinDetachedChannelMultiClient) {
client2.ReadUntil(":other!user@host QUIT :quit message");
}
// Goguma does this
TEST_F(ZNCTest, ClientRejoiningJoinedChannel) {
auto znc = Run();
auto ircd = ConnectIRCd();
auto client = LoginClient();
ircd.Write(":server 001 nick :Hello");
client.Write("JOIN #test");
ircd.ReadUntil(":nick JOIN #test");
client.Write("JOIN #test");
client.Write("JOIN #test");
client.Write("JOIN #test");
ASSERT_THAT(ircd.ReadRemainder().toStdString(), Not(HasSubstr("JOIN")));
}
// Commit ad7bd6d7eed84648638e1b6fd69546b9fe496576
// prevented rejoining when a client cycles a channel.
TEST_F(ZNCTest, ClientCycleChannel) {
@@ -1337,9 +1353,7 @@ TEST_F(ZNCTest, ClientCycleChannel) {
client.Write(":nick PART #test");
// Verify PART is forwarded to server
QByteArray partMsg;
ircd.ReadUntilAndGet("PART", partMsg);
EXPECT_THAT(partMsg.toStdString(), HasSubstr("PART #test"));
ircd.ReadUntil("PART #test");
ircd.Write(":nick PART #test");
client.ReadUntil(":nick PART #test");
@@ -1405,9 +1419,7 @@ TEST_F(ZNCTest, PartWithError442) {
client.ReadUntil(":nick JOIN :#test");
client.Write("PART #test :leaving");
QByteArray partMsg;
ircd.ReadUntilAndGet("PART", partMsg);
EXPECT_THAT(partMsg.toStdString(), HasSubstr("PART #test"));
ircd.ReadUntil("PART #test");
// Server returns 442 error (ERR_NOTONCHANNEL) instead of confirming
ircd.Write(":server 442 nick #test :You're not on that channel");