adam/znc
1
0
Fork 0
mirror of https://github.com/znc/znc.git synced 2026-08-01 22:43:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Fix JOIN command not joining detached channels on other clients."

Browse Source 
This reverts commit ba32b092e9.

It broke /hop (/part+/join) due to race with server
This commit is contained in:
Alexey Sokolov
2026-07-19 20:35:31 +01:00
parent 512d35233b
commit 6d470db241
2 changed files with 8 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/integration/tests/core.cpp
-38
View File
@@ -1278,43 +1278,5 @@ TEST_F(ZNCTest, CAPDetached) {
<< "Client saw chghost even though all channels are detached";
}
// Test for CChan::AttachUser()
TEST_F(ZNCTest, JoinDetachedChannelMultiClient) {
auto znc = Run();
auto ircd = ConnectIRCd();
auto client1 = LoginClient();
ircd.Write(":server 001 nick :Hello");
client1.Write("JOIN #test");
ircd.ReadUntil("JOIN #test");
ircd.Write(":nick JOIN :#test");
ircd.Write(":server 353 nick #test :nick");
ircd.Write(":server 366 nick #test :End of /NAMES list");
client1.ReadUntil("End of /NAMES");
client1.Write("DETACH #test");
client1.ReadUntil("Detached 1 channel");
auto client2 = LoginClient();
client2.ReadUntil("001");
// Both client1 and client2 should be in #test
client2.Write("JOIN #test");
client1.ReadUntil(":nick JOIN :#test");
client2.ReadUntil(":nick JOIN :#test");
client1.ReadUntil("353");
client2.ReadUntil("353");
ircd.Write(":other!user@host JOIN :#test");
client1.ReadUntil(":other!user@host JOIN :#test");
client2.ReadUntil(":other!user@host JOIN :#test");
ircd.Write(":other!user@host QUIT :quit message");
client1.ReadUntil(":other!user@host QUIT :quit message");
client2.ReadUntil(":other!user@host QUIT :quit message");
}
} // namespace
} // namespace znc_inttest