mirror of
https://github.com/znc/znc.git
synced 2026-08-06 08:52:57 +02:00
Remove a footgun by decreasing the SASL API surface for modules
Even without the bad vtable of mutex inside shared_ptr, if a module creates a subclass of CAuthBase, but then unloads, we have the same problem.
This commit is contained in:
@@ -42,8 +42,7 @@ class CSASLMechanismPlain : public CModule {
|
||||
return HALTMODS;
|
||||
}
|
||||
|
||||
auto spAuth = CAuthBase::WrapPointer(new CClientSASLAuth(GetClient(), sAuthcId, sPassword));
|
||||
GetClient()->StartPasswordCheck(spAuth);
|
||||
GetClient()->StartSASLPasswordCheck(sAuthcId, sPassword);
|
||||
return HALTMODS;
|
||||
}
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user