From 375e74429818415b6daeb986cd7dc3c0d5e8d4c4 Mon Sep 17 00:00:00 2001 From: RealKindOne Date: Thu, 27 Aug 2026 03:30:34 -0400 Subject: [PATCH] autoattach: use const CString& in TryAttach and simplify On...Message events. TryAttach() only reads and never mutates. --- modules/autoattach.cpp | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/modules/autoattach.cpp b/modules/autoattach.cpp index 0b65d8da..e8d4a0cf 100644 --- a/modules/autoattach.cpp +++ b/modules/autoattach.cpp @@ -187,7 +187,7 @@ class CChanAttach : public CModule { return true; } - void TryAttach(const CNick& Nick, CChan& Channel, CString& Message) { + void TryAttach(const CNick& Nick, CChan& Channel, const CString& Message) { const CString& sChan = Channel.GetName(); const CString& sHost = Nick.GetHostMask(); const CString& sMessage = Message; @@ -210,23 +210,17 @@ class CChanAttach : public CModule { } EModRet OnChanNoticeMessage(CNoticeMessage& Message) override { - CString sText = Message.GetText(); - TryAttach(Message.GetNick(), *Message.GetChan(), sText); - Message.SetText(sText); + TryAttach(Message.GetNick(), *Message.GetChan(), Message.GetText()); return CONTINUE; } EModRet OnChanTextMessage(CTextMessage& Message) override { - CString sText = Message.GetText(); - TryAttach(Message.GetNick(), *Message.GetChan(), sText); - Message.SetText(sText); + TryAttach(Message.GetNick(), *Message.GetChan(), Message.GetText()); return CONTINUE; } EModRet OnChanActionMessage(CActionMessage& Message) override { - CString sText = Message.GetText(); - TryAttach(Message.GetNick(), *Message.GetChan(), sText); - Message.SetText(sText); + TryAttach(Message.GetNick(), *Message.GetChan(), Message.GetText()); return CONTINUE; }