adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

Improve test coverage for clearbufferonmsg, crypt, ctcpflood, and watch.

Browse Source 
Close #2038
This commit is contained in:
RealKindOne authored and Alexey Sokolov committed 2026-09-13 11:27:54 +01:00
1 parent cdf29c0dd4
commit 30d14d0841
1 file changed
+48 -1
Download Patch File Download Diff File Expand all files Collapse all files
test/integration/tests/modules.cpp
+48 -1
View File
@@ -153,6 +153,10 @@ TEST_F(ZNCTest, WatchModule) {
ircd.Write(":n!i@h PRIVMSG nick :\001ACTION foo\001");
client.ReadUntil(":$*!watch@znc.in PRIVMSG nick :* CTCP: n [ACTION foo]");
// OnPrivCTCPReplyMessage
ircd.Write(":n!i@h NOTICE nick :\001VERSION znc 1.0\001");
client.ReadUntil(":$*!watch@znc.in PRIVMSG nick :* CTCP: n reply [VERSION znc 1.0]");
// OnPrivNoticeMessage
ircd.Write(":n!i@h NOTICE nick :Private notice");
client.ReadUntil(":$*!watch@znc.in PRIVMSG nick :-n- Private notice");
@@ -308,7 +312,7 @@ TEST_F(ZNCTest, CryptModule) {
ircd2.Write(":user!user@user/test " + chanActionMsg);
client2.ReadUntil("dances");
// OnTopicMessage / OnNumericMessage
// OnUserTopicMessage / OnNumericMessage
client1.Write("TOPIC #test :new chan topic");
QByteArray chanTopicEncrypted;
ircd1.ReadUntilAndGet("TOPIC #test :+OK ", chanTopicEncrypted);
@@ -316,6 +320,11 @@ TEST_F(ZNCTest, CryptModule) {
chanTopicEncrypted.lastIndexOf(' ') + 1);
ircd2.Write(":ircd2 332 nick2 #test :" + chanTopicEncrypted);
client2.ReadUntil("new chan topic");
// OnTopicMessage
ircd2.Write(":user!user@user/test TOPIC #test :" + chanTopicEncrypted);
QByteArray topicLine;
client2.ReadUntilAndGet("TOPIC #test :", topicLine);
}
TEST_F(ZNCTest, AutoAttachModule) {
@@ -884,6 +893,26 @@ TEST_F(ZNCTest, ClearBufferOnMsgModule) {
remainder = client.ReadRemainder();
EXPECT_THAT(remainder, Not(HasSubstr("OnUserTopicMessage")))
<< "OnUserTopicMessage failed to clear buffer";
// OnUserQuitMessage
client.Write("znc unloadmod clearbufferonmsg");
client.ReadUntil("unloaded");
// quit is set as false by default
client.Write("znc loadmod clearbufferonmsg quit");
client.ReadUntil("Loaded module");
ircd.Write(":other!user@host PRIVMSG #test :buffered message");
client.ReadUntil("buffered message");
client.Write("QUIT :bye");
client.Close();
auto client2 = LoginClient();
client2.ReadUntil("001");
client2.Write("JOIN #test");
ASSERT_THAT(client2.ReadRemainder().toStdString(),
Not(HasSubstr("buffered message")));
}
TEST_F(ZNCTest, CtcpFloodModule) {
@@ -899,6 +928,7 @@ TEST_F(ZNCTest, CtcpFloodModule) {
ircd.Write(":server 353 nick = #test :nick someone");
ircd.Write(":server 366 nick #test :End of /NAMES list");
// OnChanCTCPMessage
ircd.Write(":someone!user@host PRIVMSG #test :\001message1\001");
ircd.Write(":someone!user@host PRIVMSG #test :\001message2\001");
ircd.Write(":someone!user@host PRIVMSG #test :\001message3\001");
@@ -907,6 +937,23 @@ TEST_F(ZNCTest, CtcpFloodModule) {
ircd.Write(":someone!user@host PRIVMSG #test :\001message6\001");
ircd.Write(":someone!user@host PRIVMSG #test :\001message7\001");
client.ReadUntil("Limit reached by");
// Unload to reset timer.
client.Write("znc unloadmod ctcpflood");
client.ReadUntil("unloaded");
client.Write("znc loadmod ctcpflood");
client.ReadUntil("Loaded module");
// OnPrivCTCPMessage
ircd.Write(":query!user@host PRIVMSG nick :\001message1\001");
ircd.Write(":query!user@host PRIVMSG nick :\001message2\001");
ircd.Write(":query!user@host PRIVMSG nick :\001message3\001");
ircd.Write(":query!user@host PRIVMSG nick :\001message4\001");
ircd.Write(":query!user@host PRIVMSG nick :\001message5\001");
ircd.Write(":query!user@host PRIVMSG nick :\001message6\001");
ircd.Write(":query!user@host PRIVMSG nick :\001message7\001");
client.ReadUntil("Limit reached by");
}
TEST_F(ZNCTest, FloodDetachModule) {