adam/znc
1
0
Fork 0
mirror of https://github.com/znc/znc.git synced 2026-07-03 08:21:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix a memory leak in rehashing

Browse Source 
The fake user rehashing uses was leaked completly (BAD)

Thanks to SilverLeo for reporting and x-x for making me track this one down :P


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@992 726aef4b-f618-498e-8847-2d620e286838
This commit is contained in:
psychon
2008-03-24 22:22:41 +00:00
parent acdd2c61b9
commit 246e71fe45
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
znc.cpp
+8 -2
View File
@@ -1008,14 +1008,20 @@ bool CZNC::DoRehash(CString& sError)
sError = "Invalid user [" + pUser->GetUserName() + "] " + sErr;
DEBUG_ONLY(cout << "CUser::Clone() failed in rehash" << endl);
}
pUser->SetBeingDeleted(true);
delete pUser;
pUser = NULL;
} else if (!AddUser(pUser, sErr)) {
sError = "Invalid user [" + pUser->GetUserName() + "] " + sErr;
}
if (!sError.empty()) {
CUtils::PrintError(sError);
pUser->SetBeingDeleted(true);
delete pUser;
if (pUser) {
pUser->SetBeingDeleted(true);
delete pUser;
pUser = NULL;
}
return false;
}