From 0467b695351804998ed6986331522f77b58ebdd0 Mon Sep 17 00:00:00 2001
From: Vasily Fomin <vasili.fomin@gmail.com>
Date: Tue, 10 Jun 2014 21:30:37 +0200
Subject: [PATCH] Fixes issue #505: Module links in webadmin should use _blank.
 Wikipedia "Icon External Link"
 (http://commons.wikimedia.org/wiki/File:Icon_External_Link.png) is being used
 as an icon for the external link.

---
 modules/data/webadmin/tmpl/add_edit_network.tmpl  |   2 +-
 modules/data/webadmin/tmpl/add_edit_user.tmpl     |   2 +-
 modules/data/webadmin/tmpl/settings.tmpl          |   2 +-
 webskins/_default_/pub/_default_.css              |   5 +++++
 webskins/_default_/pub/external-link-ltr-icon.png | Bin 0 -> 141 bytes
 5 files changed, 8 insertions(+), 3 deletions(-)
 create mode 100644 webskins/_default_/pub/external-link-ltr-icon.png

diff --git a/modules/data/webadmin/tmpl/add_edit_network.tmpl b/modules/data/webadmin/tmpl/add_edit_network.tmpl
index 118f875a..2fa0e61e 100644
--- a/modules/data/webadmin/tmpl/add_edit_network.tmpl
+++ b/modules/data/webadmin/tmpl/add_edit_network.tmpl
@@ -171,7 +171,7 @@
 				<? LOOP ModuleLoop ?>
 					<tr class="<? IF __EVEN__ ?>evenrow<? ELSE ?>oddrow<? ENDIF ?>">
 						<td class="mod_name">
-							<input type="checkbox" name="loadmod" id="lm_<? VAR Name ?>" value="<? VAR Name ?>"<? IF Checked ?> checked="checked"<? ENDIF ?><? IF Disabled ?> disabled="disabled"<? ENDIF ?> /><label for="lm_<? VAR Name ?>"> <? IF Wiki ?><a href="http://wiki.znc.in/<? VAR Wiki ?>"><? VAR Name ?></a> <? ELSE ?> <? VAR Name ?> <? ENDIF ?></label>
+							<input type="checkbox" name="loadmod" id="lm_<? VAR Name ?>" value="<? VAR Name ?>"<? IF Checked ?> checked="checked"<? ENDIF ?><? IF Disabled ?> disabled="disabled"<? ENDIF ?> /><label for="lm_<? VAR Name ?>"> <? IF Wiki ?><a href="http://wiki.znc.in/<? VAR Wiki ?>" target="_blank" class="external"><? VAR Name ?></a> <? ELSE ?> <? VAR Name ?> <? ENDIF ?></label>
 						</td>
 						<td class="mod_args">
 							<? IF Disabled ?>
diff --git a/modules/data/webadmin/tmpl/add_edit_user.tmpl b/modules/data/webadmin/tmpl/add_edit_user.tmpl
index fa0f85f2..487c4176 100644
--- a/modules/data/webadmin/tmpl/add_edit_user.tmpl
+++ b/modules/data/webadmin/tmpl/add_edit_user.tmpl
@@ -181,7 +181,7 @@
 				<? LOOP ModuleLoop ?>
 					<tr class="<? IF __EVEN__ ?>evenrow<? ELSE ?>oddrow<? ENDIF ?>">
 						<td class="mod_name">
-							<input type="checkbox" name="loadmod" id="lm_<? VAR Name ?>" value="<? VAR Name ?>"<? IF Checked ?> checked="checked"<? ENDIF ?><? IF Disabled ?> disabled="disabled"<? ENDIF ?> /><label for="lm_<? VAR Name ?>"> <? IF Wiki ?><a href="http://wiki.znc.in/<? VAR Wiki ?>"><? VAR Name ?></a> <? ELSE ?> <? VAR Name ?> <? ENDIF ?></label>
+							<input type="checkbox" name="loadmod" id="lm_<? VAR Name ?>" value="<? VAR Name ?>"<? IF Checked ?> checked="checked"<? ENDIF ?><? IF Disabled ?> disabled="disabled"<? ENDIF ?> /><label for="lm_<? VAR Name ?>"> <? IF Wiki ?><a href="http://wiki.znc.in/<? VAR Wiki ?>" target="_blank" class="external"><? VAR Name ?></a> <? ELSE ?> <? VAR Name ?> <? ENDIF ?></label>
 						</td>
 						<td class="mod_args">
 							<? IF Disabled ?>
diff --git a/modules/data/webadmin/tmpl/settings.tmpl b/modules/data/webadmin/tmpl/settings.tmpl
index a599c180..a2a0aa4e 100644
--- a/modules/data/webadmin/tmpl/settings.tmpl
+++ b/modules/data/webadmin/tmpl/settings.tmpl
@@ -179,7 +179,7 @@
 							<? IF Checked ?> checked="checked"<? ENDIF ?>
 							<? IF Disabled ?> disabled="disabled"<? ENDIF ?> />
 							<label for="lm_<? VAR Name ?>">
-							<? IF Wiki ?><a href="http://wiki.znc.in/<? VAR Wiki ?>"><? VAR Name ?></a>
+							<? IF Wiki ?><a href="http://wiki.znc.in/<? VAR Wiki ?>" target="_blank" class="external"><? VAR Name ?></a>
 							<? ELSE ?> <? VAR Name ?> <? ENDIF ?></label>
 						</td>
 						<td class="mod_args">
diff --git a/webskins/_default_/pub/_default_.css b/webskins/_default_/pub/_default_.css
index 53258955..7f4e22a8 100644
--- a/webskins/_default_/pub/_default_.css
+++ b/webskins/_default_/pub/_default_.css
@@ -26,6 +26,11 @@ a:hover {
 	text-decoration: underline;
 }
 
+a.external {
+	background: url(/skinfiles/_default_/external-link-ltr-icon.png) center right no-repeat;
+	padding-right: 13px;
+}
+
 #main a:visited {
 	color: #99008B;
 }
diff --git a/webskins/_default_/pub/external-link-ltr-icon.png b/webskins/_default_/pub/external-link-ltr-icon.png
new file mode 100644
index 0000000000000000000000000000000000000000..6308383168ccac3158baaf87ffdc530125c7c865
GIT binary patch
literal 141
zcmeAS@N?(olHy`uVBq!ia0vp^AT}2V8<6ZZI=>f4g?PF+hE&|DJ>SU5pupi0Se~U0
zLc5e&&IhW<G}*B@Pf`t1I&xvg(mNlS;>6h{BqBd~ShVvv>@Jq9P@H!n@<7}?#T8fh
m=iR%Y?|Fc4!mk76GI~D`XnAXW(wGG_pTX1B&t;ucLK6V<3ofew

literal 0
HcmV?d00001