adam/vscode-front-matter
1
0 Fork 0
mirror of https://github.com/estruyf/vscode-front-matter.git synced 2026-10-30 23:41:57 +01:00
Code Issues 77 Packages Projects Releases Wiki Activity

Issue: isStarted flag inherited when "terminal.integrated.enablePersistentSessions": true #553

New Issue
Closed
opened 2026-10-05 02:52:25 +02:00 by adam · 4 comments
adam commented 2026-10-05 02:52:25 +02:00
Owner
Copy link
Copy source

Describe the bug
isStarted flag inherited between vscode session when "terminal.integrated.enablePersistentSessions": true
Therefore dashboard gui shows 'stop server' at start time.

To Reproduce

  • set vscode config "terminal.integrated.enablePersistentSessions": true
  • start server via frontmatter dashboard
  • stop vscode
  • restart vscode

Expected behavior

isStarted flag should be false when vscode starts.

Desktop (please complete the following information):

  • OS: Ubuntu2304

Additional context
frontmatter: v9.3.0
VSCODE: 1.83.1

**Describe the bug** isStarted flag inherited between vscode session when `"terminal.integrated.enablePersistentSessions": true` Therefore dashboard gui shows 'stop server' at start time. **To Reproduce** - set `vscode` config `"terminal.integrated.enablePersistentSessions": true` - start server via frontmatter dashboard - stop `vscode` - restart `vscode` **Expected behavior** isStarted flag should be `false` when `vscode` starts. **Desktop (please complete the following information):** - OS: Ubuntu2304 **Additional context** frontmatter: v9.3.0 VSCODE: 1.83.1 <!-- github-sync-id:1962486009 -->
adam closed this issue 2026-10-05 02:52:25 +02:00
adam commented 2026-10-05 02:52:26 +02:00
Author
Owner
Copy link
Copy source

I'm unsure if I'm doing it right, so I want to ensure how to reproduce the issue you are facing. Is this the flow:

https://github.com/estruyf/vscode-front-matter/assets/2900833/d8973921-1ddb-4929-a89e-783d4bec9bd6

By default, the isStarted flag is false, but it will check if the VSCode FM server terminal window is open. We might need to implement a check on the extension startup to close this terminal window if still opened on restart.

I'm unsure if I'm doing it right, so I want to ensure how to reproduce the issue you are facing. Is this the flow: https://github.com/estruyf/vscode-front-matter/assets/2900833/d8973921-1ddb-4929-a89e-783d4bec9bd6 By default, the `isStarted` flag is false, but it will check if the VSCode FM server terminal window is open. We might need to implement a check on the extension startup to close this terminal window if still opened on restart. <!-- github-comment-id:1780530463 -->
adam commented 2026-10-05 02:52:27 +02:00
Author
Owner
Copy link
Copy source

Implemented the fix for this and it is testable in the latest beta version.

Implemented the fix for this and it is testable in the latest beta version. <!-- github-comment-id:1780544790 -->
adam commented 2026-10-05 02:52:27 +02:00
Author
Owner
Copy link
Copy source

Screenshot from 2023-10-26 16-32-08

My screen shot just after restart VScode and open frontmatter dashboard.

"* History Retorted" may do some something tricky.

![Screenshot from 2023-10-26 16-32-08](https://github.com/estruyf/vscode-front-matter/assets/2455518/d9a62dac-f9ed-46f9-96dc-75e984fae19a) My screen shot just after restart VScode and open frontmatter dashboard. "* History Retorted" may do some something tricky. <!-- github-comment-id:1780617006 -->
adam commented 2026-10-05 02:52:28 +02:00
Author
Owner
Copy link
Copy source

Thanks, this will indeed be handled by this change in the beta version.

Thanks, this will indeed be handled by this change in the beta version. <!-- github-comment-id:1780619228 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/vscode-front-matter#553