adam/vscode-front-matter
1
0 Fork 0
mirror of https://github.com/estruyf/vscode-front-matter.git synced 2026-11-03 17:12:21 +01:00
Code Issues 77 Packages Projects Releases Wiki Activity

Issue: Arguments passed to custom actions in Node are improperly formatted on both MacOs and Windows #494

New Issue
Closed
opened 2026-10-05 02:50:08 +02:00 by adam · 3 comments
adam commented 2026-10-05 02:50:08 +02:00
Owner
Copy link
Copy source

Describe the bug
When invoking custom actions using Node.js, the arguments passed are mishandled on Windows. Specifically:

  1. Paths to scripts are not escaped, leading to issues when directory names contain spaces.
  2. The JSON argument for front matter, when escaped with single quotes, behaves differently between macOS and Windows. On Windows, the argument loses its double quotes when passed, causing JSON.parse to fail.
  3. Additionally, the command node does not recognize globally installed packages, necessitating absolute paths to libraries in scripts.

To Reproduce
Steps to reproduce the behavior:

  1. Set up a custom action in Node.js.
  2. Provide a script path that contains spaces.
  3. Pass a JSON front matter argument enclosed with single quotes.
  4. Run the custom action on both macOS and Windows.
  5. Observe that on Windows, the script may fail due to spaces in the directory name and JSON.parse will throw an error due to the missing double quotes in the JSON argument.
  6. Also, note the inability to recognize globally installed packages.

Expected behavior
Arguments should be consistently and correctly passed to custom actions across different operating systems. Paths should be escaped to handle spaces, and JSON arguments should retain their original formatting. Also, globally installed Node.js packages should be recognized without the need for absolute paths.

Screenshots
N/A

Desktop (please complete the following information):

  • Windows 10 & 11 (x64), MacOs 13.5 (Apple Silicon)

Additional context
I am using version 8.4.0 of the software.

**Describe the bug** When invoking custom actions using Node.js, the arguments passed are mishandled on Windows. Specifically: 1. Paths to scripts are not escaped, leading to issues when directory names contain spaces. 2. The JSON argument for front matter, when escaped with single quotes, behaves differently between macOS and Windows. On Windows, the argument loses its double quotes when passed, causing `JSON.parse` to fail. 3. Additionally, the command `node` does not recognize globally installed packages, necessitating absolute paths to libraries in scripts. **To Reproduce** Steps to reproduce the behavior: 1. Set up a custom action in Node.js. 2. Provide a script path that contains spaces. 3. Pass a JSON front matter argument enclosed with single quotes. 4. Run the custom action on both macOS and Windows. 5. Observe that on Windows, the script may fail due to spaces in the directory name and `JSON.parse` will throw an error due to the missing double quotes in the JSON argument. 6. Also, note the inability to recognize globally installed packages. **Expected behavior** Arguments should be consistently and correctly passed to custom actions across different operating systems. Paths should be escaped to handle spaces, and JSON arguments should retain their original formatting. Also, globally installed Node.js packages should be recognized without the need for absolute paths. **Screenshots** N/A **Desktop (please complete the following information):** - Windows 10 & 11 (x64), MacOs 13.5 (Apple Silicon) **Additional context** I am using version 8.4.0 of the software. <!-- github-sync-id:1859295129 -->
adam closed this issue 2026-10-05 02:50:08 +02:00
adam commented 2026-10-05 02:50:09 +02:00
Author
Owner
Copy link
Copy source

Thanks @steelcoder for opening the issue.

Thanks @steelcoder for opening the issue. <!-- github-comment-id:1687677482 -->
adam commented 2026-10-05 02:50:10 +02:00
Author
Owner
Copy link
Copy source

I have added a fix for the paths with spaces and JSON arguments on Windows.

About the node command not recognizing globally installed packages, this is a configuration on the local machine. By default, node will not retrieve global modules; you must ensure the global node_modules folder is set in the path environment variable. Check StackOverflow issue for more information.

I have added a fix for the paths with spaces and JSON arguments on Windows. About the node command not recognizing globally installed packages, this is a configuration on the local machine. By default, node will not retrieve global modules; you must ensure the global node_modules folder is set in the path environment variable. Check [StackOverflow issue](https://stackoverflow.com/questions/9587665/nodejs-cannot-find-installed-module-on-windows) for more information. <!-- github-comment-id:1687874874 -->
adam commented 2026-10-05 02:50:11 +02:00
Author
Owner
Copy link
Copy source

Thank you @estruyf for your responsiveness 😉

Thank you @estruyf for your responsiveness 😉 <!-- github-comment-id:1687884730 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/vscode-front-matter#494