adam/vscode-front-matter
1
0 Fork 0
mirror of https://github.com/estruyf/vscode-front-matter.git synced 2026-11-04 01:22:21 +01:00
Code Issues 77 Packages Projects Releases Wiki Activity

Issue: Add missing fields adds fields to content type defintion "instead" of document #381

New Issue
Closed
opened 2026-10-05 02:44:04 +02:00 by adam · 3 comments
adam commented 2026-10-05 02:44:04 +02:00
Owner
Copy link
Copy source

Describe the bug
When I choose Add missing fields option on a markdown file with properties not part of the content type, the central content type definition is updated with the additional field/s.

I don't want a random file with a misspelled property being the culprit of messing with the content types with out confirmation.
Also, I somehow always expect the "missing" properties will be added to the file and not the other way around.

To Reproduce
Probably by design...

Expected behavior

  1. Add missing fields should be labeled Add missing fields to definition.
  2. Before updating the actual Content Type definition, have the user confirm the update first.

Screenshots
image

Desktop (please complete the following information):

  • Version: 1.74.0 (user setup)
  • Commit: 5235c6bb189b60b01b1f49062f4ffa42384f8c91
  • Date: 2022-12-05T16:38:16.075Z
  • Electron: 19.1.8
  • Chromium: 102.0.5005.167
  • Node.js: 16.14.2
  • V8: 10.2.154.15-electron.0
  • OS: Windows_NT x64 10.0.19044
  • Sandboxed: No
  • FrontMatter: 8.2.0
**Describe the bug** When I choose `Add missing fields` option on a markdown file with properties not part of the content type, the central content type definition is updated with the additional field/s. I don't want a random file with a misspelled property being the culprit of messing with the content types with out confirmation. Also, I somehow always expect the "missing" properties will be added to the file and not the other way around. **To Reproduce** Probably by design... **Expected behavior** 1. `Add missing fields` should be labeled `Add missing fields to definition`. 2. Before updating the actual Content Type definition, have the user confirm the update first. **Screenshots** ![image](https://user-images.githubusercontent.com/20666032/207124306-54b367ce-5f40-41df-b0e5-b29addb580db.png) **Desktop (please complete the following information):** - Version: 1.74.0 (user setup) - Commit: 5235c6bb189b60b01b1f49062f4ffa42384f8c91 - Date: 2022-12-05T16:38:16.075Z - Electron: 19.1.8 - Chromium: 102.0.5005.167 - Node.js: 16.14.2 - V8: 10.2.154.15-electron.0 - OS: Windows_NT x64 10.0.19044 - Sandboxed: No - FrontMatter: 8.2.0 <!-- github-sync-id:1492509573 -->
adam closed this issue 2026-10-05 02:44:04 +02:00
adam commented 2026-10-05 02:44:05 +02:00
Author
Owner
Copy link
Copy source

This feature is intended to update the content-type so that it is easy to get started creating or updating content-types.

An add missing fields to content might also be appropriate.

This feature is intended to update the content-type so that it is easy to get started creating or updating content-types. An `add missing fields to content` might also be appropriate. <!-- github-comment-id:1350650426 -->
adam commented 2026-10-05 02:44:06 +02:00
Author
Owner
Copy link
Copy source

Yes, but it's labeled in a confusing way.

Yes, but it's labeled in a confusing way. <!-- github-comment-id:1350659208 -->
adam commented 2026-10-05 02:44:07 +02:00
Author
Owner
Copy link
Copy source

Labels will be changed to the following:

image

Labels will be changed to the following: ![image](https://user-images.githubusercontent.com/2900833/217926509-2d6a4eab-d7cf-41d5-8f43-3424c3a813fb.png) <!-- github-comment-id:1424751215 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/vscode-front-matter#381