adam/vscode-front-matter
1
0 Fork 0
mirror of https://github.com/estruyf/vscode-front-matter.git synced 2026-11-03 17:12:21 +01:00
Code Issues 77 Packages Projects Releases Wiki Activity

Issue: Deleted content does not get added in git when syncing #371

New Issue
Closed
opened 2026-10-05 02:43:36 +02:00 by adam · 3 comments
adam commented 2026-10-05 02:43:36 +02:00
Owner
Copy link
Copy source

All the deleted content, this being articles or images, is not added to git when syncing. Only the modified and not added files are being added to the git commit.

Steps to reproduce
To reproduce the behavior:

  1. Create a new file
  2. Commit it
  3. Delete it and perform a sync with front matter

You are going to notice that the deleted file has not been committed.

Expected Behaviour
Even the deleted files should be added in the git commit since it's a clear modification of the contents of the cms.

Solution
Around these lines of GitListener.ts, in the push() method, there should be another for loop iterating through the files contained in status.deleted adding them to the git commit.

Please let me know if I'm missing on something, I'll be happy to contribute in first person to the fix for this.

All the deleted content, this being articles or images, is not added to git when syncing. Only the modified and not added files are being added to the git commit. **Steps to reproduce** To reproduce the behavior: 1. Create a new file 1. Commit it 1. Delete it and perform a sync with front matter You are going to notice that the deleted file has not been committed. **Expected Behaviour** Even the deleted files should be added in the git commit since it's a clear modification of the contents of the cms. **Solution** Around [these](https://github.com/estruyf/vscode-front-matter/blob/1fe03197e336e8dde7cd879de97daa2eea9076df/src/listeners/general/GitListener.ts#L102) lines of ```GitListener.ts```, in the ```push()``` method, there should be another for loop iterating through the files contained in ```status.deleted``` adding them to the git commit. Please let me know if I'm missing on something, I'll be happy to contribute in first person to the fix for this. <!-- github-sync-id:1462419143 -->
adam closed this issue 2026-10-05 02:43:36 +02:00
adam commented 2026-10-05 02:43:37 +02:00
Author
Owner
Copy link
Copy source

Thank you @albbus-stack, for opening the issue and taking a look at it. If you feel you can fix it, and want to do a PR, you are more than welcome to do so.

Thank you @albbus-stack, for opening the issue and taking a look at it. If you feel you can fix it, and want to do a PR, you are more than welcome to do so. <!-- github-comment-id:1326063577 -->
adam commented 2026-10-05 02:43:37 +02:00
Author
Owner
Copy link
Copy source

I've gone ahead and added the modification in the above PR, further details are explained there. I've assumed the dev branch was the correct place, if not just merge it elsewere at your liking and close this issue. Thank you and keep up the great work :octocat:

I've gone ahead and added the modification in the above PR, further details are explained there. I've assumed the dev branch was the correct place, if not just merge it elsewere at your liking and close this issue. Thank you and keep up the great work :octocat: <!-- github-comment-id:1326659352 -->
adam commented 2026-10-05 02:43:38 +02:00
Author
Owner
Copy link
Copy source

Thanks @albbus-stack, your changes looked good and are now available in the latest beta version of the extension.

Thanks @albbus-stack, your changes looked good and are now available in the latest beta version of the extension. <!-- github-comment-id:1326675459 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/vscode-front-matter#371