From ecc9c740919b3af103d2783ca4afe642e8caab03 Mon Sep 17 00:00:00 2001 From: Elio Struyf Date: Wed, 10 Aug 2022 16:09:21 +0200 Subject: [PATCH] #384: Fix issue `title` field in sub-fields --- CHANGELOG.md | 1 + src/dashboardWebView/index.tsx | 5 ++++- src/helpers/ContentType.ts | 8 +++++--- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5aafdf97..92da6383 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,7 @@ ### 🐞 Fixes - [#378](https://github.com/estruyf/vscode-front-matter/issues/378): Fix last modified update only to content in content folders +- [#384](https://github.com/estruyf/vscode-front-matter/issues/384): Fix issue `title` field in sub-fields ## [8.0.1] - 2022-07-13 diff --git a/src/dashboardWebView/index.tsx b/src/dashboardWebView/index.tsx index cd648392..fdd64f11 100644 --- a/src/dashboardWebView/index.tsx +++ b/src/dashboardWebView/index.tsx @@ -40,7 +40,10 @@ if (elm) { tracesSampleRate: 0, // No performance tracing required release: version || "", environment: environment || "", - ignoreErrors: ['ResizeObserver loop limit exceeded'] + ignoreErrors: [ + 'ResizeObserver loop limit exceeded', + "Cannot read properties of undefined (reading 'unobserve')" + ] }); } diff --git a/src/helpers/ContentType.ts b/src/helpers/ContentType.ts index f1b3cf1d..a407887c 100644 --- a/src/helpers/ContentType.ts +++ b/src/helpers/ContentType.ts @@ -572,7 +572,7 @@ export class ContentType { * @param contentType * @param data */ - private static async processFields(obj: IContentType | Field, titleValue: string, data: any, filePath: string) { + private static async processFields(obj: IContentType | Field, titleValue: string, data: any, filePath: string, isRoot: boolean = true): Promise { if (obj.fields) { const dateFormat = Settings.get(SETTING_DATE_FORMAT) as string; @@ -581,12 +581,14 @@ export class ContentType { if (field.default) { data[field.name] = processKnownPlaceholders(field.default, titleValue, dateFormat); data[field.name] = await ArticleHelper.processCustomPlaceholders(data[field.name], titleValue, filePath); - } else { + } else if (isRoot) { data[field.name] = titleValue; + } else { + data[field.name] = "" } } else { if (field.type === "fields") { - data[field.name] = await this.processFields(field, titleValue, {}, filePath); + data[field.name] = await this.processFields(field, titleValue, {}, filePath, false); } else { const defaultValue = field.default;