mirror of
https://github.com/pyMC-dev/pyMC_Repeater.git
synced 2026-10-31 04:01:59 +01:00
agessaman
3023eaca89
OpenHop numbered the ACL roles GUEST=0x01, ADMIN=0x02, READ_WRITE=0x01. Firmware ClientACL.h uses GUEST=0, READ_ONLY=1, READ_WRITE=2, ADMIN=3 in the low two bits, so our admin byte decoded as READ_WRITE in every stock MeshCore client (KiekR showed admin sessions as guest and hid the admin controls), and GUEST/READ_WRITE were indistinguishable from each other. Adopt the firmware values and split the guest password by server type, as firmware does: a repeater's guest password grants GUEST (fetch base telemetry, no settings changes) and a room server's grants READ_WRITE (post and read messages). Blank-password read-only access stays GUEST, matching simple_room_server's allow_read_only branch. Also fix the mesh-CLI admin gate in text.py, which shadowed a local PERM_ACL_ADMIN = 0x02 and tested the bit rather than the role — under the corrected numbering that would have let READ_WRITE clients run admin commands. The web ACL list now reports the real role name instead of collapsing every non-admin to "guest". Requires openhop_core with acl_is_admin() in the login reply (openhop_core fix/login-perms); the two must land together. Fixes #388