adam/pyMC_Repeater
1
0 Fork 0
mirror of https://github.com/pyMC-dev/pyMC_Repeater.git synced 2026-10-30 19:51:59 +01:00
Code Issues 41 Packages Projects Releases Wiki Activity

Recent update turned back on duty cycle enforcement. Turning it back off showed a UI error? #98

New Issue
Closed
opened 2026-10-27 09:33:03 +01:00 by adam · 4 comments
adam commented 2026-10-27 09:33:03 +01:00
Owner
Copy link
Copy source

I'm running 1.0.11.dev23. Prior to updating to that, I had duty cycle disabled. Once this update applied that was turned back on, which is odd. If the user sets that off, it should remain off, right?

The bug is that when to Configuration > Duty Cycle, clicked "Edit Settings", and set Enforcement to disabled. The UI said there was an error, but the config change worked and was applied.

I'm running 1.0.11.dev23. Prior to updating to that, I had duty cycle disabled. Once this update applied that was turned back on, which is odd. If the user sets that off, it should remain off, right? The bug is that when to Configuration > Duty Cycle, clicked "Edit Settings", and set Enforcement to disabled. The UI said there was an error, but the config change worked and was applied. <!-- github-sync-id:4541984753 -->
adam closed this issue 2026-10-27 09:33:03 +01:00
adam commented 2026-10-27 09:33:04 +01:00
Author
Owner
Copy link
Copy source

It also says Failed to Save Settings if I turn it back on.

Image
It also says Failed to Save Settings if I turn it back on. <img width="1429" height="803" alt="Image" src="https://github.com/user-attachments/assets/3561cb41-995d-4915-8f36-c0b791a77738" /> <!-- github-comment-id:4566091454 -->
adam commented 2026-10-27 09:33:05 +01:00
Author
Owner
Copy link
Copy source

@rightup I'll have a look at this one.

@rightup I'll have a look at this one. <!-- github-comment-id:4569025745 -->
adam commented 2026-10-27 09:33:06 +01:00
Author
Owner
Copy link
Copy source

@rightup for your review.

https://github.com/pyMC-dev/pyMC-RepeaterUI/pull/40

Fixes the direct issue and also caught a few other places where this incorrect pattern was being used. Also adds tests. Confirm tests run correctly and have checked all UI paths directly on a dummy device I have here.

@rightup for your review. https://github.com/pyMC-dev/pyMC-RepeaterUI/pull/40 Fixes the direct issue and also caught a few other places where this incorrect pattern was being used. Also adds tests. Confirm tests run correctly and have checked all UI paths directly on a dummy device I have here. <!-- github-comment-id:4569918134 -->
adam commented 2026-10-27 09:33:07 +01:00
Author
Owner
Copy link
Copy source

changes have been made to companion, please re-test.

changes have been made to companion, please re-test. <!-- github-comment-id:4593033949 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/pyMC_Repeater#98