Incorrect retrieval of "storage_dir" #31

New Issue

2026-10-27T09:29:21+01:00

adam commented

2026-10-27 09:29:21 +01:00

Was playing around with pyMC_Repeater yesterday, and noticed that a few of the "storage_dir" fetches appear to lack nesting under "storage":
https://github.com/rightup/pyMC_Repeater/blob/dev/repeater/data_acquisition/storage_collector.py#L22

And all references to "storage_dir" in api_endpoints.py:
https://github.com/rightup/pyMC_Repeater/blob/dev/repeater/web/api_endpoints.py

How this is retrieved in http_server.py appears to be correct (Based on the example config.yaml file, though it has a different default than the others):
storage_dir = self.config.get("storage", {}).get("storage_dir", ".")

This doesn't affect a "production" deployment, but does affect running in development with the data directory set to a relative path

Was playing around with pyMC_Repeater yesterday, and noticed that a few of the "storage_dir" fetches appear to lack nesting under "storage": <https://github.com/rightup/pyMC_Repeater/blob/dev/repeater/data_acquisition/storage_collector.py#L22> And all references to "storage_dir" in api_endpoints.py: <https://github.com/rightup/pyMC_Repeater/blob/dev/repeater/web/api_endpoints.py> How this is retrieved in http_server.py appears to be correct (Based on the example config.yaml file, though it has a different default than the others): `storage_dir = self.config.get("storage", {}).get("storage_dir", ".")` This doesn't affect a "production" deployment, but does affect running in development with the data directory set to a relative path

adam closed this issue

2026-10-27 09:29:21 +01:00

adam commented

2026-10-27 09:29:22 +01:00

fixed in v1.0.10-dev56 thank you for the spot!

fixed in v1.0.10-dev56 thank you for the spot!

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/pyMC_Repeater#31