adam/pyMC_Repeater
1
0 Fork 0
mirror of https://github.com/pyMC-dev/pyMC_Repeater.git synced 2026-10-30 19:51:59 +01:00
Code Issues 41 Packages Projects Releases Wiki Activity

OpenHop Repeater responds to discovery requests even if in listener (no repeats) mode #120

New Issue
Open
opened 2026-10-27 09:34:07 +01:00 by adam · 4 comments
adam commented 2026-10-27 09:34:07 +01:00
Owner
Copy link
Copy source

OpenHop repeater will respond to discovery requests from nearby companions when it is in lists/no-repeat mode.

I am running the latest dev as of today.

R:v1.1.2-dev59
Core:v1.1.3-dev2

image

image

The official repeater-example does not do this when repeat is disabled.

OpenHop repeater will respond to discovery requests from nearby companions when it is in lists/no-repeat mode. I am running the latest dev as of today. R:v1.1.2-dev59 Core:v1.1.3-dev2 ![image](https://github.com/user-attachments/assets/2fa4de8e-2b92-4fa9-a8c9-0d1a1dcb7861) ![image](https://github.com/user-attachments/assets/4a6131a5-c9a8-4c1e-9c58-5ee5812cd107) The official repeater-example does not do this when repeat is disabled. <!-- github-sync-id:4846228373 -->
adam commented 2026-10-27 09:34:08 +01:00
Author
Owner
Copy link
Copy source

Mainline repeaters DO respond to DISCOVER_REQ control frames, even when repeat is disabled. This should remain consistent with mainline.

Mainline repeaters DO respond to DISCOVER_REQ control frames, even when repeat is disabled. This should remain consistent with mainline. <!-- github-comment-id:5485680631 -->
adam commented 2026-10-27 09:34:08 +01:00
Author
Owner
Copy link
Copy source
  1. Mainline repeaters DO respond to DISCOVER_REQ control frames, even when repeat is disabled. This should remain consistent with mainline.

Are you saying that you've tested it and have experience with it, or that you think this is how it works, or that you are familiar with the code?

Here's how a repeater acts with repeat enabled, then disabled, and then enabled. See CapRock Attic , which is running 1.18.0 and the MeshCore app is up to date as well. The results are the same as they were 3 months ago.

Image Image Image Image Image
> 1. Mainline repeaters DO respond to DISCOVER_REQ control frames, even when repeat is disabled. This should remain consistent with mainline. Are you saying that you've tested it and have experience with it, or that you think this is how it works, or that you are familiar with the code? Here's how a repeater acts with repeat enabled, then disabled, and then enabled. See **CapRock Attic** , which is running 1.18.0 and the MeshCore app is up to date as well. The results are the same as they were 3 months ago. <img width="720" height="1127" alt="Image" src="https://github.com/user-attachments/assets/4ecd3459-5ac2-4d26-b704-b36efdf578f9" /> <img width="720" height="1127" alt="Image" src="https://github.com/user-attachments/assets/d9754d8c-2e38-482f-8c07-f5c0ffe81535" /> <img width="720" height="1127" alt="Image" src="https://github.com/user-attachments/assets/f6a70e1b-1b2e-4c50-a13a-780810d73a40" /> <img width="720" height="1127" alt="Image" src="https://github.com/user-attachments/assets/577b926b-5479-4c07-b033-6b054608f2a6" /> <img width="720" height="1127" alt="Image" src="https://github.com/user-attachments/assets/4a60b7af-76b7-4fdb-9b97-0650c638d7aa" /> <!-- github-comment-id:6357905897 -->
adam commented 2026-10-27 09:34:09 +01:00
Author
Owner
Copy link
Copy source

Hmm, I guess the reason my repeaters with repeat disabled respond is because they are using Gessaman's observer firmware, and it omits the !_prefs.disable_fwd check that mainline has. I just checked the source in GitHub, and they don't match.

https://github.com/meshcore-dev/MeshCore/blob/81dbae592ffad40b4212bc0b37e82b38da08f4bc/examples/simple_repeater/MyMesh.cpp#L791
https://github.com/agessaman/MeshCore/blob/405a7d52f4ba100fe7a99a5532ad79280ebe2e88/examples/simple_repeater/MyMesh.cpp#L947

Hmm, I guess the reason my repeaters with repeat disabled respond is because they are using Gessaman's observer firmware, and it omits the `!_prefs.disable_fwd` check that mainline has. I just checked the source in GitHub, and they don't match. https://github.com/meshcore-dev/MeshCore/blob/81dbae592ffad40b4212bc0b37e82b38da08f4bc/examples/simple_repeater/MyMesh.cpp#L791 https://github.com/agessaman/MeshCore/blob/405a7d52f4ba100fe7a99a5532ad79280ebe2e88/examples/simple_repeater/MyMesh.cpp#L947 <!-- github-comment-id:6358073313 -->
adam commented 2026-10-27 09:34:09 +01:00
Author
Owner
Copy link
Copy source

That's one of the things about all of these alternatives. MC was made to have 3rd party apps and other examples of nodes and yet not all are implementing things the same way.

That's one of the things about all of these alternatives. MC was made to have 3rd party apps and other examples of nodes and yet not all are implementing things the same way. <!-- github-comment-id:6365864745 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/pyMC_Repeater#120