From 3f57e78d6a03aea6ded4365ad03edfe70f3df800 Mon Sep 17 00:00:00 2001
From: Lloyd <lloyd@rightup.co.uk>
Date: Thu, 18 Dec 2025 15:44:22 +0000
Subject: [PATCH] Add debug logging for repeater security configuration in
 LoginHelper

---
 repeater/handler_helpers/acl.py   | 7 +++++++
 repeater/handler_helpers/login.py | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/repeater/handler_helpers/acl.py b/repeater/handler_helpers/acl.py
index 3507d5b..47f65a8 100644
--- a/repeater/handler_helpers/acl.py
+++ b/repeater/handler_helpers/acl.py
@@ -87,6 +87,10 @@ class ACL:
             # Repeater uses global passwords from its own security section
             admin_pwd = self.admin_password
             guest_pwd = self.guest_password
+            logger.debug(
+                f"Repeater passwords - admin: {'SET' if admin_pwd else 'NONE'}, "
+                f"guest: {'SET' if guest_pwd else 'NONE'}"
+            )
         
         if target_identity_name:
             logger.debug(f"Authenticating for identity '{target_identity_name}' (room_server={is_room_server})")
@@ -106,6 +110,9 @@ class ACL:
             return True, client.permissions
 
         permissions = 0
+        logger.debug(f"Comparing password (len={len(password)}) against admin/guest")
+        logger.debug(f"Admin pwd len={len(admin_pwd) if admin_pwd else 0}, Guest pwd len={len(guest_pwd) if guest_pwd else 0}")
+        logger.debug(f"Password comparison: '{password}' vs admin='{admin_pwd[:4]}...' ({len(admin_pwd)} chars)")
         if admin_pwd and password == admin_pwd:
             permissions = PERM_ACL_ADMIN
             logger.info(f"Admin password validated for '{target_identity_name or 'unknown'}'")
diff --git a/repeater/handler_helpers/login.py b/repeater/handler_helpers/login.py
index 3cb5307..cedf611 100644
--- a/repeater/handler_helpers/login.py
+++ b/repeater/handler_helpers/login.py
@@ -63,6 +63,11 @@ class LoginHelper:
                 "guest_password": security.get("guest_password", "guest123"),
                 "allow_read_only": security.get("allow_read_only", True),
             }
+            logger.debug(
+                f"Repeater security config: admin_pw={'SET' if final_security['admin_password'] else 'NONE'}, "
+                f"guest_pw={'SET' if final_security['guest_password'] else 'NONE'}, "
+                f"max_clients={final_security['max_clients']}"
+            )
         
         # Create ACL for this identity
         identity_acl = ACL(
@@ -92,6 +97,7 @@ class LoginHelper:
             local_identity=identity,
             log_fn=self.log_fn,
             authenticate_callback=auth_callback_with_context,
+            is_room_server=(identity_type == "room_server"),
         )
         
         handler.set_send_packet_callback(self._send_packet_with_delay)