Why was the blacklist (HIDDEN_CHANNELS) approach taken?
From security standpoint, it would make much more sense to do the opposite: Let users decide to opt-in sharing messages of certain channels - instead of sharing all by default, potentially leaking sensitive information.
As mentioned in the PR, when new channels are added (or in the case of updating PM ingestor to v0.5.7), they are shared by default - leaking new chat messages in all channels to potato-mesh.
Furthermore, all users in a channel that also run potato-mesh would need to apply the HIDDEN_CHANNELS option properly for it to work for a channel.
There was a very short discussion about this in https://github.com/l5yth/potato-mesh/pull/537
Why was the blacklist (`HIDDEN_CHANNELS`) approach taken?
From security standpoint, it would make much more sense to do the opposite: Let users decide to opt-in sharing messages of certain channels - instead of sharing all by default, potentially leaking sensitive information.
As mentioned in the PR, when new channels are added (or in the case of updating PM ingestor to v0.5.7), they are shared by default - leaking new chat messages in all channels to potato-mesh.
Furthermore, all users in a channel that also run potato-mesh would need to apply the `HIDDEN_CHANNELS` option properly for it to work for a channel.
<!-- github-sync-id:3732437505 -->
The way I designed this is to crawl as much data as possible from the mesh, even encrypted communication. A whitelist would stop doing that.
So, I personally have some philosophical resistance. However, I see the need for a whitelist and it's easy to implement and it can even work in addition to the blacklist (with blacklist taking precedent).
I'll add a whitelist to the next release.
The way I designed this is to crawl as much data as possible from the mesh, even encrypted communication. A whitelist would stop doing that.
So, I personally have some philosophical resistance. However, I see the need for a whitelist and it's easy to implement and it can even work in addition to the blacklist (with blacklist taking precedent).
I'll add a whitelist to the next release.
<!-- github-comment-id:3659100628 -->
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
There was a very short discussion about this in https://github.com/l5yth/potato-mesh/pull/537
Why was the blacklist (
HIDDEN_CHANNELS) approach taken?From security standpoint, it would make much more sense to do the opposite: Let users decide to opt-in sharing messages of certain channels - instead of sharing all by default, potentially leaking sensitive information.
As mentioned in the PR, when new channels are added (or in the case of updating PM ingestor to v0.5.7), they are shared by default - leaking new chat messages in all channels to potato-mesh.
Furthermore, all users in a channel that also run potato-mesh would need to apply the
HIDDEN_CHANNELSoption properly for it to work for a channel.The way I designed this is to crawl as much data as possible from the mesh, even encrypted communication. A whitelist would stop doing that.
So, I personally have some philosophical resistance. However, I see the need for a whitelist and it's easy to implement and it can even work in addition to the blacklist (with blacklist taking precedent).
I'll add a whitelist to the next release.