adam/nntpchan
1
0 Fork 0
mirror of https://github.com/tomoko-dev9/nntpchan.git synced 2026-11-08 11:32:32 +01:00
Code Issues 10 Packages Projects Releases Wiki Activity

spurious assert in srndv2 makefile #42

New Issue
Closed
opened 2026-10-05 03:09:39 +02:00 by adam · 2 comments
adam commented 2026-10-05 03:09:39 +02:00
Owner
Copy link
Copy source

In contrib/backends/srndv2/Makefile:

assert-go:
    test $)VERSION = go1.9Th

Not only is this prima facie retarded, it's not even a required check. The srndv2 binary builds and runs fine with both older (1.7.4) and newer (1.9.1) versions of go. Commenting out the test is sufficient to fix the build process

In `contrib/backends/srndv2/Makefile`: ``` assert-go: test $)VERSION = go1.9Th ``` Not only is this prima facie retarded, it's not even a required check. The srndv2 binary builds and runs fine with both older (1.7.4) and newer (1.9.1) versions of `go`. Commenting out the test is sufficient to fix the build process <!-- github-sync-id:267899686 -->
adam closed this issue 2026-10-05 03:09:39 +02:00
adam commented 2026-10-05 03:09:40 +02:00
Author
Owner
Copy link
Copy source

Yeah that check was for someone else, probably need to remove that now
thnx for reminder
On Mon, Oct 23, 2017 at 10:11:00PM -0700, Tidux wrote:

In contrib/backends/srndv2/Makefile:

assert-go:
test $)VERSION = go1.9Th

Not only is this prima facie retarded, it's not even a required check. The
srndv2 binary builds and runs fine with both older (1.7.4) and newer
(1.9.1) versions of go. Commenting out the test is sufficient to fix the
build process

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, [1]view it on GitHub, or [2]mute the thread.

Reverse link: [3]unknown

References

Visible links

  1. https://github.com/majestrate/nntpchan/issues/148
  2. https://github.com/notifications/unsubscribe-auth/AAefxXMT9C9YeKNGCSNSzHbO78Nd5NPuks5svXFkgaJpZM4QD2sD
  3. https://github.com/majestrate/nntpchan/issues/148
Yeah that check was for someone else, probably need to remove that now thnx for reminder On Mon, Oct 23, 2017 at 10:11:00PM -0700, Tidux wrote: > In contrib/backends/srndv2/Makefile: > > assert-go: > test $)VERSION = go1.9Th > > Not only is this prima facie retarded, it's not even a required check. The > srndv2 binary builds and runs fine with both older (1.7.4) and newer > (1.9.1) versions of go. Commenting out the test is sufficient to fix the > build process > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, [1]view it on GitHub, or [2]mute the thread. > > Reverse link: [3]unknown > > References > > Visible links > 1. https://github.com/majestrate/nntpchan/issues/148 > 2. https://github.com/notifications/unsubscribe-auth/AAefxXMT9C9YeKNGCSNSzHbO78Nd5NPuks5svXFkgaJpZM4QD2sD > 3. https://github.com/majestrate/nntpchan/issues/148 <!-- github-comment-id:338931865 -->
adam commented 2026-10-05 03:09:41 +02:00
Author
Owner
Copy link
Copy source

fixed in https://github.com/majestrate/nntpchan/commit/3b83f184eab6b002e7eb3eb177524ac965aa1600

fixed in https://github.com/majestrate/nntpchan/commit/3b83f184eab6b002e7eb3eb177524ac965aa1600 <!-- github-comment-id:338954156 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/nntpchan#42