adam/meshing-around
1
0 Fork 0
mirror of https://github.com/SpudGunMan/meshing-around.git synced 2026-11-03 07:22:23 +01:00
Code Issues 12 Packages Projects Releases Wiki Activity

get_wx_meteo() mislabels precipitation probability (%) as a rain amount (mm/in) #138

New Issue
Closed
opened 2026-10-05 01:25:31 +02:00 by adam · 2 comments
adam commented 2026-10-05 01:25:31 +02:00
Owner
Copy link
Copy source

Description:

In mesh_bot.py, the get_wx_meteo() function pulls precipitation_probability_max from the Open-Meteo API (a percentage, 0-100) but labels it with a rain-amount unit ("mm" or "in") instead of "%". This makes forecast output read as if it is reporting a rainfall total when it is actually reporting a probability.

Code location:

if unit == 0:
    weather_report += "Precip: " + str(round(daily_precipitation_probability_max[i],2)) + "in, in " + str(round(daily_precipitation_hours[i],2)) + " hours. "
else:
    weather_report += "Precip: " + str(round(daily_precipitation_probability_max[i],2)) + "mm, in " + str(round(daily_precipitation_hours[i],2)) + " hours. "

Steps to reproduce:

  1. Enable UseMeteoWxAPI = True in config.ini
  2. Send wx (or trigger any scheduled job calling handle_wxc) on a day with forecast precipitation
  3. Observe output like: Precip: 40.0mm, in 3.5 hours.

Expected behavior:
Since the value plotted is precipitation_probability_max (a percentage), the label should read:
Precip: 40.0% chance, in 3.5 hours.

Actual behavior:
The value is labeled "mm" (metric) or "in" (imperial), implying a rainfall amount rather than a probability - potentially misleading for users relying on this for real weather decisions.

Suggested fix:
Change the unit labels from "mm" / "in" to "%" (or "% chance") in both branches of the if unit == 0 block shown above.

Environment:

  • meshing-around (latest as of Aug 2026)
  • UseMeteoWxAPI = True, useMetric = True
**Description:** In `mesh_bot.py`, the `get_wx_meteo()` function pulls `precipitation_probability_max` from the Open-Meteo API (a percentage, 0-100) but labels it with a rain-amount unit ("mm" or "in") instead of "%". This makes forecast output read as if it is reporting a rainfall total when it is actually reporting a probability. **Code location:** ```python if unit == 0: weather_report += "Precip: " + str(round(daily_precipitation_probability_max[i],2)) + "in, in " + str(round(daily_precipitation_hours[i],2)) + " hours. " else: weather_report += "Precip: " + str(round(daily_precipitation_probability_max[i],2)) + "mm, in " + str(round(daily_precipitation_hours[i],2)) + " hours. " ``` **Steps to reproduce:** 1. Enable `UseMeteoWxAPI = True` in `config.ini` 2. Send `wx` (or trigger any scheduled job calling `handle_wxc`) on a day with forecast precipitation 3. Observe output like: `Precip: 40.0mm, in 3.5 hours.` **Expected behavior:** Since the value plotted is `precipitation_probability_max` (a percentage), the label should read: `Precip: 40.0% chance, in 3.5 hours.` **Actual behavior:** The value is labeled "mm" (metric) or "in" (imperial), implying a rainfall amount rather than a probability - potentially misleading for users relying on this for real weather decisions. **Suggested fix:** Change the unit labels from "mm" / "in" to "%" (or "% chance") in both branches of the `if unit == 0` block shown above. **Environment:** - meshing-around (latest as of Aug 2026) - `UseMeteoWxAPI = True`, `useMetric = True` <!-- github-sync-id:5126061043 -->
adam closed this issue 2026-10-05 01:25:31 +02:00
adam commented 2026-10-05 01:25:32 +02:00
Author
Owner
Copy link
Copy source

Thanks for the prompt response and fix.

Take care!

On Tue, Aug 11, 2026 at 11:47 PM Kelly @.***> wrote:

Closed #329 https://github.com/SpudGunMan/meshing-around/issues/329 as
completed via b9a2f56
https://github.com/SpudGunMan/meshing-around/commit/b9a2f56e3936ed30fe6450898868cc529245a795
.

—
Reply to this email directly, view it on GitHub
https://github.com/SpudGunMan/meshing-around/issues/329?email_source=notifications&email_token=BSBATHWKSVVCIMEMZUV4HW35JPSGVA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOJTGE3TQMJZGU2DPJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#event-29317819547,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BSBATHWYL6UZW42BMALUEID5JPSGVAVCNFSNUABFKJSXA33TNF2G64TZHM4DCMZZHE2DCOJZHNEXG43VMU5TKMJSGYYDMMJQGQZ2C5QC
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
https://github.com/notifications/mobile/ios/BSBATHR5NSKUL3ZP5EP4QBL5JPSGVA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOJTGE3TQMJZGU2DPJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJKTGN5XXIZLSL5UW64Y
and Android
https://github.com/notifications/mobile/android/BSBATHSDYQ542KDPOYVO3T35JPSGVA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOJTGE3TQMJZGU2DPJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI.
Download it today!
You are receiving this because you authored the thread.Message ID:
@.***>

--
Mark
VA3VBE
QRZ page - https://www.qrz.com/db/VA3VBE https://www.qrz.com/db/VA3VBE

Thanks for the prompt response and fix. Take care! On Tue, Aug 11, 2026 at 11:47 PM Kelly ***@***.***> wrote: > Closed #329 <https://github.com/SpudGunMan/meshing-around/issues/329> as > completed via b9a2f56 > <https://github.com/SpudGunMan/meshing-around/commit/b9a2f56e3936ed30fe6450898868cc529245a795> > . > > — > Reply to this email directly, view it on GitHub > <https://github.com/SpudGunMan/meshing-around/issues/329?email_source=notifications&email_token=BSBATHWKSVVCIMEMZUV4HW35JPSGVA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOJTGE3TQMJZGU2DPJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#event-29317819547>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BSBATHWYL6UZW42BMALUEID5JPSGVAVCNFSNUABFKJSXA33TNF2G64TZHM4DCMZZHE2DCOJZHNEXG43VMU5TKMJSGYYDMMJQGQZ2C5QC> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/BSBATHR5NSKUL3ZP5EP4QBL5JPSGVA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOJTGE3TQMJZGU2DPJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJKTGN5XXIZLSL5UW64Y> > and Android > <https://github.com/notifications/mobile/android/BSBATHSDYQ542KDPOYVO3T35JPSGVA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOJTGE3TQMJZGU2DPJTSMVQXG33OUZQXK5DIN5ZKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. > Download it today! > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- Mark VA3VBE QRZ page - *https://www.qrz.com/db/VA3VBE <https://www.qrz.com/db/VA3VBE>* <!-- github-comment-id:5262201099 -->
adam commented 2026-10-05 01:25:32 +02:00
Author
Owner
Copy link
Copy source

Yea thanks for helping get it fixed :) 73

Yea thanks for helping get it fixed :) 73 <!-- github-comment-id:5262209187 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/meshing-around#138