"AutoAdd Max Hops": The value shown in the overview screen is one less than the value input via the Edit button. This is confusing, and unclear which actually is the true value. #169

Open
opened 2026-10-27 15:42:07 +01:00 by adam · 3 comments
Owner

(This is an issue initially reported in "Collected issues for firmware version 0.9.11.", which I now split up into individual reports to be able to track them better.)

Describe the bug

Mgmt → Contacts → AutoAdd Max Hops: The value shown in the overview screen is one less than the value input via the Edit button. This is confusing, and unclear which actually is the true value.

Which device are you using

LilyGO T-Deck Plus

Which Firmware are you using

"MC-Term", version 0.9.11.

To Reproduce

  1. Go to Mgmt → Contacts → AutoAdd Max Hops
  2. Note the number (e.g. "<= 4 hops")
  3. Tap "Edit" besides the number
  4. Note that the number in the input field is one higher (e.g. "5")-

Expected behaviour

Number in the input field equals number in the overview.

Regards!

*(This is an issue initially reported in "[Collected issues for firmware version 0.9.11.](https://github.com/dabeani/meshcoreterm/issues/147)", which I now split up into individual reports to be able to track them better.)* ### Describe the bug `Mgmt` → `Contacts` → `AutoAdd Max Hops`: The value shown in the overview screen is one less than the value input via the Edit button. This is confusing, and unclear which actually is the true value. ### Which device are you using LilyGO T-Deck Plus ### Which Firmware are you using ["MC-Term", version 0.9.11](https://github.com/dabeani/meshcoreterm/releases/tag/v0.9.11). ### To Reproduce 1. Go to `Mgmt` → `Contacts` → `AutoAdd Max Hops` 2. Note the number (e.g. "<= 4 hops") 3. Tap "Edit" besides the number 4. Note that the number in the input field is one higher (e.g. "5")- ### Expected behaviour Number in the input field equals number in the overview. Regards! <!-- github-sync-id:4252932489 -->
Author
Owner

fixed in v0.9.12
Mgmt/Contacts: AutoAdd Max Hops display was off by one

fixed in v0.9.12 **Mgmt/Contacts: AutoAdd Max Hops display was off by one** <!-- github-comment-id:4239566272 -->
Author
Owner

Issue still present, @dabeani, and now somehow more confusing:

Entering "1" results in display "Direct (0)". Entering "2" results in display "2 hops max".

In other parts of the firmware, and also in MeshCore path terminology, direct client-to-client is 0-hop, and 1-hop is with one repeat. So, entering "1" should be "1 hop in between", entering "0" should be "direct", and "no limit" should be denoted differently.

Issue still present, @dabeani, and now somehow more confusing: Entering "1" results in display "Direct (0)". Entering "2" results in display "2 hops max". In other parts of the firmware, and also in MeshCore path terminology, direct client-to-client is 0-hop, and 1-hop is with one repeat. So, entering "1" should be "1 hop in between", entering "0" should be "direct", and "no limit" should be denoted differently. <!-- github-comment-id:4295269996 -->
Author
Owner

Still and again in v0.9.14, now in the following flavour (as it was in the original report):

  • Entering "1" results in display "Direct (0)",
  • Entering anything above "1" results in displaying off by one, e.g. if I enter "8" I get "7".
Still and again in v0.9.14, now in the following flavour (as it was in the original report): * Entering "1" results in display "Direct (0)", * Entering anything above "1" results in displaying off by one, e.g. if I enter "8" I get "7". <!-- github-comment-id:6056448081 -->
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/meshcore#169