mirror of
https://github.com/jorijn/meshcore-stats.git
synced 2026-08-09 02:02:47 +02:00
test: add comprehensive pytest test suite with 95% coverage (#29)
* test: add comprehensive pytest test suite with 95% coverage Add full unit and integration test coverage for the meshcore-stats project: - 1020 tests covering all modules (db, charts, html, reports, client, etc.) - 95.95% code coverage with pytest-cov (95% threshold enforced) - GitHub Actions CI workflow for automated testing on push/PR - Proper mocking of external dependencies (meshcore, serial, filesystem) - SVG snapshot infrastructure for chart regression testing - Integration tests for collection and rendering pipelines Test organization: - tests/charts/: Chart rendering and statistics - tests/client/: MeshCore client and connection handling - tests/config/: Environment and configuration parsing - tests/database/: SQLite operations and migrations - tests/html/: HTML generation and Jinja templates - tests/reports/: Report generation and formatting - tests/retry/: Circuit breaker and retry logic - tests/unit/: Pure unit tests for utilities - tests/integration/: End-to-end pipeline tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: add test-engineer agent configuration Add project-local test-engineer agent for pytest test development, coverage analysis, and test review tasks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: comprehensive test suite review with 956 tests analyzed Conducted thorough review of all 956 test cases across 47 test files: - Unit Tests: 338 tests (battery, metrics, log, telemetry, env, charts, html, reports, formatters) - Config Tests: 53 tests (env loading, config file parsing) - Database Tests: 115 tests (init, insert, queries, migrations, maintenance, validation) - Retry Tests: 59 tests (circuit breaker, async retries, factory) - Charts Tests: 76 tests (transforms, statistics, timeseries, rendering, I/O) - HTML Tests: 81 tests (site generation, Jinja2, metrics builders, reports index) - Reports Tests: 149 tests (location, JSON/TXT formatting, aggregation, counter totals) - Client Tests: 63 tests (contacts, connection, meshcore availability, commands) - Integration Tests: 22 tests (reports, collection, rendering pipelines) Results: - Overall Pass Rate: 99.7% (953/956) - 3 tests marked for improvement (empty test bodies in client tests) - 0 tests requiring fixes Key findings documented in test_review/tests.md including quality observations, F.I.R.S.T. principle adherence, and recommendations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test: implement snapshot testing for charts and reports Add comprehensive snapshot testing infrastructure: SVG Chart Snapshots: - Deterministic fixtures with fixed timestamps (2024-01-15 12:00:00) - Tests for gauge/counter metrics in light/dark themes - Empty chart and single-point edge cases - Extended normalize_svg_for_snapshot_full() for reproducible comparisons TXT Report Snapshots: - Monthly/yearly report snapshots for repeater and companion - Empty report handling tests - Tests in tests/reports/test_snapshots.py Infrastructure: - tests/snapshots/conftest.py with shared fixtures - UPDATE_SNAPSHOTS=1 environment variable for regeneration - scripts/generate_snapshots.py for batch snapshot generation Run `UPDATE_SNAPSHOTS=1 pytest tests/charts/test_chart_render.py::TestSvgSnapshots` to generate initial snapshots. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test: fix SVG normalization and generate initial snapshots Fix normalize_svg_for_snapshot() to handle: - clipPath IDs like id="p47c77a2a6e" - url(#p...) references - xlink:href="#p..." references - <dc:date> timestamps Generated initial snapshot files: - 7 SVG chart snapshots (gauge, counter, empty, single-point in light/dark) - 6 TXT report snapshots (monthly/yearly for repeater/companion + empty) All 13 snapshot tests now pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test: fix SVG normalization to preserve axis rendering The SVG normalization was replacing all matplotlib-generated IDs with the same value, causing duplicate IDs that broke SVG rendering: - Font glyphs, clipPaths, and tick marks all got id="normalized" - References couldn't resolve to the correct elements - X and Y axes failed to render in normalized snapshots Fix uses type-specific prefixes with sequential numbering: - glyph_N for font glyphs (DejaVuSans-XX patterns) - clip_N for clipPath definitions (p[0-9a-f]{8,} patterns) - tick_N for tick marks (m[0-9a-f]{8,} patterns) This ensures all IDs remain unique while still being deterministic for snapshot comparison. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: add coverage and pytest artifacts to gitignore Add .coverage, .coverage.*, htmlcov/, and .pytest_cache/ to prevent test artifacts from being committed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix all ruff lint errors across codebase - Sort and organize imports (I001) - Use modern type annotations (X | Y instead of Union, collections.abc) - Remove unused imports (F401) - Combine nested if statements (SIM102) - Use ternary operators where appropriate (SIM108) - Combine nested with statements (SIM117) - Use contextlib.suppress instead of try-except-pass (SIM105) - Add noqa comments for intentional SIM115 violations (file locks) - Add TYPE_CHECKING import for forward references - Fix exception chaining (B904) All 1033 tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: add TDD workflow and pre-commit requirements to CLAUDE.md - Add mandatory test-driven development workflow (write tests first) - Add pre-commit requirements (must run lint and tests before committing) - Document test organization and running commands - Document 95% coverage requirement 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: resolve mypy type checking errors with proper structural fixes - charts.py: Create PeriodConfig dataclass for type-safe period configuration, use mdates.date2num() for matplotlib datetime handling, fix x-axis limits for single-point charts - db.py: Add explicit int() conversion with None handling for SQLite returns - env.py: Add class-level type annotations to Config class - html.py: Add MetricDisplay TypedDict, fix import order, add proper type annotations for table data functions - meshcore_client.py: Add return type annotation Update tests to use new dataclass attribute access and regenerate SVG snapshots. Add mypy step to CLAUDE.md pre-commit requirements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: cast Jinja2 template.render() to str for mypy Jinja2's type stubs declare render() as returning Any, but it actually returns str. Wrap with str() to satisfy mypy's no-any-return check. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * ci: improve workflow security and reliability - test.yml: Pin all actions by SHA, add concurrency control to cancel in-progress runs on rapid pushes - release-please.yml: Pin action by SHA, add 10-minute timeout - conftest.py: Fix snapshot_base_time to use explicit UTC timezone for consistent behavior across CI and local environments Regenerate SVG snapshots with UTC-aware timestamps. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: add mypy command to permissions in settings.local.json * test: add comprehensive script tests with coroutine warning fixes - Add tests/scripts/ with tests for collect_companion, collect_repeater, and render scripts (1135 tests total, 96% coverage) - Fix unawaited coroutine warnings by using AsyncMock properly for async functions and async_context_manager_factory fixture for context managers - Add --cov=scripts to CI workflow and pyproject.toml coverage config - Omit scripts/generate_snapshots.py from coverage (dev utility) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: migrate claude setup to codex skills * feat: migrate dependencies to uv (#31) * fix: run tests through uv * test: fix ruff lint issues in tests Consolidate patch context managers and clean unused imports/variables Use datetime.UTC in snapshot fixtures * test: avoid unawaited async mocks in entrypoint tests * ci: replace codecov with github coverage artifacts Add junit XML output and coverage summary in job output Upload HTML and XML coverage artifacts (3.12 only) on every run --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Jorijn Schrijvershof
committed by
GitHub
GitHub
parent
45bdf5d6d4
commit
a9f6926104
@@ -0,0 +1 @@
|
||||
"""Tests for HTML generation."""
|
||||
@@ -0,0 +1,74 @@
|
||||
"""Fixtures for HTML tests."""
|
||||
|
||||
from pathlib import Path
|
||||
|
||||
import pytest
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def sample_chart_stats():
|
||||
"""Sample chart statistics for template rendering."""
|
||||
return {
|
||||
"bat": {
|
||||
"day": {"min": 3.5, "avg": 3.7, "max": 3.9, "current": 3.85},
|
||||
"week": {"min": 3.4, "avg": 3.65, "max": 3.95, "current": 3.8},
|
||||
"month": {"min": 3.3, "avg": 3.6, "max": 4.0, "current": 3.75},
|
||||
"year": {"min": 3.2, "avg": 3.55, "max": 4.1, "current": 3.7},
|
||||
},
|
||||
"bat_pct": {
|
||||
"day": {"min": 50, "avg": 70, "max": 90, "current": 85},
|
||||
"week": {"min": 45, "avg": 65, "max": 95, "current": 80},
|
||||
},
|
||||
"nb_recv": {
|
||||
"day": {"min": 0, "avg": 50.5, "max": 100, "current": 75},
|
||||
"week": {"min": 0, "avg": 48.2, "max": 150, "current": 60},
|
||||
},
|
||||
}
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def sample_latest_metrics():
|
||||
"""Sample latest metrics for page rendering."""
|
||||
return {
|
||||
"ts": 1704067200, # 2024-01-01 00:00:00 UTC
|
||||
"bat": 3850.0,
|
||||
"bat_pct": 75.0,
|
||||
"uptime": 86400,
|
||||
"last_rssi": -85,
|
||||
"last_snr": 7.5,
|
||||
"noise_floor": -115,
|
||||
"nb_recv": 1234,
|
||||
"nb_sent": 567,
|
||||
"tx_queue_len": 0,
|
||||
}
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def sample_companion_latest():
|
||||
"""Sample companion latest metrics."""
|
||||
return {
|
||||
"ts": 1704067200,
|
||||
"battery_mv": 3850.0,
|
||||
"bat_pct": 75.0,
|
||||
"uptime_secs": 86400,
|
||||
"contacts": 5,
|
||||
"recv": 1234,
|
||||
"sent": 567,
|
||||
}
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def templates_dir():
|
||||
"""Path to templates directory."""
|
||||
return Path(__file__).parent.parent.parent / "src" / "meshmon" / "templates"
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def sample_svg_content():
|
||||
"""Sample SVG content for testing."""
|
||||
return """<?xml version="1.0" encoding="utf-8"?>
|
||||
<svg xmlns="http://www.w3.org/2000/svg" width="800" height="280"
|
||||
data-metric="bat" data-period="day" data-theme="light">
|
||||
<rect width="100%" height="100%" fill="#ffffff"/>
|
||||
<path d="M0,0 L100,100"/>
|
||||
</svg>"""
|
||||
@@ -0,0 +1,155 @@
|
||||
"""Tests for Jinja2 environment and custom filters."""
|
||||
|
||||
import pytest
|
||||
from jinja2 import Environment
|
||||
|
||||
from meshmon.html import get_jinja_env
|
||||
|
||||
|
||||
class TestGetJinjaEnv:
|
||||
"""Tests for get_jinja_env function."""
|
||||
|
||||
def test_returns_environment(self):
|
||||
"""Returns a Jinja2 Environment."""
|
||||
env = get_jinja_env()
|
||||
assert isinstance(env, Environment)
|
||||
|
||||
def test_has_autoescape(self):
|
||||
"""Environment has autoescape enabled."""
|
||||
env = get_jinja_env()
|
||||
# Default is to autoescape HTML files
|
||||
assert env.autoescape is True or callable(env.autoescape)
|
||||
|
||||
def test_can_load_templates(self, templates_dir):
|
||||
"""Can load templates from the templates directory."""
|
||||
env = get_jinja_env()
|
||||
|
||||
# Should be able to get the base template
|
||||
template = env.get_template("base.html")
|
||||
assert template is not None
|
||||
|
||||
def test_returns_same_instance(self):
|
||||
"""Returns the same environment instance (cached)."""
|
||||
env1 = get_jinja_env()
|
||||
env2 = get_jinja_env()
|
||||
# Implementation may or may not cache - just verify both work
|
||||
assert env1 is not None
|
||||
assert env2 is not None
|
||||
|
||||
|
||||
class TestJinjaFilters:
|
||||
"""Tests for custom Jinja2 filters."""
|
||||
|
||||
@pytest.fixture
|
||||
def env(self):
|
||||
"""Get Jinja2 environment."""
|
||||
return get_jinja_env()
|
||||
|
||||
def test_format_number_filter_exists(self, env):
|
||||
"""format_number filter is registered."""
|
||||
assert "format_number" in env.filters
|
||||
|
||||
def test_format_number_formats_thousands(self, env):
|
||||
"""format_number adds thousand separators."""
|
||||
template = env.from_string("{{ value|format_number }}")
|
||||
|
||||
result = template.render(value=1234567)
|
||||
# Should have some separator
|
||||
assert "1234567" not in result or len(result) > 7
|
||||
|
||||
def test_format_number_handles_none(self, env):
|
||||
"""format_number handles None gracefully."""
|
||||
template = env.from_string("{{ value|format_number }}")
|
||||
|
||||
result = template.render(value=None)
|
||||
# Should return dash or empty string for None
|
||||
assert result in ["-", "N/A", "None", "", " - "]
|
||||
|
||||
def test_format_time_filter_exists(self, env):
|
||||
"""format_time filter is registered."""
|
||||
assert "format_time" in env.filters
|
||||
|
||||
def test_format_time_formats_timestamp(self, env):
|
||||
"""format_time formats Unix timestamp."""
|
||||
template = env.from_string("{{ value|format_time }}")
|
||||
|
||||
# Use a recent timestamp
|
||||
import time
|
||||
ts = int(time.time()) - 3600
|
||||
result = template.render(value=ts)
|
||||
# Should produce some formatted time string
|
||||
assert len(result) > 0
|
||||
|
||||
def test_format_time_handles_none(self, env):
|
||||
"""format_time handles None gracefully."""
|
||||
template = env.from_string("{{ value|format_time }}")
|
||||
|
||||
result = template.render(value=None)
|
||||
assert result in ["-", "N/A", "None", "", " - "]
|
||||
|
||||
def test_format_uptime_filter_exists(self, env):
|
||||
"""format_uptime filter is registered."""
|
||||
assert "format_uptime" in env.filters
|
||||
|
||||
def test_format_uptime_formats_seconds(self, env):
|
||||
"""format_uptime formats seconds to human readable."""
|
||||
template = env.from_string("{{ value|format_uptime }}")
|
||||
|
||||
# 1 day, 2 hours, 30 minutes = 95400 seconds
|
||||
result = template.render(value=95400)
|
||||
# Should produce some duration output
|
||||
assert len(result) > 0
|
||||
|
||||
def test_format_duration_filter_exists(self, env):
|
||||
"""format_duration filter is registered."""
|
||||
assert "format_duration" in env.filters
|
||||
|
||||
def test_format_value_filter_exists(self, env):
|
||||
"""format_value filter is registered."""
|
||||
assert "format_value" in env.filters
|
||||
|
||||
def test_format_compact_number_filter_exists(self, env):
|
||||
"""format_compact_number filter is registered."""
|
||||
assert "format_compact_number" in env.filters
|
||||
|
||||
|
||||
class TestTemplateRendering:
|
||||
"""Tests for basic template rendering."""
|
||||
|
||||
def test_base_template_renders(self):
|
||||
"""Base template renders without error."""
|
||||
env = get_jinja_env()
|
||||
template = env.get_template("base.html")
|
||||
|
||||
# Render with minimal context
|
||||
html = template.render(
|
||||
role="repeater",
|
||||
period="day",
|
||||
title="Test",
|
||||
)
|
||||
|
||||
assert "</html>" in html
|
||||
|
||||
def test_node_template_extends_base(self):
|
||||
"""Node template extends base template."""
|
||||
env = get_jinja_env()
|
||||
template = env.get_template("node.html")
|
||||
|
||||
# Should have access to base template blocks
|
||||
assert template is not None
|
||||
|
||||
def test_template_has_html_structure(self):
|
||||
"""Rendered template has proper HTML structure."""
|
||||
env = get_jinja_env()
|
||||
template = env.get_template("base.html")
|
||||
|
||||
html = template.render(
|
||||
role="repeater",
|
||||
period="day",
|
||||
title="Test Page",
|
||||
)
|
||||
|
||||
assert "<!DOCTYPE html>" in html or "<!doctype html>" in html.lower()
|
||||
assert "<html" in html
|
||||
assert "<head>" in html
|
||||
assert "<body>" in html
|
||||
@@ -0,0 +1,189 @@
|
||||
"""Tests for metrics builder functions."""
|
||||
|
||||
|
||||
from meshmon.html import (
|
||||
_build_traffic_table_rows,
|
||||
build_companion_metrics,
|
||||
build_node_details,
|
||||
build_radio_config,
|
||||
build_repeater_metrics,
|
||||
)
|
||||
|
||||
|
||||
class TestBuildRepeaterMetrics:
|
||||
"""Tests for build_repeater_metrics function."""
|
||||
|
||||
def test_returns_dict(self, sample_repeater_metrics):
|
||||
"""Returns a dictionary."""
|
||||
# build_repeater_metrics takes a row dict (firmware field names)
|
||||
result = build_repeater_metrics(sample_repeater_metrics)
|
||||
assert isinstance(result, dict)
|
||||
|
||||
def test_returns_dict_structure(self, sample_repeater_metrics):
|
||||
"""Returns dict with expected keys."""
|
||||
result = build_repeater_metrics(sample_repeater_metrics)
|
||||
# Should have critical_metrics, secondary_metrics, traffic_metrics
|
||||
assert "critical_metrics" in result
|
||||
assert "secondary_metrics" in result
|
||||
assert "traffic_metrics" in result
|
||||
|
||||
def test_critical_metrics_is_list(self, sample_repeater_metrics):
|
||||
"""Critical metrics is a list."""
|
||||
result = build_repeater_metrics(sample_repeater_metrics)
|
||||
assert isinstance(result["critical_metrics"], list)
|
||||
|
||||
def test_handles_none(self):
|
||||
"""Handles None row."""
|
||||
result = build_repeater_metrics(None)
|
||||
assert isinstance(result, dict)
|
||||
assert result["critical_metrics"] == []
|
||||
|
||||
def test_handles_empty_dict(self):
|
||||
"""Handles empty dict."""
|
||||
result = build_repeater_metrics({})
|
||||
assert isinstance(result, dict)
|
||||
|
||||
|
||||
class TestBuildCompanionMetrics:
|
||||
"""Tests for build_companion_metrics function."""
|
||||
|
||||
def test_returns_dict(self, sample_companion_metrics):
|
||||
"""Returns a dictionary."""
|
||||
result = build_companion_metrics(sample_companion_metrics)
|
||||
assert isinstance(result, dict)
|
||||
|
||||
def test_returns_dict_structure(self, sample_companion_metrics):
|
||||
"""Returns dict with expected keys."""
|
||||
result = build_companion_metrics(sample_companion_metrics)
|
||||
assert "critical_metrics" in result
|
||||
assert "secondary_metrics" in result
|
||||
assert "traffic_metrics" in result
|
||||
|
||||
def test_handles_none(self):
|
||||
"""Handles None row."""
|
||||
result = build_companion_metrics(None)
|
||||
assert isinstance(result, dict)
|
||||
assert result["critical_metrics"] == []
|
||||
|
||||
def test_handles_empty_dict(self):
|
||||
"""Handles empty dict."""
|
||||
result = build_companion_metrics({})
|
||||
assert isinstance(result, dict)
|
||||
|
||||
|
||||
class TestBuildNodeDetails:
|
||||
"""Tests for build_node_details function."""
|
||||
|
||||
def test_returns_list(self, configured_env):
|
||||
"""Returns a list of detail items."""
|
||||
result = build_node_details("repeater")
|
||||
assert isinstance(result, list)
|
||||
|
||||
def test_items_have_label_value(self, configured_env):
|
||||
"""Each item has label and value."""
|
||||
result = build_node_details("repeater")
|
||||
for item in result:
|
||||
assert isinstance(item, dict)
|
||||
assert "label" in item
|
||||
assert "value" in item
|
||||
|
||||
def test_includes_hardware_info(self, configured_env, monkeypatch):
|
||||
"""Includes hardware model info."""
|
||||
monkeypatch.setenv("REPEATER_HARDWARE", "Test LoRa Device")
|
||||
import meshmon.env
|
||||
meshmon.env._config = None
|
||||
|
||||
result = build_node_details("repeater")
|
||||
|
||||
# Should have hardware in one of the items
|
||||
labels = [item.get("label", "").lower() for item in result]
|
||||
assert "hardware" in labels
|
||||
|
||||
def test_different_roles(self, configured_env):
|
||||
"""Different roles return details."""
|
||||
repeater_details = build_node_details("repeater")
|
||||
companion_details = build_node_details("companion")
|
||||
|
||||
assert isinstance(repeater_details, list)
|
||||
assert isinstance(companion_details, list)
|
||||
|
||||
|
||||
class TestBuildRadioConfig:
|
||||
"""Tests for build_radio_config function."""
|
||||
|
||||
def test_returns_list(self, configured_env):
|
||||
"""Returns a list of config items."""
|
||||
result = build_radio_config()
|
||||
assert isinstance(result, list)
|
||||
|
||||
def test_items_have_label_value(self, configured_env):
|
||||
"""Each item has label and value."""
|
||||
result = build_radio_config()
|
||||
for item in result:
|
||||
assert isinstance(item, dict)
|
||||
assert "label" in item
|
||||
assert "value" in item
|
||||
|
||||
def test_includes_frequency_when_set(self, configured_env, monkeypatch):
|
||||
"""Includes frequency when configured."""
|
||||
monkeypatch.setenv("RADIO_FREQUENCY", "869.618 MHz")
|
||||
import meshmon.env
|
||||
meshmon.env._config = None
|
||||
|
||||
result = build_radio_config()
|
||||
|
||||
values = [item.get("value", "") for item in result]
|
||||
assert any("869" in str(v) for v in values)
|
||||
|
||||
def test_handles_missing_config(self, configured_env):
|
||||
"""Returns list even with default config."""
|
||||
result = build_radio_config()
|
||||
assert isinstance(result, list)
|
||||
|
||||
|
||||
class TestBuildTrafficTableRows:
|
||||
"""Tests for _build_traffic_table_rows function."""
|
||||
|
||||
def test_returns_list(self):
|
||||
"""Returns a list of rows."""
|
||||
# Input is list of traffic metric dicts
|
||||
traffic_metrics = [
|
||||
{"label": "RX", "value": "100", "raw_value": 100, "unit": "/min"},
|
||||
{"label": "TX", "value": "50", "raw_value": 50, "unit": "/min"},
|
||||
]
|
||||
rows = _build_traffic_table_rows(traffic_metrics)
|
||||
assert isinstance(rows, list)
|
||||
|
||||
def test_rows_have_structure(self):
|
||||
"""Each row has expected structure."""
|
||||
traffic_metrics = [
|
||||
{"label": "RX", "value": "100", "raw_value": 100, "unit": "/min"},
|
||||
{"label": "TX", "value": "50", "raw_value": 50, "unit": "/min"},
|
||||
]
|
||||
rows = _build_traffic_table_rows(traffic_metrics)
|
||||
|
||||
for row in rows:
|
||||
assert isinstance(row, dict)
|
||||
assert "label" in row
|
||||
assert "rx" in row
|
||||
assert "tx" in row
|
||||
|
||||
def test_handles_empty_list(self):
|
||||
"""Handles empty traffic metrics list."""
|
||||
rows = _build_traffic_table_rows([])
|
||||
assert isinstance(rows, list)
|
||||
assert len(rows) == 0
|
||||
|
||||
def test_combines_rx_tx_pairs(self):
|
||||
"""Combines RX and TX into single row."""
|
||||
traffic_metrics = [
|
||||
{"label": "Flood RX", "value": "100", "raw_value": 100, "unit": "/min"},
|
||||
{"label": "Flood TX", "value": "50", "raw_value": 50, "unit": "/min"},
|
||||
]
|
||||
rows = _build_traffic_table_rows(traffic_metrics)
|
||||
|
||||
# Should have one "Flood" row with both rx and tx
|
||||
assert len(rows) == 1
|
||||
assert rows[0]["label"] == "Flood"
|
||||
assert rows[0]["rx"] == "100"
|
||||
assert rows[0]["tx"] == "50"
|
||||
@@ -0,0 +1,224 @@
|
||||
"""Tests for page context building."""
|
||||
|
||||
import time
|
||||
|
||||
import pytest
|
||||
|
||||
from meshmon.html import (
|
||||
build_page_context,
|
||||
get_status,
|
||||
)
|
||||
|
||||
|
||||
class TestGetStatus:
|
||||
"""Tests for get_status function."""
|
||||
|
||||
def test_online_for_recent_data(self):
|
||||
"""Returns 'online' for data less than 30 minutes old."""
|
||||
# 10 minutes ago
|
||||
recent_ts = int(time.time()) - 600
|
||||
|
||||
status_class, status_label = get_status(recent_ts)
|
||||
|
||||
assert status_class == "online"
|
||||
|
||||
def test_stale_for_medium_age_data(self):
|
||||
"""Returns 'stale' for data 30 minutes to 2 hours old."""
|
||||
# 1 hour ago
|
||||
medium_ts = int(time.time()) - 3600
|
||||
|
||||
status_class, status_label = get_status(medium_ts)
|
||||
|
||||
assert status_class == "stale"
|
||||
|
||||
def test_offline_for_old_data(self):
|
||||
"""Returns 'offline' for data more than 2 hours old."""
|
||||
# 3 hours ago
|
||||
old_ts = int(time.time()) - 10800
|
||||
|
||||
status_class, status_label = get_status(old_ts)
|
||||
|
||||
assert status_class == "offline"
|
||||
|
||||
def test_offline_for_very_old_data(self):
|
||||
"""Returns 'offline' for very old data."""
|
||||
# 7 days ago
|
||||
very_old_ts = int(time.time()) - 604800
|
||||
|
||||
status_class, status_label = get_status(very_old_ts)
|
||||
|
||||
assert status_class == "offline"
|
||||
|
||||
def test_offline_for_none(self):
|
||||
"""Returns 'offline' for None timestamp."""
|
||||
status_class, status_label = get_status(None)
|
||||
|
||||
assert status_class == "offline"
|
||||
|
||||
def test_offline_for_zero(self):
|
||||
"""Returns 'offline' for zero timestamp."""
|
||||
status_class, status_label = get_status(0)
|
||||
|
||||
assert status_class == "offline"
|
||||
|
||||
def test_online_for_current_time(self):
|
||||
"""Returns 'online' for current timestamp."""
|
||||
now_ts = int(time.time())
|
||||
|
||||
status_class, status_label = get_status(now_ts)
|
||||
|
||||
assert status_class == "online"
|
||||
|
||||
def test_boundary_30_minutes(self):
|
||||
"""Tests boundary at exactly 30 minutes."""
|
||||
# Exactly 30 minutes ago
|
||||
boundary_ts = int(time.time()) - 1800
|
||||
|
||||
status_class, _ = get_status(boundary_ts)
|
||||
# At boundary, could be either online or stale depending on implementation
|
||||
assert status_class in ["online", "stale"]
|
||||
|
||||
def test_boundary_2_hours(self):
|
||||
"""Tests boundary at exactly 2 hours."""
|
||||
# Exactly 2 hours ago
|
||||
boundary_ts = int(time.time()) - 7200
|
||||
|
||||
status_class, _ = get_status(boundary_ts)
|
||||
# At boundary, could be either stale or offline
|
||||
assert status_class in ["stale", "offline"]
|
||||
|
||||
def test_returns_tuple(self):
|
||||
"""Returns tuple of (status_class, status_label)."""
|
||||
status = get_status(int(time.time()))
|
||||
assert isinstance(status, tuple)
|
||||
assert len(status) == 2
|
||||
|
||||
def test_status_label_is_string(self):
|
||||
"""Status label is a string."""
|
||||
_, status_label = get_status(int(time.time()))
|
||||
assert isinstance(status_label, str)
|
||||
|
||||
|
||||
class TestBuildPageContext:
|
||||
"""Tests for build_page_context function."""
|
||||
|
||||
@pytest.fixture
|
||||
def sample_row(self, sample_repeater_metrics):
|
||||
"""Create a sample row with timestamp."""
|
||||
row = sample_repeater_metrics.copy()
|
||||
row["ts"] = int(time.time()) - 300 # 5 minutes ago
|
||||
return row
|
||||
|
||||
def test_returns_dict(self, configured_env, sample_row):
|
||||
"""Returns a dictionary."""
|
||||
context = build_page_context(
|
||||
role="repeater",
|
||||
period="day",
|
||||
row=sample_row,
|
||||
at_root=True,
|
||||
)
|
||||
|
||||
assert isinstance(context, dict)
|
||||
|
||||
def test_includes_role_and_period(self, configured_env, sample_row):
|
||||
"""Context includes role and period."""
|
||||
context = build_page_context(
|
||||
role="repeater",
|
||||
period="day",
|
||||
row=sample_row,
|
||||
at_root=True,
|
||||
)
|
||||
|
||||
assert context.get("role") == "repeater"
|
||||
assert context.get("period") == "day"
|
||||
|
||||
def test_includes_status(self, configured_env, sample_row):
|
||||
"""Context includes status indicator."""
|
||||
context = build_page_context(
|
||||
role="repeater",
|
||||
period="day",
|
||||
row=sample_row,
|
||||
at_root=True,
|
||||
)
|
||||
|
||||
assert "status_class" in context
|
||||
assert context["status_class"] in ["online", "stale", "offline"]
|
||||
|
||||
def test_handles_none_row(self, configured_env):
|
||||
"""Handles None row gracefully."""
|
||||
context = build_page_context(
|
||||
role="repeater",
|
||||
period="day",
|
||||
row=None,
|
||||
at_root=True,
|
||||
)
|
||||
|
||||
assert context.get("status_class") == "offline"
|
||||
|
||||
def test_includes_node_name(self, configured_env, sample_row, monkeypatch):
|
||||
"""Context includes node name from config."""
|
||||
monkeypatch.setenv("REPEATER_DISPLAY_NAME", "Test Repeater")
|
||||
import meshmon.env
|
||||
meshmon.env._config = None
|
||||
|
||||
context = build_page_context(
|
||||
role="repeater",
|
||||
period="day",
|
||||
row=sample_row,
|
||||
at_root=True,
|
||||
)
|
||||
|
||||
assert "node_name" in context
|
||||
assert context["node_name"] == "Test Repeater"
|
||||
|
||||
def test_includes_period(self, configured_env, sample_row):
|
||||
"""Context includes current period."""
|
||||
context = build_page_context(
|
||||
role="repeater",
|
||||
period="day",
|
||||
row=sample_row,
|
||||
at_root=True,
|
||||
)
|
||||
|
||||
assert "period" in context
|
||||
assert context["period"] == "day"
|
||||
|
||||
def test_different_roles(self, configured_env, sample_row, sample_companion_metrics):
|
||||
"""Context varies by role."""
|
||||
companion_row = sample_companion_metrics.copy()
|
||||
companion_row["ts"] = int(time.time()) - 300
|
||||
|
||||
repeater_context = build_page_context(
|
||||
role="repeater",
|
||||
period="day",
|
||||
row=sample_row,
|
||||
at_root=True,
|
||||
)
|
||||
companion_context = build_page_context(
|
||||
role="companion",
|
||||
period="day",
|
||||
row=companion_row,
|
||||
at_root=False,
|
||||
)
|
||||
|
||||
assert repeater_context["role"] == "repeater"
|
||||
assert companion_context["role"] == "companion"
|
||||
|
||||
def test_at_root_affects_css_path(self, configured_env, sample_row):
|
||||
"""at_root parameter affects CSS path."""
|
||||
root_context = build_page_context(
|
||||
role="repeater",
|
||||
period="day",
|
||||
row=sample_row,
|
||||
at_root=True,
|
||||
)
|
||||
non_root_context = build_page_context(
|
||||
role="companion",
|
||||
period="day",
|
||||
row=sample_row,
|
||||
at_root=False,
|
||||
)
|
||||
|
||||
# Non-root pages need relative path to CSS
|
||||
assert "css_path" in root_context or "at_root" in root_context
|
||||
assert "css_path" in non_root_context or "at_root" in non_root_context
|
||||
@@ -0,0 +1,98 @@
|
||||
"""Tests for reports index page generation."""
|
||||
|
||||
|
||||
import pytest
|
||||
|
||||
from meshmon.html import render_reports_index
|
||||
|
||||
|
||||
class TestRenderReportsIndex:
|
||||
"""Tests for render_reports_index function."""
|
||||
|
||||
@pytest.fixture
|
||||
def sample_report_sections(self):
|
||||
"""Sample report sections for testing."""
|
||||
return [
|
||||
{
|
||||
"role": "repeater",
|
||||
"years": [
|
||||
{
|
||||
"year": 2024,
|
||||
"months": [
|
||||
{"month": 1, "name": "January"},
|
||||
{"month": 2, "name": "February"},
|
||||
]
|
||||
}
|
||||
]
|
||||
},
|
||||
{
|
||||
"role": "companion",
|
||||
"years": [
|
||||
{
|
||||
"year": 2024,
|
||||
"months": [
|
||||
{"month": 1, "name": "January"},
|
||||
]
|
||||
}
|
||||
]
|
||||
},
|
||||
]
|
||||
|
||||
def test_returns_html_string(self, configured_env, sample_report_sections):
|
||||
"""Returns an HTML string."""
|
||||
html = render_reports_index(sample_report_sections)
|
||||
|
||||
assert isinstance(html, str)
|
||||
assert len(html) > 0
|
||||
|
||||
def test_html_structure(self, configured_env, sample_report_sections):
|
||||
"""Generated HTML has proper structure."""
|
||||
html = render_reports_index(sample_report_sections)
|
||||
|
||||
assert "<!DOCTYPE html>" in html or "<!doctype html>" in html.lower()
|
||||
assert "</html>" in html
|
||||
|
||||
def test_includes_title(self, configured_env, sample_report_sections):
|
||||
"""Index page includes title."""
|
||||
html = render_reports_index(sample_report_sections)
|
||||
|
||||
assert "<title>" in html
|
||||
assert "Report" in html or "report" in html
|
||||
|
||||
def test_includes_year(self, configured_env, sample_report_sections):
|
||||
"""Lists available years."""
|
||||
html = render_reports_index(sample_report_sections)
|
||||
|
||||
assert "2024" in html
|
||||
|
||||
def test_handles_empty_sections(self, configured_env):
|
||||
"""Handles empty report sections."""
|
||||
html = render_reports_index([])
|
||||
|
||||
assert isinstance(html, str)
|
||||
assert "</html>" in html
|
||||
|
||||
def test_includes_role_names(self, configured_env, sample_report_sections):
|
||||
"""Includes role names in output."""
|
||||
html = render_reports_index(sample_report_sections)
|
||||
|
||||
# Should mention both roles
|
||||
assert "repeater" in html.lower() or "Repeater" in html
|
||||
|
||||
def test_includes_css_reference(self, configured_env, sample_report_sections):
|
||||
"""Includes reference to stylesheet."""
|
||||
html = render_reports_index(sample_report_sections)
|
||||
|
||||
assert "styles.css" in html
|
||||
|
||||
def test_handles_sections_without_years(self, configured_env):
|
||||
"""Handles sections with no years."""
|
||||
sections = [
|
||||
{"role": "repeater", "years": []},
|
||||
{"role": "companion", "years": []},
|
||||
]
|
||||
|
||||
html = render_reports_index(sections)
|
||||
|
||||
assert isinstance(html, str)
|
||||
assert "</html>" in html
|
||||
@@ -0,0 +1,195 @@
|
||||
"""Tests for write_site and related output functions."""
|
||||
|
||||
|
||||
import pytest
|
||||
|
||||
from meshmon.db import get_latest_metrics
|
||||
from meshmon.html import (
|
||||
copy_static_assets,
|
||||
write_site,
|
||||
)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def metrics_rows(populated_db):
|
||||
"""Get latest metrics rows for both roles."""
|
||||
companion_row = get_latest_metrics("companion")
|
||||
repeater_row = get_latest_metrics("repeater")
|
||||
return {"companion": companion_row, "repeater": repeater_row}
|
||||
|
||||
|
||||
class TestWriteSite:
|
||||
"""Tests for write_site function."""
|
||||
|
||||
def test_creates_output_directory(self, configured_env, metrics_rows):
|
||||
"""Creates output directory if it doesn't exist."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
|
||||
write_site(metrics_rows["companion"], metrics_rows["repeater"])
|
||||
|
||||
assert out_dir.exists()
|
||||
|
||||
def test_generates_repeater_pages(self, configured_env, metrics_rows):
|
||||
"""Generates repeater HTML pages at root."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
|
||||
write_site(metrics_rows["companion"], metrics_rows["repeater"])
|
||||
|
||||
# Repeater pages are at root
|
||||
for period in ["day", "week", "month", "year"]:
|
||||
assert (out_dir / f"{period}.html").exists()
|
||||
|
||||
def test_generates_companion_pages(self, configured_env, metrics_rows):
|
||||
"""Generates companion HTML pages in subdirectory."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
|
||||
write_site(metrics_rows["companion"], metrics_rows["repeater"])
|
||||
|
||||
companion_dir = out_dir / "companion"
|
||||
assert companion_dir.exists()
|
||||
for period in ["day", "week", "month", "year"]:
|
||||
assert (companion_dir / f"{period}.html").exists()
|
||||
|
||||
def test_html_files_are_valid(self, configured_env, metrics_rows):
|
||||
"""Generated HTML files have valid structure."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
|
||||
write_site(metrics_rows["companion"], metrics_rows["repeater"])
|
||||
|
||||
html_file = out_dir / "day.html"
|
||||
content = html_file.read_text()
|
||||
|
||||
assert "<!DOCTYPE html>" in content or "<!doctype html>" in content.lower()
|
||||
assert "</html>" in content
|
||||
|
||||
def test_handles_empty_database(self, configured_env, initialized_db):
|
||||
"""Handles empty database gracefully."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
|
||||
# Should not raise - pass None for empty database
|
||||
write_site(None, None)
|
||||
|
||||
# Should still generate pages
|
||||
assert (out_dir / "day.html").exists()
|
||||
|
||||
|
||||
class TestCopyStaticAssets:
|
||||
"""Tests for copy_static_assets function."""
|
||||
|
||||
def test_copies_css(self, configured_env):
|
||||
"""Copies CSS stylesheet."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
out_dir.mkdir(parents=True, exist_ok=True)
|
||||
|
||||
copy_static_assets()
|
||||
|
||||
css_file = out_dir / "styles.css"
|
||||
assert css_file.exists()
|
||||
|
||||
def test_copies_javascript(self, configured_env):
|
||||
"""Copies JavaScript files."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
out_dir.mkdir(parents=True, exist_ok=True)
|
||||
|
||||
copy_static_assets()
|
||||
|
||||
js_file = out_dir / "chart-tooltip.js"
|
||||
assert js_file.exists()
|
||||
|
||||
def test_css_is_valid(self, configured_env):
|
||||
"""Copied CSS has expected content."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
out_dir.mkdir(parents=True, exist_ok=True)
|
||||
|
||||
copy_static_assets()
|
||||
|
||||
css_file = out_dir / "styles.css"
|
||||
content = css_file.read_text()
|
||||
|
||||
# Should have CSS variables
|
||||
assert "--" in content or "{" in content
|
||||
|
||||
def test_requires_output_directory(self, configured_env):
|
||||
"""Requires output directory to exist."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
# Ensure out_dir exists
|
||||
out_dir.mkdir(parents=True, exist_ok=True)
|
||||
|
||||
# Should not raise when directory exists
|
||||
copy_static_assets()
|
||||
|
||||
assert (out_dir / "styles.css").exists()
|
||||
|
||||
def test_overwrites_existing(self, configured_env):
|
||||
"""Overwrites existing static files."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
out_dir.mkdir(parents=True, exist_ok=True)
|
||||
|
||||
# Create a fake CSS file
|
||||
css_file = out_dir / "styles.css"
|
||||
css_file.write_text("/* fake */")
|
||||
|
||||
copy_static_assets()
|
||||
|
||||
# Should be overwritten with real content
|
||||
content = css_file.read_text()
|
||||
assert "/* fake */" not in content or len(content) > 20
|
||||
|
||||
|
||||
class TestHtmlOutput:
|
||||
"""Tests for HTML output structure."""
|
||||
|
||||
def test_pages_include_navigation(self, configured_env, metrics_rows):
|
||||
"""HTML pages include navigation."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
|
||||
write_site(metrics_rows["companion"], metrics_rows["repeater"])
|
||||
|
||||
content = (out_dir / "day.html").read_text()
|
||||
|
||||
# Should have links to other periods
|
||||
assert "week" in content.lower()
|
||||
assert "month" in content.lower()
|
||||
|
||||
def test_pages_include_meta_tags(self, configured_env, metrics_rows):
|
||||
"""HTML pages include meta tags."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
|
||||
write_site(metrics_rows["companion"], metrics_rows["repeater"])
|
||||
|
||||
content = (out_dir / "day.html").read_text()
|
||||
|
||||
assert "<meta" in content
|
||||
assert "charset" in content.lower() or "utf-8" in content.lower()
|
||||
|
||||
def test_pages_include_title(self, configured_env, metrics_rows):
|
||||
"""HTML pages include title tag."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
|
||||
write_site(metrics_rows["companion"], metrics_rows["repeater"])
|
||||
|
||||
content = (out_dir / "day.html").read_text()
|
||||
|
||||
assert "<title>" in content
|
||||
assert "</title>" in content
|
||||
|
||||
def test_pages_reference_css(self, configured_env, metrics_rows):
|
||||
"""HTML pages reference stylesheet."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
|
||||
write_site(metrics_rows["companion"], metrics_rows["repeater"])
|
||||
|
||||
content = (out_dir / "day.html").read_text()
|
||||
|
||||
assert "styles.css" in content
|
||||
|
||||
def test_companion_pages_relative_css(self, configured_env, metrics_rows):
|
||||
"""Companion pages use relative path to CSS."""
|
||||
out_dir = configured_env["out_dir"]
|
||||
|
||||
write_site(metrics_rows["companion"], metrics_rows["repeater"])
|
||||
|
||||
content = (out_dir / "companion" / "day.html").read_text()
|
||||
|
||||
# Should reference parent directory CSS
|
||||
assert "../styles.css" in content or "styles.css" in content
|
||||
Reference in New Issue
Block a user