mirror of
https://github.com/ipnet-mesh/meshcore-hub.git
synced 2026-06-26 13:01:55 +02:00
Louis King
888e193e09
The observed_by filter on messages, advertisements, telemetry, and trace_paths matched only the first observer (stored in observer_node_id), silently excluding events whose secondary observers appear only in the event_observers junction table. This caused filtered lists to appear 'several hours behind' when a dominant observer consistently won the first-insert race for recent events. Replace the ObserverNode.public_key predicate with an IN subquery against the event_observers junction table (the canonical multi-observer source already used for display). Add a shared observed_by_filter_clause() helper in observer_utils.py to avoid duplication across all four routes. Add regression tests proving a secondary observer (present only in event_observers) sees events via the filter. Update existing fixtures and inline test data to seed event_hash and EventObserver rows. Fixes #239
236 lines
8.4 KiB
Python
236 lines
8.4 KiB
Python
"""Tests for telemetry API routes."""
|
|
|
|
from datetime import datetime, timedelta, timezone
|
|
|
|
|
|
class TestListTelemetry:
|
|
"""Tests for GET /telemetry endpoint."""
|
|
|
|
def test_list_telemetry_empty(self, client_no_auth):
|
|
"""Test listing telemetry when database is empty."""
|
|
response = client_no_auth.get("/api/v1/telemetry")
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
assert data["items"] == []
|
|
assert data["total"] == 0
|
|
|
|
def test_list_telemetry_with_data(self, client_no_auth, sample_telemetry):
|
|
"""Test listing telemetry with data in database."""
|
|
response = client_no_auth.get("/api/v1/telemetry")
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
assert len(data["items"]) == 1
|
|
assert data["total"] == 1
|
|
assert data["items"][0]["node_public_key"] == sample_telemetry.node_public_key
|
|
assert data["items"][0]["parsed_data"] == sample_telemetry.parsed_data
|
|
|
|
def test_list_telemetry_filter_by_node(self, client_no_auth, sample_telemetry):
|
|
"""Test filtering telemetry by node public key."""
|
|
response = client_no_auth.get(
|
|
f"/api/v1/telemetry?node_public_key={sample_telemetry.node_public_key}"
|
|
)
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
assert len(data["items"]) == 1
|
|
|
|
response = client_no_auth.get("/api/v1/telemetry?node_public_key=nonexistent")
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
assert len(data["items"]) == 0
|
|
|
|
|
|
class TestGetTelemetry:
|
|
"""Tests for GET /telemetry/{id} endpoint."""
|
|
|
|
def test_get_telemetry_success(self, client_no_auth, sample_telemetry):
|
|
"""Test getting a specific telemetry record."""
|
|
response = client_no_auth.get(f"/api/v1/telemetry/{sample_telemetry.id}")
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
assert data["node_public_key"] == sample_telemetry.node_public_key
|
|
|
|
def test_get_telemetry_not_found(self, client_no_auth):
|
|
"""Test getting a non-existent telemetry record."""
|
|
response = client_no_auth.get("/api/v1/telemetry/nonexistent-id")
|
|
assert response.status_code == 404
|
|
|
|
|
|
class TestListTelemetryFilters:
|
|
"""Tests for telemetry list query filters."""
|
|
|
|
def test_filter_by_observed_by(
|
|
self,
|
|
client_no_auth,
|
|
sample_telemetry,
|
|
sample_telemetry_with_receiver,
|
|
receiver_node,
|
|
):
|
|
"""Test filtering telemetry by receiver node."""
|
|
response = client_no_auth.get(
|
|
f"/api/v1/telemetry?observed_by={receiver_node.public_key}"
|
|
)
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
assert len(data["items"]) == 1
|
|
|
|
def test_filter_by_observed_by_secondary_observer(
|
|
self,
|
|
client_no_auth,
|
|
api_db_session,
|
|
):
|
|
"""Secondary observer (only in event_observers) sees the telemetry."""
|
|
from meshcore_hub.common.hash_utils import compute_telemetry_hash
|
|
from meshcore_hub.common.models import EventObserver, Node, Telemetry
|
|
|
|
primary_node = Node(
|
|
public_key="p1telp1telp1telp1telp1telp1telp1",
|
|
name="PrimaryObserver",
|
|
first_seen=datetime.now(timezone.utc),
|
|
)
|
|
secondary_node = Node(
|
|
public_key="s1tels1tels1tels1tels1tels1tels1",
|
|
name="SecondaryObserver",
|
|
first_seen=datetime.now(timezone.utc),
|
|
)
|
|
api_db_session.add_all([primary_node, secondary_node])
|
|
api_db_session.commit()
|
|
|
|
now = datetime.now(timezone.utc)
|
|
node_pk = "secobstelsecobstelsecobsteltel"
|
|
event_hash = compute_telemetry_hash(
|
|
node_public_key=node_pk,
|
|
parsed_data={"temperature": 42.0},
|
|
received_at=now,
|
|
)
|
|
telemetry = Telemetry(
|
|
node_public_key=node_pk,
|
|
parsed_data={"temperature": 42.0},
|
|
received_at=now,
|
|
observer_node_id=primary_node.id,
|
|
event_hash=event_hash,
|
|
)
|
|
api_db_session.add(telemetry)
|
|
api_db_session.commit()
|
|
|
|
api_db_session.add(
|
|
EventObserver(
|
|
event_type="telemetry",
|
|
event_hash=event_hash,
|
|
observer_node_id=secondary_node.id,
|
|
observed_at=datetime.now(timezone.utc),
|
|
)
|
|
)
|
|
api_db_session.commit()
|
|
|
|
response = client_no_auth.get(
|
|
f"/api/v1/telemetry?observed_by={secondary_node.public_key}"
|
|
)
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
assert len(data["items"]) == 1
|
|
assert data["items"][0]["observed_by"] == primary_node.public_key
|
|
|
|
def test_filter_by_since(self, client_no_auth, api_db_session):
|
|
"""Test filtering telemetry by since timestamp."""
|
|
from meshcore_hub.common.models import Telemetry
|
|
|
|
now = datetime.now(timezone.utc)
|
|
old_time = now - timedelta(days=7)
|
|
|
|
# Create old telemetry
|
|
old_telemetry = Telemetry(
|
|
node_public_key="old123old123old123old123old123ol",
|
|
parsed_data={"battery_level": 10.0},
|
|
received_at=old_time,
|
|
)
|
|
api_db_session.add(old_telemetry)
|
|
api_db_session.commit()
|
|
|
|
# Filter since yesterday - should not include old telemetry
|
|
since = (now - timedelta(days=1)).strftime("%Y-%m-%dT%H:%M:%S")
|
|
response = client_no_auth.get(f"/api/v1/telemetry?since={since}")
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
assert len(data["items"]) == 0
|
|
|
|
def test_filter_by_until(self, client_no_auth, api_db_session):
|
|
"""Test filtering telemetry by until timestamp."""
|
|
from meshcore_hub.common.models import Telemetry
|
|
|
|
now = datetime.now(timezone.utc)
|
|
old_time = now - timedelta(days=7)
|
|
|
|
# Create old telemetry
|
|
old_telemetry = Telemetry(
|
|
node_public_key="until123until123until123until12",
|
|
parsed_data={"battery_level": 20.0},
|
|
received_at=old_time,
|
|
)
|
|
api_db_session.add(old_telemetry)
|
|
api_db_session.commit()
|
|
|
|
# Filter until 5 days ago - should include old telemetry
|
|
until = (now - timedelta(days=5)).strftime("%Y-%m-%dT%H:%M:%S")
|
|
response = client_no_auth.get(f"/api/v1/telemetry?until={until}")
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
assert len(data["items"]) == 1
|
|
|
|
|
|
class TestTelemetryObservers:
|
|
"""Tests for observer data in telemetry API responses."""
|
|
|
|
def test_telemetry_observers_populated(self, client_no_auth, api_db_session):
|
|
"""Test that telemetry list returns observers with data."""
|
|
from meshcore_hub.common.hash_utils import compute_telemetry_hash
|
|
from meshcore_hub.common.models import EventObserver, Node, Telemetry
|
|
|
|
observer_node = Node(
|
|
public_key="z" * 64,
|
|
name="TelObserver",
|
|
first_seen=datetime.now(timezone.utc),
|
|
)
|
|
api_db_session.add(observer_node)
|
|
api_db_session.flush()
|
|
|
|
now = datetime.now(timezone.utc)
|
|
event_hash = compute_telemetry_hash(
|
|
node_public_key="tel123tel123tel123tel123tel123tel",
|
|
parsed_data={"temperature": 22.0},
|
|
received_at=now,
|
|
)
|
|
telemetry = Telemetry(
|
|
node_public_key="tel123tel123tel123tel123tel123tel",
|
|
parsed_data={"temperature": 22.0},
|
|
received_at=now,
|
|
observer_node_id=observer_node.id,
|
|
event_hash=event_hash,
|
|
)
|
|
api_db_session.add(telemetry)
|
|
api_db_session.flush()
|
|
|
|
ev_obs = EventObserver(
|
|
event_type="telemetry",
|
|
event_hash=event_hash,
|
|
observer_node_id=observer_node.id,
|
|
snr=8.5,
|
|
path_len=2,
|
|
observed_at=now,
|
|
)
|
|
api_db_session.add(ev_obs)
|
|
api_db_session.commit()
|
|
|
|
response = client_no_auth.get("/api/v1/telemetry")
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
items = data["items"]
|
|
assert len(items) >= 1
|
|
tel_item = next(
|
|
i
|
|
for i in items
|
|
if i["node_public_key"] == "tel123tel123tel123tel123tel123tel"
|
|
)
|
|
assert len(tel_item["observers"]) == 1
|
|
assert tel_item["observers"][0]["snr"] == 8.5
|
|
assert tel_item["observers"][0]["path_len"] == 2
|