mirror of
https://github.com/MarekWo/mc-webui.git
synced 2026-08-05 08:22:30 +02:00
perf: let the realtime socket upgrade to a WebSocket
Three tabs open made every endpoint answer in ~20s, which two sessions read as contention on a shared server-side lock. It wasn't the server. With 3 tabs open, /health - which touches neither the database nor the device - measured a 14.7s median from inside a tab and 11ms from a client outside the browser at the same instant. The server was idle throughout. Socket.IO clients pinned transports: ['polling'], upgrade: false, so each tab held one HTTP connection open for its whole lifetime. Browsers allow six concurrent HTTP/1.1 connections per origin, shared across every tab, so three tabs consumed the pool and everything else queued in the browser waiting for a free connection. /proc/net/tcp in the container confirmed it: pinned at exactly 6 established connections, unmoving. The pin dates from1d47c9c, when werkzeug had no WebSocket support and every upgrade attempt returned HTTP 500. python-engineio==4.8.1 (pinned five weeks later, ind3590f9) pulls in simple-websocket, which fixed that; the workaround had outlived its premise. Drop it and use the default transports, which open on polling and upgrade. A WebSocket is not part of the HTTP pool, so the pool is released. Where the upgrade is blocked - a proxy that drops the Upgrade header - the client stays on polling by itself, which is exactly today's behaviour. Measured with 3 tabs, in-page medians: /health 14664ms -> 12ms, /api/status 19282ms -> 64ms, both now matching what the same probes read from outside the browser. All three tabs report transport "websocket", server pushes still arrive over it, and the log no longer fills with "Session is disconnected" (0 occurrences, 0 tracebacks across the run). Also corrects the earlier diagnosis in the docs: the per-endpoint timings that looked like a lock were measured request->requestfinished in the browser, which includes connection-queue time, so every endpoint flattened to the same figure regardless of its own cost. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -482,9 +482,14 @@ function connectChatSocket() {
|
||||
}
|
||||
|
||||
const wsUrl = window.location.origin;
|
||||
// Default transports (polling, then upgrade to websocket). Long-polling was
|
||||
// pinned in 1d47c9c because werkzeug had no websocket support; python-engineio
|
||||
// 4.8.1 pulled in simple-websocket and it does now. Polling holds an HTTP
|
||||
// connection open per tab, and browsers only allow six per origin, so three
|
||||
// tabs starved every other request of a connection for tens of seconds.
|
||||
// Upgrading moves that connection out of the HTTP pool. Where the upgrade is
|
||||
// blocked (a proxy that drops Upgrade), the client stays on polling by itself.
|
||||
chatSocket = io(wsUrl + '/chat', {
|
||||
transports: ['polling'],
|
||||
upgrade: false,
|
||||
reconnection: true,
|
||||
reconnectionDelay: 2000,
|
||||
reconnectionDelayMax: 10000,
|
||||
|
||||
@@ -37,9 +37,8 @@ function connectWebSocket() {
|
||||
console.log('Connecting to WebSocket:', wsUrl);
|
||||
|
||||
try {
|
||||
// Default transports — see the note in app.js connectChatSocket().
|
||||
socket = io(wsUrl + '/console', {
|
||||
transports: ['polling'],
|
||||
upgrade: false,
|
||||
reconnection: true,
|
||||
reconnectionAttempts: Infinity,
|
||||
reconnectionDelay: 1000,
|
||||
|
||||
+1
-2
@@ -149,9 +149,8 @@ function connectChatSocket() {
|
||||
}
|
||||
|
||||
const wsUrl = window.location.origin;
|
||||
// Default transports — see the note in app.js connectChatSocket().
|
||||
chatSocket = io(wsUrl + '/chat', {
|
||||
transports: ['polling'],
|
||||
upgrade: false,
|
||||
reconnection: true,
|
||||
reconnectionDelay: 2000,
|
||||
reconnectionDelayMax: 10000,
|
||||
|
||||
@@ -32,9 +32,8 @@
|
||||
const LEVEL_ORDER = { DEBUG: 0, INFO: 1, WARNING: 2, ERROR: 3, CRITICAL: 4 };
|
||||
|
||||
// --- WebSocket ---
|
||||
// Default transports — see the note in app.js connectChatSocket().
|
||||
const socket = io('/logs', {
|
||||
transports: ['polling'],
|
||||
upgrade: false,
|
||||
reconnection: true,
|
||||
reconnectionDelay: 2000,
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user