adam/map.meshcore.dev-uploader
1
0 Fork 0
mirror of https://github.com/recrof/map.meshcore.io-uploader.git synced 2026-11-02 03:45:49 +01:00
Code Issues 3 Packages Projects Releases Wiki Activity

Uploader forwards "invisible" nodes with type 0 #4

New Issue
Closed
opened 2026-10-27 16:44:22 +01:00 by adam · 1 comment
adam commented 2026-10-27 16:44:22 +01:00
Owner
Copy link
Copy source

On the map there are currently 2 nodes with type set to 0.
Valid node types should be 1–4 (companion, repeater, room server, sensor).

These nodes appear to advertise this type by the devices themselves with flags & 0x0F == 0 (ADV_TYPE_NONE), likely due to bad or custom firmware.

The map cannot display these nodes because there is no valid icon for this type.
How other MeshCore applications handle type 0 nodes has not been verified.

If not, can be fixed:

  • Uploader-side: Filter them out by skipping adverts where parsed.type === 'NONE' (in map.meshcore.dev-uploader) ?
  • API-side: Reject or normalize type: 0 when processing uploads (would cover uploader, app, (and I guess, depreciated web uploads?))
    If so, this should be reported in different repo
On the map there are currently 2 nodes with `type` set to `0`. Valid node types should be 1–4 (companion, repeater, room server, sensor). These nodes appear to advertise this type by the devices themselves with `flags & 0x0F == 0` `(ADV_TYPE_NONE)`, likely due to bad or custom firmware. The map cannot display these nodes because there is no valid icon for this type. How other MeshCore applications handle type 0 nodes has not been verified. - Should we allow `type: 0` nodes on [map.meshcore.dev](https://map.meshcore.dev)? Is there any need for it? If not, can be fixed: - Uploader-side: Filter them out by skipping adverts where `parsed.type === 'NONE'` (in map.meshcore.dev-uploader) ? - API-side: Reject or normalize `type: 0` when processing uploads (would cover uploader, app, (and I guess, depreciated web uploads?)) If so, this should be reported in [different repo](https://github.com/meshcore-dev/map.meshcore.dev) <!-- github-sync-id:4018929510 -->
adam closed this issue 2026-10-27 16:44:22 +01:00
adam commented 2026-10-27 16:44:22 +01:00
Author
Owner
Copy link
Copy source

type 0 adverts are now blocked in the map.meshcore.dev api

type 0 adverts are now blocked in the map.meshcore.dev api <!-- github-comment-id:4118362203 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/map.meshcore.dev-uploader#4